Skip to content

Correlation Key property added#5354

Merged
veronicagg merged 4 commits intomasterfrom
unknown repository
Mar 15, 2019
Merged

Correlation Key property added#5354
veronicagg merged 4 commits intomasterfrom
unknown repository

Conversation

@ghost
Copy link

@ghost ghost commented Mar 10, 2019

Added additional property - CorrelationKey to alerts in specification/security/resource-manager/

@AutorestCI
Copy link

AutorestCI commented Mar 10, 2019 •
edited
Loading

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI AutorestCI mentioned this pull request Mar 10, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Mar 10, 2019 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#3782

@AutorestCI
Copy link

AutorestCI commented Mar 10, 2019 •
edited
Loading

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@AutorestCI AutorestCI mentioned this pull request Mar 10, 2019
Closed
@AutorestCI
Copy link

AutorestCI commented Mar 10, 2019 •
edited
Loading

Automation for azure-sdk-for-js

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-js#1582

@azuresdkci azuresdkci requested a review from veronicagg March 10, 2019 16:49
@azuresdkci
Copy link
Contributor

azuresdkci commented Mar 10, 2019

Can one of the admins verify this patch?

@AutorestCI AutorestCI mentioned this pull request Mar 10, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Mar 10, 2019 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#4288

@AutorestCI AutorestCI mentioned this pull request Mar 10, 2019
Closed
@AutorestCI
Copy link

AutorestCI commented Mar 10, 2019 •
edited
Loading

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#4922

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request Mar 10, 2019
@adxsdknet
.NET SDK Resource Provider:'SecurityCenter'
5cce336 
REST Spec PR 'Azure/azure-rest-api-specs#5354'
REST Spec PR Author 't-nishab'
REST Spec PR Last commit
nschonni
nschonni reviewed Mar 11, 2019
View reviewed changes
Copy link
Contributor

@nschonni nschonni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there are some tab/space indentation issues

This was referenced Mar 12, 2019
Closed
Closed
@adxsdknet
Copy link

adxsdknet commented Mar 12, 2019 •
edited
Loading

Automation for azure-sdk-for-net

A PR has been created for you:
Azure/azure-sdk-for-net#5404
.NET SDK Commits:
adxsdknet/azure-sdk-for-net@38e3cf4
adxsdknet/azure-sdk-for-net@48674ff

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request Mar 12, 2019
@adxsdknet
.NET SDK Resource Provider:'SecurityCenter'
38e3cf4 
REST Spec PR 'Azure/azure-rest-api-specs#5354'
REST Spec PR Author 't-nishab'
REST Spec PR Last commit
@orparnes
Copy link
Contributor

orparnes commented Mar 12, 2019

@orparnes is added to the review. #Closed

veronicagg
veronicagg suggested changes Mar 12, 2019
View reviewed changes
...fication/security/resource-manager/Microsoft.Security/preview/2015-06-01-preview/alerts.json
"readOnly": true,
"type": "string",
"description": "Azure resource ID of the workspace that the alert was reported to."
},
Copy link
Contributor

@veronicagg veronicagg Mar 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor: could you indent this property the same number of spaces as the other properties are?

Copy link
Author

@ghost ghost Mar 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

caused due to the interpretation of tabs to spaces in the ide, fixed now.

specification/security/resource-manager/Microsoft.Security/stable/2019-01-01/alerts.json Outdated
"description": "Azure resource ID of the workspace that the alert was reported to."
}
},
"correlationKey": {
Copy link
Contributor

@veronicagg veronicagg Mar 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor: could you fix indenting (same comment as in the other spec)?

Copy link
Author

@ghost ghost Mar 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request Mar 14, 2019
@adxsdknet
.NET SDK Resource Provider:'SecurityCenter'
48674ff 
REST Spec PR 'Azure/azure-rest-api-specs#5354'
REST Spec PR Author 't-nishab'
REST Spec PR Last commit
This was referenced Mar 14, 2019
Merged
Merged
veronicagg
veronicagg approved these changes Mar 15, 2019
View reviewed changes
Copy link
Contributor

@veronicagg veronicagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for addressing the comments.

@veronicagg veronicagg merged commit 9f77cfc into Azure:master Mar 15, 2019
dsgouda pushed a commit to Azure/azure-sdk-for-net that referenced this pull request Mar 18, 2019
@adxsdknet @dsgouda
AutoPr-SecurityCenter-t-nishab-REST Spec PrNumber 5354 (#5404)
198f6b8 
* .NET SDK Resource Provider:'SecurityCenter'
REST Spec PR 'Azure/azure-rest-api-specs#5354'
REST Spec PR Author 't-nishab'
REST Spec PR Last commit

* .NET SDK Resource Provider:'SecurityCenter'
REST Spec PR 'Azure/azure-rest-api-specs#5354'
REST Spec PR Author 't-nishab'
REST Spec PR Last commit
chidozieononiwu pushed a commit to chidozieononiwu/azure-sdk-for-net that referenced this pull request Mar 26, 2019
@adxsdknet @chidozieononiwu
AutoPr-SecurityCenter-t-nishab-REST Spec PrNumber 5354 (Azure#5404)
c389a9f 
* .NET SDK Resource Provider:'SecurityCenter'
REST Spec PR 'Azure/azure-rest-api-specs#5354'
REST Spec PR Author 't-nishab'
REST Spec PR Last commit

* .NET SDK Resource Provider:'SecurityCenter'
REST Spec PR 'Azure/azure-rest-api-specs#5354'
REST Spec PR Author 't-nishab'
REST Spec PR Last commit
mentat9 pushed a commit to mentat9/azure-sdk-for-net that referenced this pull request Jun 10, 2019
@adxsdknet @mentat9
AutoPr-SecurityCenter-t-nishab-REST Spec PrNumber 5354 (Azure#5404)
da259d6 
* .NET SDK Resource Provider:'SecurityCenter'
REST Spec PR 'Azure/azure-rest-api-specs#5354'
REST Spec PR Author 't-nishab'
REST Spec PR Last commit

* .NET SDK Resource Provider:'SecurityCenter'
REST Spec PR 'Azure/azure-rest-api-specs#5354'
REST Spec PR Author 't-nishab'
REST Spec PR Last commit
mccleanp pushed a commit that referenced this pull request Mar 23, 2022
@srswamy-msft
Remove conflicting readonly property (#5354)
81534dd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@veronicagg veronicagg

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@AutorestCI @azuresdkci @adxsdknet @orparnes @nschonni @veronicagg