Elastic Server Restart by ravindrakreddy · Pull Request #5244 · Azure/azure-rest-api-specs

ravindrakreddy · 2019-02-21T20:50:31Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

ravindrakreddy · 2019-02-21T20:50:53Z

Adding Qingqing Yuan to review the code

AutorestCI · 2019-02-21T20:50:58Z

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

AutorestCI · 2019-02-21T20:51:33Z

Automation for azure-sdk-for-python

A PR has been created for you:
Azure/azure-sdk-for-python#4400

AutorestCI · 2019-02-21T20:51:40Z

Automation for azure-sdk-for-js

Encountered an unknown error: (azure-sdk-for-js)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 310, in generate_sdk_from_git_object
    sdk_repo.git.push('origin', branch_name, set_upstream=True)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git push --set-upstream origin restapi_auto_5244
  stderr: 'remote: Permission to Azure/azure-sdk-for-js.git denied to AutorestCI.
fatal: unable to access 'https://AutorestCI:58ab395c311d1bd75b3e1db1cc8adaf9acc42afe@github.com/Azure/azure-sdk-for-js.git/': The requested URL returned error: 403'

AutorestCI · 2019-02-21T20:51:45Z

Automation for azure-sdk-for-java

Encountered an unknown error: (azure-sdk-for-java)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 310, in generate_sdk_from_git_object
    sdk_repo.git.push('origin', branch_name, set_upstream=True)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git push --set-upstream origin restapi_auto_5244
  stderr: 'remote: Permission to Azure/azure-sdk-for-java.git denied to AutorestCI.
fatal: unable to access 'https://AutorestCI:58ab395c311d1bd75b3e1db1cc8adaf9acc42afe@github.com/Azure/azure-sdk-for-java.git/': The requested URL returned error: 403'

AutorestCI · 2019-02-21T20:52:33Z

Automation for azure-sdk-for-node

A PR has been created for you:
Azure/azure-sdk-for-node#4728

AutorestCI · 2019-02-21T20:53:58Z

Automation for azure-sdk-for-go

A PR has been created for you:
Azure/azure-sdk-for-go#4123

azuresdkci · 2019-02-21T21:12:18Z

Can one of the admins verify this patch?

praries880 · 2019-02-22T17:47:55Z

specification/mysql/resource-manager/Microsoft.DBforMySQL/stable/2017-12-01/mysql.json

+        "tags": [
+          "ServerRestart"
+        ],
+        "operationId": "Server_Restart",


this “"operationId": "Server_Restart”,” should be “"operationId": "Servers_Restart”,”

Suggested change

"operationId": "Server_Restart",

"operationId": "Servers_Restart",

praries880 · 2019-02-22T17:48:22Z

...tion/postgresql/resource-manager/Microsoft.DBforPostgreSQL/stable/2017-12-01/postgresql.json

+        "tags": [
+          "ServerRestart"
+        ],
+        "operationId": "Server_Restart",


this “"operationId": "Server_Restart”,” should be “"operationId": "Servers_Restart”,”

Suggested change

"operationId": "Server_Restart",

"operationId": "Servers_Restart",

ravbhatnagar

just one minor note. Please add the default response.

ravbhatnagar · 2019-02-22T23:19:53Z

...tion/postgresql/resource-manager/Microsoft.DBforPostgreSQL/stable/2017-12-01/postgresql.json

        }
      }
    },
+    "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DBforPostgreSQL/servers/{serverName}/restart": {


"Default" response missing from all APIs. Please add. sample here - https://github.com/Azure/azure-rest-api-specs/blob/master/specification/batch/resource-manager/Microsoft.Batch/stable/2018-12-01/BatchManagement.json#L101

ravbhatnagar · 2019-02-23T01:33:33Z

Signing off from ARM side.

praries880 · 2019-02-25T21:00:00Z

@ravindrakreddy Build is breaking because the definition of #/definitions/CloudError can not be found. Can you validate that you are referencing the correct type and its in the path specified?

ravindrakreddy added 2 commits February 21, 2019 11:37

SDK for server restart

555097e

server restart changes2

ea3fd47

AutorestCI mentioned this pull request Feb 21, 2019

[AutoPR mysql/resource-manager/postgresql/resource-manager] Elastic Server Restart Azure/azure-sdk-for-python#4400

Merged

azuresdkci assigned praries880 Feb 21, 2019

azuresdkci requested a review from praries880 February 21, 2019 20:52

AutorestCI mentioned this pull request Feb 21, 2019

[AutoPR mysql/resource-manager/postgresql/resource-manager] Elastic Server Restart Azure/azure-sdk-for-node#4719

Closed

AutorestCI mentioned this pull request Feb 21, 2019

[AutoPR mysql/resource-manager/postgresql/resource-manager] Elastic Server Restart Azure/azure-sdk-for-go#4123

Merged

praries880 suggested changes Feb 22, 2019

View reviewed changes

praries880 added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Feb 22, 2019

server restart changes 3

f4a5bea

AutorestCI mentioned this pull request Feb 22, 2019

[AutoPR mysql/resource-manager/postgresql/resource-manager] Elastic Server Restart Azure/azure-sdk-for-node#4728

Closed

praries880 approved these changes Feb 22, 2019

View reviewed changes

ravbhatnagar reviewed Feb 22, 2019

View reviewed changes

ravbhatnagar added the ARMChangesRequested label Feb 22, 2019

server restart changes 4

517ef87

ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Feb 23, 2019

server restart changes 5

ff2dd2a

praries880 approved these changes Feb 26, 2019

View reviewed changes

praries880 merged commit f36c229 into Azure:master Feb 26, 2019

	"operationId": "Server_Restart",
	"operationId": "Servers_Restart",

Conversation

ravindrakreddy commented Feb 21, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Latest improvements:

Contribution checklist:

ARM API Review Checklist

Uh oh!

ravindrakreddy commented Feb 21, 2019

Uh oh!

AutorestCI commented Feb 21, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-ruby

Uh oh!

AutorestCI commented Feb 21, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-python

Uh oh!

AutorestCI commented Feb 21, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-js

Uh oh!

AutorestCI commented Feb 21, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-java

Uh oh!

AutorestCI commented Feb 21, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-node

Uh oh!

AutorestCI commented Feb 21, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-go

Uh oh!

azuresdkci commented Feb 21, 2019

Uh oh!

praries880 Feb 22, 2019

Choose a reason for hiding this comment

Uh oh!

ravindrakreddy Feb 22, 2019

Choose a reason for hiding this comment

Uh oh!

praries880 Feb 22, 2019

Choose a reason for hiding this comment

Uh oh!

ravindrakreddy Feb 22, 2019

Choose a reason for hiding this comment

Uh oh!

ravbhatnagar left a comment

Choose a reason for hiding this comment

Uh oh!

ravbhatnagar Feb 22, 2019

Choose a reason for hiding this comment

Uh oh!

ravindrakreddy Feb 23, 2019

Choose a reason for hiding this comment

Uh oh!

ravbhatnagar commented Feb 23, 2019

Uh oh!

praries880 commented Feb 25, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ravindrakreddy commented Feb 21, 2019 •

edited

Loading

AutorestCI commented Feb 21, 2019 •

edited

Loading

AutorestCI commented Feb 21, 2019 •

edited

Loading

AutorestCI commented Feb 21, 2019 •

edited

Loading

AutorestCI commented Feb 21, 2019 •

edited

Loading

AutorestCI commented Feb 21, 2019 •

edited

Loading

AutorestCI commented Feb 21, 2019 •

edited

Loading