EventGrid: Swagger Changes for 2019-02-01-preview by ahamad-MS · Pull Request #5242 · Azure/azure-rest-api-specs

ahamad-MS · 2019-02-21T06:51:23Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

AutorestCI · 2019-02-21T06:52:15Z

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#4430

AutorestCI · 2019-02-21T06:52:15Z

Automation for azure-sdk-for-js

Encountered an unknown error: (azure-sdk-for-js)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 309, in generate_sdk_from_git_object
    sdk_repo.git.push('origin', base_branch, set_upstream=True)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git push --set-upstream origin restapi_auto_eventgrid/resource-manager
  stderr: 'remote: Permission to Azure/azure-sdk-for-js.git denied to AutorestCI.
fatal: unable to access 'https://AutorestCI:58ab395c311d1bd75b3e1db1cc8adaf9acc42afe@github.com/Azure/azure-sdk-for-js.git/': The requested URL returned error: 403'

AutorestCI · 2019-02-21T06:52:41Z

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#4758

AutorestCI · 2019-02-21T06:52:54Z

Automation for azure-sdk-for-ruby

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-ruby#2135

AutorestCI · 2019-02-21T06:53:13Z

Automation for azure-sdk-for-java

Encountered an unknown error: (azure-sdk-for-java)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 309, in generate_sdk_from_git_object
    sdk_repo.git.push('origin', base_branch, set_upstream=True)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git push --set-upstream origin restapi_auto_eventgrid/resource-manager
  stderr: 'remote: Permission to Azure/azure-sdk-for-java.git denied to AutorestCI.
fatal: unable to access 'https://AutorestCI:58ab395c311d1bd75b3e1db1cc8adaf9acc42afe@github.com/Azure/azure-sdk-for-java.git/': The requested URL returned error: 403'

AutorestCI · 2019-02-21T06:53:52Z

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

azuresdkci · 2019-02-21T07:04:38Z

Can one of the admins verify this patch?

…example files

…sting example files

sarangan12

Please fix the errors reported at https://travis-ci.org/Azure/azure-rest-api-specs/jobs/496371647

...ion/eventgrid/resource-manager/Microsoft.EventGrid/preview/2019-02-01-preview/EventGrid.json

kalyanaj · 2019-02-22T17:46:45Z

...ion/eventgrid/resource-manager/Microsoft.EventGrid/preview/2019-02-01-preview/EventGrid.json

                    "description": "The event delivery schema for the event subscription.",
                    "enum": [
                        "EventGridSchema",
+                        "InputEventSchema",


Please remove this value (as this is deprecated and has been replaced by CustomInputSchema.)

kalyanaj · 2019-02-22T17:47:48Z

...ion/eventgrid/resource-manager/Microsoft.EventGrid/preview/2019-02-01-preview/EventGrid.json

                    "description": "The event delivery schema for the event subscription.",
                    "enum": [
                        "EventGridSchema",
+                        "InputEventSchema",


Please remove this value.

kalyanaj · 2019-02-22T17:47:58Z

...ion/eventgrid/resource-manager/Microsoft.EventGrid/preview/2019-02-01-preview/EventGrid.json

                        "EventGridSchema",
+                        "InputEventSchema",
                        "CloudEventV01Schema",
+                        "GraphApiEventSchema",


Please remove this value.

kalyanaj · 2019-02-22T17:48:50Z

...ion/eventgrid/resource-manager/Microsoft.EventGrid/preview/2019-02-01-preview/EventGrid.json

                    "type": "string"
+                },
+                "isInDefaultSet": {
+                    "description": "IsInDefaultSet flag of the event type.",


Nit: Would be good to have a better description for this one.

kalyanaj · 2019-02-22T17:49:53Z

...ion/eventgrid/resource-manager/Microsoft.EventGrid/preview/2019-02-01-preview/EventGrid.json

                        "modelAsString": true
-                    },
-                    "default": "EventGridSchema"
+                    }


Would want to retain the "default": "EventGridSchema" that we have in the previous API version.

ahamad-MS · 2019-02-23T08:01:07Z

@sarangan12 Thx . Issue fixed and all tests are passing now.

@kalyanaj Thx. all comments are taken care of.

kalyanaj · 2019-02-24T03:09:36Z

...ion/eventgrid/resource-manager/Microsoft.EventGrid/preview/2019-02-01-preview/EventGrid.json

+                        "$ref": "#/parameters/SubscriptionIdParameter"
+                    },
+                    {
+                        "name": "$filter",


Please consider defining both these new parameters as global parameters (similar to other global parameters defined in the parameters section at the end of this swagger), this will avoid repeating the definition of these values in each list operation and will help the maintainability/future updates.

Updated. thx for the suggestion

sarangan12

The new version files are not reference in the readme file. As a result, none of the tooling is run on the new files. Please add reference to the json files in the readme file and update the PR

Ashraf Hamad added 3 commits January 8, 2019 14:18

Add tag: package-2019-01 to ruby and go readme files

93ccf22

Merge remote-tracking branch 'upstream/master'

8845e84

Copy 2018-09-15-preview files to get a baseline

9b82520

azuresdkci assigned sarangan12 Feb 21, 2019

azuresdkci requested a review from sarangan12 February 21, 2019 06:52

AutorestCI mentioned this pull request Feb 21, 2019

[AutoPR eventgrid/resource-manager] EventGrid: Swagger Changes for 2019-02-01-preview Azure/azure-sdk-for-python#4397

Merged

AutorestCI mentioned this pull request Feb 21, 2019

[AutoPR eventgrid/resource-manager] EventGrid: Swagger Changes for 2019-02-01-preview Azure/azure-sdk-for-ruby#2254

Merged

Ashraf Hamad added 2 commits February 20, 2019 23:19

Add EventGrid swagger file along with the domain topic create/delete …

117d905

…example files

Replace 2018-09-15-preview with 2019-02-01-preview api version in exi…

99549fb

…sting example files

sarangan12 suggested changes Feb 22, 2019

View reviewed changes

kalyanaj reviewed Feb 22, 2019

View reviewed changes

...ion/eventgrid/resource-manager/Microsoft.EventGrid/preview/2019-02-01-preview/EventGrid.json Outdated Show resolved Hide resolved

kalyanaj reviewed Feb 22, 2019

View reviewed changes

Address CR comments and fix test

058f5d6

kalyanaj reviewed Feb 24, 2019

View reviewed changes

Take care of CR comment

2350317

sarangan12 suggested changes Feb 25, 2019

View reviewed changes

update readme.md file and address some violations

46cf5eb

AutorestCI mentioned this pull request Feb 26, 2019

[AutoPR eventgrid/resource-manager] EventGrid: Swagger Changes for 2019-02-01-preview Azure/azure-sdk-for-node#4754

Merged

Ashraf Hamad added 3 commits February 25, 2019 19:39

Add 2019-01 and 2019-02-preview APIs to Java multi-api in readme.md file

5193a7c

update summary text per code review comments

a24d800

Address CR comments

c681e1b

sarangan12 approved these changes Feb 26, 2019

View reviewed changes

sarangan12 merged commit c2cf218 into Azure:master Feb 26, 2019

Comments

Conversation

ahamad-MS commented Feb 21, 2019

Latest improvements:

Contribution checklist:

ARM API Review Checklist

Uh oh!

AutorestCI commented Feb 21, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-python

Uh oh!

AutorestCI commented Feb 21, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-js

Uh oh!

AutorestCI commented Feb 21, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-node

Uh oh!

AutorestCI commented Feb 21, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-ruby

Uh oh!

AutorestCI commented Feb 21, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-java

Uh oh!

AutorestCI commented Feb 21, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-go

Uh oh!

azuresdkci commented Feb 21, 2019

Uh oh!

sarangan12 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ahamad-MS commented Feb 23, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sarangan12 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

AutorestCI commented Feb 21, 2019 •

edited

Loading

AutorestCI commented Feb 21, 2019 •

edited

Loading

AutorestCI commented Feb 21, 2019 •

edited

Loading

AutorestCI commented Feb 21, 2019 •

edited

Loading

AutorestCI commented Feb 21, 2019 •

edited

Loading

AutorestCI commented Feb 21, 2019 •

edited

Loading