Add Custom Vision 3.0 API by areddish · Pull Request #5164 · Azure/azure-rest-api-specs

areddish · 2019-02-06T23:25:57Z

Add the 3.0 Versions of Prediction and Training APIs for Custom Vision Cognitive Services

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

AutorestCI · 2019-02-06T23:26:34Z

Automation for azure-sdk-for-ruby

A PR has been created for you:
Azure/azure-sdk-for-ruby#2353

AutorestCI · 2019-02-06T23:26:42Z

Automation for azure-sdk-for-js

A PR has been created for you:
Azure/azure-sdk-for-js#1702

AutorestCI · 2019-02-06T23:26:53Z

Automation for azure-sdk-for-python

A PR has been created for you:
Azure/azure-sdk-for-python#4321

AutorestCI · 2019-02-06T23:27:46Z

Automation for azure-sdk-for-node

A PR has been created for you:
Azure/azure-sdk-for-node#5016

AutorestCI · 2019-02-06T23:27:52Z

Automation for azure-sdk-for-java

A PR has been created for you:
Azure/azure-sdk-for-java#3007

AutorestCI · 2019-02-06T23:29:26Z

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

azuresdkci · 2019-02-07T00:04:55Z

Can one of the admins verify this patch?

yangyuan

Hi Andrew, have you reviews the 3.0 API with Azure API Review Board Core?

...cation/cognitiveservices/data-plane/CustomVision/Prediction/stable/v3.0/Prediction.json.orig

specification/cognitiveservices/data-plane/CustomVision/Prediction/stable/v3.0/Prediction.json

specification/cognitiveservices/data-plane/CustomVision/Training/stable/v3.0/Training.json

veronicagg

@areddish thanks for the PR, generally looks good to me. Please let me know when you get approval from the API Review board, so we know we're good on that.
Have these APIs been deployed already?
For SDK code generation, could you update the readme.md files for each of the languages as well? Thanks!

veronicagg · 2019-02-26T19:31:05Z

@areddish will you be making more updates to this PR?

shahabhijeet · 2019-03-14T22:56:05Z

startbuild

dsgouda · 2019-03-18T18:44:07Z

Rest spec to Net Sdk automation cannot handle multiple RPs today, please do not block on Automation for azure-sdk-for-net failures for this review

specification/cognitiveservices/data-plane/CustomVision/Training/stable/v3.0/Training.json

veronicagg · 2019-03-21T18:48:55Z

@shahabhijeet could you take a look and see why .Net SDK generation is failing? Thanks!

veronicagg · 2019-03-21T18:50:00Z

ok, I just see a comment from @dsgouda indicating a non supported scenario for .Net SDK, so I'll ignore for this PR.

veronicagg

couple more comments inline. thanks!

specification/cognitiveservices/data-plane/CustomVision/Prediction/readme.md

specification/cognitiveservices/data-plane/CustomVision/Training/readme.md

areddish requested a review from yangyuan as a code owner February 6, 2019 23:25

azuresdkci assigned veronicagg Feb 6, 2019

azuresdkci requested a review from veronicagg February 6, 2019 23:27

AutorestCI mentioned this pull request Feb 6, 2019

[AutoPR cognitiveservices/data-plane/CustomVision/Training/cognitiveservices/data-plane/CustomVision/Prediction] Add Custom Vision 3.0 API Azure/azure-sdk-for-node#4646

Closed

AutorestCI mentioned this pull request Feb 6, 2019

[AutoPR cognitiveservices/data-plane/CustomVision/Prediction/cognitiveservices/data-plane/CustomVision/Training] Add Custom Vision 3.0 API Azure/azure-sdk-for-java#2921

Closed

areddish force-pushed the cv-add-3.0 branch from 3f8ceeb to 741214d Compare February 6, 2019 23:44

veronicagg requested a review from kpajdzik February 6, 2019 23:52

yangyuan reviewed Feb 7, 2019

View reviewed changes

...cation/cognitiveservices/data-plane/CustomVision/Prediction/stable/v3.0/Prediction.json.orig Outdated Show resolved Hide resolved

Base commit to diff new version vs old version

2607541

areddish force-pushed the cv-add-3.0 branch from 741214d to 77c7101 Compare February 7, 2019 06:21

nschonni reviewed Feb 7, 2019

View reviewed changes

specification/cognitiveservices/data-plane/CustomVision/Prediction/stable/v3.0/Prediction.json Outdated Show resolved Hide resolved

specification/cognitiveservices/data-plane/CustomVision/Training/stable/v3.0/Training.json Outdated Show resolved Hide resolved

veronicagg suggested changes Feb 8, 2019

View reviewed changes

kpajdzik approved these changes Feb 9, 2019

View reviewed changes

areddish force-pushed the cv-add-3.0 branch from 77c7101 to 42bbb96 Compare February 19, 2019 23:15

AutorestCI mentioned this pull request Feb 19, 2019

[AutoPR cognitiveservices/data-plane/CustomVision/Prediction/cognitiveservices/data-plane/CustomVision/Training] Add Custom Vision 3.0 API Azure/azure-sdk-for-js#1292

Closed

AutorestCI mentioned this pull request Feb 27, 2019

[AutoPR cognitiveservices/data-plane/CustomVision/Training/cognitiveservices/data-plane/CustomVision/Prediction] Add Custom Vision 3.0 API Azure/azure-sdk-for-node#4776

Closed

areddish added 4 commits March 4, 2019 06:27

Add 3.0 version of swagger for Training and Prediction

d148b66

Add examples for v3.0

903795d

Update release to 3.0

41587bf

Update Training API

364b4c3

areddish force-pushed the cv-add-3.0 branch from 28061f5 to 47d990e Compare March 12, 2019 20:47

Update examples

36a2209

areddish mentioned this pull request Mar 15, 2019

Custom vision 3.0 Azure/azure-sdk-for-net#5470

Merged

johanste reviewed Mar 19, 2019

View reviewed changes

specification/cognitiveservices/data-plane/CustomVision/Training/stable/v3.0/Training.json Outdated Show resolved Hide resolved

remove nullable

659b105

Add missing field

5adc21c

areddish added 2 commits March 20, 2019 06:58

Update HttpDelete operation to be consistent.

79d1c5e

Add missing error.

88b8b15

veronicagg suggested changes Mar 21, 2019

View reviewed changes

specification/cognitiveservices/data-plane/CustomVision/Prediction/readme.md Show resolved Hide resolved

specification/cognitiveservices/data-plane/CustomVision/Training/readme.md Show resolved Hide resolved

Add ruby swagger-to-sdk parts

76fe991

Update ruby.md

9ae6d3f

AutorestCI mentioned this pull request Mar 21, 2019

[AutoPR cognitiveservices/data-plane/CustomVision/Prediction/cognitiveservices/data-plane/CustomVision/Training] Add Custom Vision 3.0 API Azure/azure-sdk-for-ruby#2353

Closed

veronicagg approved these changes Mar 21, 2019

View reviewed changes

veronicagg merged commit 23d6a7c into Azure:master Mar 21, 2019

veronicagg mentioned this pull request Mar 21, 2019

api spec for speech #5445

Closed

5 tasks

joshfree mentioned this pull request Sep 13, 2019

Regenerate custom vision prediction & training Azure/azure-sdk-for-java#5369

Merged

Comments

Conversation

areddish commented Feb 6, 2019

Contribution checklist:

ARM API Review Checklist

Uh oh!

AutorestCI commented Feb 6, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-ruby

Uh oh!

AutorestCI commented Feb 6, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-js

Uh oh!

AutorestCI commented Feb 6, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-python

Uh oh!

AutorestCI commented Feb 6, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-node

Uh oh!

AutorestCI commented Feb 6, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-java

Uh oh!

AutorestCI commented Feb 6, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-go

Uh oh!

azuresdkci commented Feb 7, 2019

Uh oh!

yangyuan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

veronicagg left a comment

Choose a reason for hiding this comment

Uh oh!

veronicagg commented Feb 26, 2019

Uh oh!

shahabhijeet commented Mar 14, 2019

Uh oh!

dsgouda commented Mar 18, 2019

Uh oh!

Uh oh!

veronicagg commented Mar 21, 2019

Uh oh!

veronicagg commented Mar 21, 2019

Uh oh!

veronicagg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

AutorestCI commented Feb 6, 2019 •

edited

Loading

AutorestCI commented Feb 6, 2019 •

edited

Loading

AutorestCI commented Feb 6, 2019 •

edited

Loading

AutorestCI commented Feb 6, 2019 •

edited

Loading

AutorestCI commented Feb 6, 2019 •

edited

Loading

AutorestCI commented Feb 6, 2019 •

edited

Loading