Updated managed instance swagger and examples#5138
Conversation
Adding two new ManagedInstance properties
*Update of ProxyOverride property for Managed Instance *Update of examples
Automation for azure-sdk-for-rubyA PR has been created for you based on this PR content. Once this PR will be merged, content will be added to your service PR: |
Automation for azure-sdk-for-pythonThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-jsA PR has been created for you based on this PR content. Once this PR will be merged, content will be added to your service PR: |
Automation for azure-sdk-for-goThe initial PR has been merged into your service PR: |
|
Can one of the admins verify this patch? |
| "state": "Ready", | ||
| "collation": "SQL_Latin1_General_CP1_CI_AS", | ||
| "dnsZone": "1b4e2caff2530" | ||
| "dnsZone": "1b4e2caff2530", |
There was a problem hiding this comment.
Is publicDataEndpointEnabled intentionally not there in the response?
There was a problem hiding this comment.
Yes, it's by design.
There was a problem hiding this comment.
I talked with Mladen who was implementing this feature. He actually forgot to include it here. It should be in response. I'll update it and he'll make sure to update his part.
There was a problem hiding this comment.
Is proxyOverride intentionally missing?
There was a problem hiding this comment.
Updated. It should be empty string because this instance is created before this property is introduced and the value for this property is null as I have already explained.
There was a problem hiding this comment.
Nit: please fix indentation
Automation for azure-sdk-for-javaEncountered an unknown error: (azure-sdk-for-java)
Traceback (most recent call last):
File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
yield context
File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
sdk_tag=sdk_tag
File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 309, in generate_sdk_from_git_object
sdk_repo.git.push('origin', base_branch, set_upstream=True)
File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
return self.execute(call, **exec_kwargs)
File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
cmdline: git push --set-upstream origin restapi_auto_sql/resource-manager
stderr: 'remote: Permission to Azure/azure-sdk-for-java.git denied to AutorestCI.
fatal: unable to access 'https://AutorestCI:58ab395c311d1bd75b3e1db1cc8adaf9acc42afe@github.com/Azure/azure-sdk-for-java.git/': The requested URL returned error: 403' |
Automation for azure-sdk-for-nodeA PR has been created for you based on this PR content. Once this PR will be merged, content will be added to your service PR: |
veronicagg
requested review from
anuchandy
and removed request for
veronicagg
|
@anuchandy giving you this PR as I took your other one (just a swap) thanks! |
Fixed indentation.
|
@stefanb995 please fix conflicts in managedInstances.json. |
There was a problem hiding this comment.
Don't think the boolean value should be quoted
There was a problem hiding this comment.
Thanks. I fixed it.
Added proxyOverride in response for testcl2 managedInstance.
…ger' of https://github.com/stefanb995/azure-rest-api-specs into Add-publicDataEndpointEnabled-and-proxyOverride-to-swagger
anuchandy
left a comment
anuchandy
left a comment
There was a problem hiding this comment.
@stefanb995 could you fix the conflict in managedInstances.json
Fixed indentation
|
Fixed. |
|
Can you please approve this. I need it merged to regenerate SDK from master branch. |
|
@stefanb995 it seems there are still conflicts in managedInstances.json? |
|
My bad. It should be fixed now. |
7 participants
*Updated ProxyOverride property in swagger file with enum
*Updated examples with ProxyOverride and PublicDataEndpointEnabled
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.