Skip to content

3 new APIs added to SignalR service and rename the sample files #5091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
anuchandy merged 3 commits into from
Mar 22, 2019
Merged

3 new APIs added to SignalR service and rename the sample files #5091

anuchandy merged 3 commits into from
Mar 22, 2019

Conversation

@juniwang
Copy link
Member

@juniwang juniwang commented Jan 25, 2019 •
edited
Loading

Latest improvements:

  • We add a new API to Restart to restart a SignalR resource
    The APIs are already available in RP and can be invoked on azure portal. Now we need to enable customer to do it via SDKs/cli/powershell.
  • We also renamed existing sample files. Since we find the former names are easy to conflict. Now we use OperationId which is unique through SignalR service.
  • Suppress several warnings. See the details in the md file.

Tests performed

Tests documented at https://github.com/Azure/adx-documentation-pr/wiki/Azure-Swagger-Tools passed.

@openapi-portal-comment
Copy link

openapi-portal-comment bot commented Jan 25, 2019

If you're a MSFT employee, click this link
to view this PR's validation status on our new OpenAPI Hub spec management tool.

@AutorestCI AutorestCI mentioned this pull request Jan 25, 2019
Closed
@AutorestCI
Copy link

AutorestCI commented Jan 25, 2019 •
edited
Loading

Automation for azure-sdk-for-js

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-js#1735

@AutorestCI AutorestCI mentioned this pull request Jan 25, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Jan 25, 2019 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#3706

@azuresdkci azuresdkci requested a review from anuchandy January 25, 2019 03:21
@AutorestCI AutorestCI mentioned this pull request Jan 25, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Jan 25, 2019 •
edited
Loading

Automation for azure-sdk-for-ruby

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-ruby#2354

@AutorestCI AutorestCI mentioned this pull request Jan 25, 2019
Closed
@AutorestCI
Copy link

AutorestCI commented Jan 25, 2019 •
edited
Loading

Automation for azure-sdk-for-node

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-node#5028

@AutorestCI
Copy link

AutorestCI commented Jan 25, 2019 •
edited
Loading

Automation for azure-sdk-for-java

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-java#3177

This was referenced Jan 25, 2019
Closed
Closed
@AutorestCI
Copy link

AutorestCI commented Jan 25, 2019 •
edited
Loading

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@azuresdkci
Copy link
Contributor

azuresdkci commented Jan 25, 2019

Can one of the admins verify this patch?

@anuchandy anuchandy added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Feb 2, 2019
@juniwang
Copy link
Member Author

juniwang commented Feb 12, 2019

Can one of the ARM admins verify this patch? thanks a lot

@juniwang
Copy link
Member Author

juniwang commented Feb 21, 2019

@KrisBash @ravbhatnagar Hi, could you please review the PR? thanks

ravbhatnagar
ravbhatnagar suggested changes Feb 21, 2019
View reviewed changes
Copy link
Contributor

@ravbhatnagar ravbhatnagar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets have a chat about the features/switchFeatures API. I dont think i have full context.

@AutorestCI AutorestCI mentioned this pull request Feb 26, 2019
Closed
@juniwang
Copy link
Member Author

juniwang commented Feb 26, 2019

@ravbhatnagar Please review again

@KrisBash KrisBash added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested labels Feb 28, 2019
@KrisBash KrisBash removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Feb 28, 2019
KrisBash
KrisBash approved these changes Feb 28, 2019
View reviewed changes
Copy link
Contributor

@KrisBash KrisBash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ARM changes appear to be addressed. Thanks!

@juniwang
Copy link
Member Author

juniwang commented Mar 7, 2019

Thanks Kris. @ravbhatnagar Could you please review again?

@juniwang
Copy link
Member Author

juniwang commented Mar 19, 2019

Can one of the admin merge this? We are approaching our SLA to expose the new API. Thanks a lot.

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request Mar 19, 2019
@adxsdknet
.NET SDK Resource Provider:'SignalR'
c28dbf5 
REST Spec PR 'Azure/azure-rest-api-specs#5091'
REST Spec PR Author 'juniwang'
REST Spec PR Last commit
@adxsdknet
Copy link

adxsdknet commented Mar 19, 2019

Automation for azure-sdk-for-net

A PR has been created for you:
Azure/azure-sdk-for-net#5505
.NET SDK Commits:
adxsdknet/azure-sdk-for-net@c28dbf5

@anuchandy
Copy link
Member

anuchandy commented Mar 21, 2019

@juniwang just requested @ravbhatnagar's sign-off, which is required to merge this.

@ravbhatnagar
Copy link
Contributor

ravbhatnagar commented Mar 21, 2019

Signing off from ARM side.

@anuchandy
Copy link
Member

anuchandy commented Mar 21, 2019

@ravbhatnagar Coud you go to "File Changes -> Review Changes -> Approve" then approve it please? since you requested changes in the past, it won't let me merge without your explicit approval (merge button is disabled for me)

@anuchandy anuchandy merged commit ae3f529 into Azure:master Mar 22, 2019
This was referenced Mar 22, 2019
Merged
Merged
Merged
@juniwang
Copy link
Member Author

juniwang commented Mar 22, 2019

Thanks a lot, guys

@jhendrixMSFT
Copy link
Member

jhendrixMSFT commented Mar 29, 2019

@AutorestCI regenerate azure-sdk-for-go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anuchandy anuchandy anuchandy approved these changes

+2 more reviewers

@ravbhatnagar ravbhatnagar ravbhatnagar approved these changes

@KrisBash KrisBash KrisBash approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@anuchandy anuchandy

Labels

ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@juniwang @AutorestCI @azuresdkci @adxsdknet @anuchandy @ravbhatnagar @jhendrixMSFT @KrisBash