Update swagger to add target and credentials flag to the requests, and add examples. by shahzzzam · Pull Request #5047 · Azure/azure-rest-api-specs

shahzzzam · 2019-01-16T20:05:04Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

…specs

openapi-portal-comment · 2019-01-16T20:05:06Z

If you're a MSFT employee, click this link
to view this PR's validation status on our new OpenAPI Hub spec management tool.

AutorestCI · 2019-01-16T20:05:56Z

Automation for azure-sdk-for-js

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-js#948

AutorestCI · 2019-01-16T20:06:12Z

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#4206

AutorestCI · 2019-01-16T20:06:32Z

Automation for azure-sdk-for-ruby

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-ruby#2164

azuresdkci · 2019-01-16T20:08:00Z

Can one of the admins verify this patch?

jhendrixMSFT

Can you please fix the indentation so it matches the original? The diff is extremely noisy.

AutorestCI · 2019-01-16T20:41:42Z

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#4566

AutorestCI · 2019-01-16T20:49:39Z

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#2460

shahzzzam · 2019-01-16T21:15:44Z

Can you please fix the indentation so it matches the original? The diff is extremely noisy.

Yes, I am working on that

AutorestCI · 2019-01-16T22:34:56Z

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#3904

.../resource-manager/Microsoft.ContainerRegistry/stable/2018-09-01/containerregistry_build.json

shahzzzam · 2019-01-16T22:50:49Z

Can you please fix the indentation so it matches the original? The diff is extremely noisy.

This has been fixed

openapi-portal-comment · 2019-01-16T22:50:58Z

If you're a MSFT employee, click this link
to view this PR's validation status on our new OpenAPI Hub spec management tool.

shahzzzam · 2019-01-16T23:02:13Z

Can you please fix the indentation so it matches the original? The diff is extremely noisy.

This is fixed, @jhendrixMSFT

.../resource-manager/Microsoft.ContainerRegistry/stable/2018-09-01/containerregistry_build.json

shahzzzam · 2019-01-17T23:46:47Z

@jhendrixMSFT it seems I cannot resolve one of your reviews about indentation. Can you resolve it on your end? Seems like all the comments were addressed

jhendrixMSFT · 2019-01-17T23:49:28Z

@shahzzzam no worries it looks good. Are these features live in production?

shahzzzam · 2019-01-17T23:49:57Z

@jhendrixMSFT Yes they are, just need to add them to CLI now

…d add examples. (Azure#5047) * Add target and credential flags to the Request * Add target and credential flags to the Request * Add two examples for CustomCredentials as well as target * fix indentation * fix spelling mistakes * vaule to value * update status code order * remove gets or sets from description

shahzzzam added 8 commits January 15, 2019 17:58

Add target and credential flags to the Request

8089a2e

Add target and credential flags to the Request

7db54c5

Merge branch 'master' of https://github.com/shahzzzam/azure-rest-api-…

39d335b

…specs

Merge branch 'master' of https://github.com/shahzzzam/azure-rest-api-…

da24bcf

…specs

fix indent

436fc21

fix indent

da820a1

Merge branch 'master' of https://github.com/shahzzzam/azure-rest-api-…

afcad13

…specs

Add two examples for CustomCredentials as well as target

5841d45

AutorestCI mentioned this pull request Jan 16, 2019

[AutoPR containerregistry/resource-manager] Add target and credentials flag to the requests. Azure/azure-sdk-for-js#939

Merged

shahzzzam changed the title ~~Add target and credentials flag to the requests.~~ Update swagger to add target and credentials flag to the requests, and add examples. Jan 16, 2019

AutorestCI mentioned this pull request Jan 16, 2019

[AutoPR containerregistry/resource-manager] Add target and credentials flag to the requests. Azure/azure-sdk-for-python#4196

Merged

azuresdkci assigned jhendrixMSFT Jan 16, 2019

azuresdkci requested a review from jhendrixMSFT January 16, 2019 20:06

AutorestCI mentioned this pull request Jan 16, 2019

[AutoPR containerregistry/resource-manager] Add target and credentials flag to the requests. Azure/azure-sdk-for-ruby#2153

Merged

jhendrixMSFT requested changes Jan 16, 2019

View reviewed changes

AutorestCI mentioned this pull request Jan 16, 2019

[AutoPR containerregistry/resource-manager] Update swagger to add target and credentials flag to the requests, and add examples. Azure/azure-sdk-for-node#4557

Closed

AutorestCI mentioned this pull request Jan 16, 2019

[AutoPR containerregistry/resource-manager] Update swagger to add target and credentials flag to the requests, and add examples. Azure/azure-sdk-for-java#2850

Merged

fix indentation

eee2b8e

AutorestCI mentioned this pull request Jan 16, 2019

[AutoPR containerregistry/resource-manager] Update swagger to add target and credentials flag to the requests, and add examples. Azure/azure-sdk-for-go#3893

Closed

fix spelling mistakes

545fd2f

nschonni reviewed Jan 16, 2019

View reviewed changes

.../resource-manager/Microsoft.ContainerRegistry/stable/2018-09-01/containerregistry_build.json Outdated Show resolved Hide resolved

shahzzzam closed this Jan 16, 2019

shahzzzam reopened this Jan 16, 2019

vaule to value

4020808

nschonni reviewed Jan 17, 2019

View reviewed changes

update status code order

7bcfc09

jhendrixMSFT reviewed Jan 17, 2019

View reviewed changes

.../resource-manager/Microsoft.ContainerRegistry/stable/2018-09-01/containerregistry_build.json Outdated Show resolved Hide resolved

remove gets or sets from description

e8f1043

jhendrixMSFT approved these changes Jan 17, 2019

View reviewed changes

jhendrixMSFT merged commit 2149912 into Azure:master Jan 17, 2019

Conversation

shahzzzam commented Jan 16, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Latest improvements:

Contribution checklist:

ARM API Review Checklist

Uh oh!

openapi-portal-comment bot commented Jan 16, 2019

Uh oh!

AutorestCI commented Jan 16, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-js

Uh oh!

AutorestCI commented Jan 16, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-python

Uh oh!

AutorestCI commented Jan 16, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-ruby

Uh oh!

azuresdkci commented Jan 16, 2019

Uh oh!

jhendrixMSFT left a comment

Choose a reason for hiding this comment

Uh oh!

AutorestCI commented Jan 16, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-node

Uh oh!

AutorestCI commented Jan 16, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-java

Uh oh!

shahzzzam commented Jan 16, 2019

Uh oh!

AutorestCI commented Jan 16, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-go

Uh oh!

Uh oh!

shahzzzam commented Jan 16, 2019

Uh oh!

openapi-portal-comment bot commented Jan 16, 2019

Uh oh!

shahzzzam commented Jan 16, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

shahzzzam commented Jan 17, 2019

Uh oh!

jhendrixMSFT commented Jan 17, 2019

Uh oh!

shahzzzam commented Jan 17, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

shahzzzam commented Jan 16, 2019 •

edited

Loading

AutorestCI commented Jan 16, 2019 •

edited

Loading

AutorestCI commented Jan 16, 2019 •

edited

Loading

AutorestCI commented Jan 16, 2019 •

edited

Loading

AutorestCI commented Jan 16, 2019 •

edited

Loading

AutorestCI commented Jan 16, 2019 •

edited

Loading

AutorestCI commented Jan 16, 2019 •

edited

Loading

shahzzzam commented Jan 17, 2019 •

edited

Loading