Skip to content

[DataFactory]Support schema property for dataset #5019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sarangan12 merged 1 commit into from
Jan 15, 2019
Merged

[DataFactory]Support schema property for dataset #5019

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions ...factory/resource-manager/Microsoft.DataFactory/stable/2018-06-01/entityTypes/Dataset.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,10 @@
"type": "object",
"description": "Columns that define the structure of the dataset. Type: array (or Expression with resultType array), itemType: DatasetDataElement."
},
"schema": {
Copy link
Contributor

@sarangan12 sarangan12 Jan 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this added newly to this version? Or was it there from the beginning but failed to be added in the swagger?

Copy link
Contributor Author

@jackmagic313 jackmagic313 Jan 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was newly added.

"type": "object",
"description": "Columns that define the physical type schema of the dataset. Type: array (or Expression with resultType array), itemType: DatasetSchemaDataElement."
},
"linkedServiceName": {
"description": "Linked service reference.",
"$ref": "../datafactory.json#/definitions/LinkedServiceReference"
Expand Down Expand Up @@ -71,6 +75,23 @@
}
}
},
"DatasetSchemaDataElement": {
Copy link
Contributor

@sarangan12 sarangan12 Jan 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is this model referenced?

Copy link
Contributor Author

@jackmagic313 jackmagic313 Jan 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will be used for the newly added property "schema". Though we can't just refer "DatasetSchemaDataElement" there due to the "schema" property can take other types (i.e. string, expression object...) which eventually will convert to DatasetSchemaDataElement. This property actually just follows the same usage as "DatasetDataElement"

"description": "Columns that define the physical type schema of the dataset.",
"type": "object",
"properties": {
"name": {
"type": "object",
"description": "Name of the schema column. Type: string (or Expression with resultType string)."
},
"type": {
"type": "object",
"description": "Type of the schema column. Type: string (or Expression with resultType string)."
}
},
"additionalProperties": {
"type": "object"
}
},
"DatasetStorageFormat": {
"discriminator": "type",
"description": "The format definition of a storage.",
Expand Down
12 changes: 12 additions & 0 deletions ...ry/resource-manager/Microsoft.DataFactory/stable/2018-06-01/examples/Datasets_Create.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,18 @@
"type": "Microsoft.DataFactory/factories/datasets",
"properties": {
"type": "AzureBlob",
"schema": [
{
"name": "col1",
"type": "INT_32"
},
{
"name": "col2",
"type": "Decimal",
"precision": "38",
"scale": "2"
}
],
"typeProperties": {
"folderPath": {
"value": "@dataset().MyFolderPath",
Expand Down