Skip to content

[AKS] fix example validation errors for new endpoints#5015

Merged
praries880 merged 1 commit intoAzure:masterfrom
mboersma:aks-fix-validation
Jan 10, 2019
Merged

[AKS] fix example validation errors for new endpoints#5015
praries880 merged 1 commit intoAzure:masterfrom
mboersma:aks-fix-validation

Conversation

@mboersma
Copy link
Copy Markdown
Member

Fixes the remaining oav validate-example errors in the new stable and preview endpoints for AKS.

@zqingqing1 can you check that these changes are correct? I validated we see no warnings now with these commands:

$ cd $HOME/Projects/azure-rest-api-specs/specification/containerservices/resource-manager/Microsoft.ContainerService
$ find . -not -path "*examples/*" -not -path "*/location.json" -name "*.json" -exec oav validate-example -l warn {} \;
$ find . -not -path "*examples/*" -not -path "*/location.json" -name "*.json" -exec oav validate-spec -l warn {} \;

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-portal-comment
Copy link
Copy Markdown

If you're a MSFT employee, click this link
to view this PR's validation status on our new OpenAPI Hub spec management tool.

@azuresdkci
Copy link
Copy Markdown
Contributor

Can one of the admins verify this patch?

@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Jan 10, 2019

Automation for azure-sdk-for-js

Nothing to generate for azure-sdk-for-js

@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Jan 10, 2019

Automation for azure-sdk-for-python

Nothing to generate for azure-sdk-for-python

@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Jan 10, 2019

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Jan 10, 2019

Automation for azure-sdk-for-node

Nothing to generate for azure-sdk-for-node

@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Jan 10, 2019

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Jan 10, 2019

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@zqingqing1
Copy link
Copy Markdown
Member

lgtm

@praries880 praries880 merged commit 73bb3a2 into Azure:master Jan 10, 2019
@mboersma mboersma deleted the aks-fix-validation branch January 10, 2019 20:56
TalluriAnusha pushed a commit to AsrOneSdk/azure-rest-api-specs that referenced this pull request Feb 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants