Skip to content

OpenAPIv3 support documented #5000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dsgouda merged 2 commits into from
Jan 9, 2019
Merged

OpenAPIv3 support documented #5000

dsgouda merged 2 commits into from
Jan 9, 2019

Conversation

@VitaliyKurokhtin
Copy link
Contributor

@VitaliyKurokhtin VitaliyKurokhtin commented Jan 8, 2019 •
edited
Loading

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-portal-comment
Copy link

openapi-portal-comment bot commented Jan 8, 2019

If you're a MSFT employee, click this link
to view this PR's validation status on our new OpenAPI Hub spec management tool.

@azuresdkci
Copy link
Contributor

azuresdkci commented Jan 8, 2019

Can one of the admins verify this patch?

@azuresdkci azuresdkci requested a review from dsgouda January 8, 2019 02:43
@AutorestCI
Copy link

AutorestCI commented Jan 8, 2019 •
edited
Loading

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@AutorestCI
Copy link

AutorestCI commented Jan 8, 2019 •
edited
Loading

Automation for azure-sdk-for-python

Nothing to generate for azure-sdk-for-python

@AutorestCI AutorestCI mentioned this pull request Jan 8, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Jan 8, 2019 •
edited
Loading

Automation for azure-sdk-for-ruby

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-ruby#2134

@AutorestCI AutorestCI mentioned this pull request Jan 8, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Jan 8, 2019 •
edited
Loading

Automation for azure-sdk-for-js

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-js#545

@AutorestCI
Copy link

AutorestCI commented Jan 8, 2019 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#3840

@AutorestCI AutorestCI mentioned this pull request Jan 8, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Jan 8, 2019 •
edited
Loading

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#4152

@dsgouda
Copy link
Contributor

dsgouda commented Jan 8, 2019

@jhendrixMSFT could you take a look at the Go generation failures?

@jhendrixMSFT
Copy link
Member

jhendrixMSFT commented Jan 8, 2019

@dsgouda it's a transient build error, failed to fetch some sources.

@jhendrixMSFT
Copy link
Member

jhendrixMSFT commented Jan 8, 2019

@AutorestCI regenerate azure-sdk-for-go

@AutorestCI AutorestCI mentioned this pull request Jan 8, 2019
Merged
solankisamir
solankisamir requested changes Jan 8, 2019
View reviewed changes
Copy link
Member

@solankisamir solankisamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

examples and enum name fix. Rest looks good.

dsgouda
dsgouda approved these changes Jan 9, 2019
View reviewed changes
Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsgouda dsgouda merged commit 989dc64 into Azure:master Jan 9, 2019
@VitaliyKurokhtin VitaliyKurokhtin deleted the vvk/oai3 branch January 9, 2019 20:14
TalluriAnusha pushed a commit to AsrOneSdk/azure-rest-api-specs that referenced this pull request Feb 6, 2019
@VitaliyKurokhtin @AnuTalluri
OpenAPIv3 support documented (Azure#5000)
bf9fd22 
* OpenAPIv3 support documented

* Enum name fixed. Example added
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@solankisamir solankisamir solankisamir approved these changes

+1 more reviewer

@dsgouda dsgouda dsgouda approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@dsgouda dsgouda

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@VitaliyKurokhtin @azuresdkci @AutorestCI @dsgouda @jhendrixMSFT @solankisamir