Skip to content

ServiceBus2018-preview: Updated as per review comments from ARM Team for Eventhub swagger - #4989

Merged
Anu Thomas (anuchandy) merged 1 commit into
Azure:masterfrom
v-Ajnava:SB2018preview
Jan 10, 2019
Merged

ServiceBus2018-preview: Updated as per review comments from ARM Team for Eventhub swagger#4989
Anu Thomas (anuchandy) merged 1 commit into
Azure:masterfrom
v-Ajnava:SB2018preview

Conversation

@v-Ajnava

Copy link
Copy Markdown
Contributor

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-portal-comment

Copy link
Copy Markdown

If you're a MSFT employee, click this link
to view this PR's validation status on our new OpenAPI Hub spec management tool.

@AutorestCI

Azure SDK Bot (AutorestCI) commented Jan 4, 2019

Copy link
Copy Markdown

Automation for azure-sdk-for-python

Nothing to generate for azure-sdk-for-python

@v-Ajnava

Copy link
Copy Markdown
Contributor Author

EventHub: PR link with ARM team comments : #4748

@AutorestCI

Azure SDK Bot (AutorestCI) commented Jan 4, 2019

Copy link
Copy Markdown

Automation for azure-sdk-for-js

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-js#765

@azuresdkci

Copy link
Copy Markdown
Contributor

Can one of the admins verify this patch?

@v-Ajnava Ajit Navasare (v-Ajnava) changed the title Updated as per review comments from ARM Team for Eventhub swagger ServiceBus2018-preview: Updated as per review comments from ARM Team for Eventhub swagger Jan 4, 2019
@AutorestCI

Azure SDK Bot (AutorestCI) commented Jan 4, 2019

Copy link
Copy Markdown

Automation for azure-sdk-for-ruby

A PR has been created for you:
Azure/azure-sdk-for-ruby#2122

@AutorestCI

Azure SDK Bot (AutorestCI) commented Jan 4, 2019

Copy link
Copy Markdown

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@AutorestCI

Azure SDK Bot (AutorestCI) commented Jan 4, 2019

Copy link
Copy Markdown

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#4530

@AutorestCI

Azure SDK Bot (AutorestCI) commented Jan 4, 2019

Copy link
Copy Markdown

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@anuchandy

Copy link
Copy Markdown
Member

Closing and re-opening to rerun diff tool, which was failing with message

 An assembly specified in the application dependencies manifest (OpenApiDiff.deps.json) was not found

@openapi-portal-comment

Copy link
Copy Markdown

If you're a MSFT employee, click this link
to view this PR's validation status on our new OpenAPI Hub spec management tool.

@anuchandy

Copy link
Copy Markdown
Member

Sarangan Rajamanickam (@sarangan12) investigated the CI OpenAPIDiff invocation failure. This is happening for 3 PRs, images used to run tools for those PR were invalid, this fixed now.

@anuchandy
Anu Thomas (anuchandy) merged commit d9443c4 into Azure:master Jan 10, 2019
TalluriAnusha pushed a commit to AsrOneSdk/azure-rest-api-specs that referenced this pull request Feb 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants