Add RedirectConfiguration to support the redirect routing rule by zhuangquin · Pull Request #4943 · Azure/azure-rest-api-specs

zhuangquin · 2018-12-18T20:25:27Z

This change is to add the support the redirect routing rule in Azure Frontdoor.

Define a new object called "RedirectConfiguration" to encapsulate all the properties that are needed to define a redirect routing rule.
Add the property "redirectConfiguration" in RoutingRule.
The "type" property in RoutingRule is changed to an Enum with two options: Forward and Redirect. To define a forward-routing rule, this property must not be provided. This ensures that this change is backward compatible with the current API.
To define a redirect-routing rule, the "type" property must be set to "Redirect" and the redirectConfiguration property must have a valid RedirectConfiguration object.

openapi-portal-comment · 2018-12-18T20:25:29Z

If you're a MSFT employee, click this link
to view this PR's validation status on our new OpenAPI Hub spec management tool.

AutorestCI · 2018-12-18T20:26:01Z

Automation for azure-sdk-for-ruby

Encountered an unknown error: (azure-sdk-for-ruby)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout 038423fd0aae4a1e21e986c036e2e2d1b4efde7b
  stderr: 'fatal: reference is not a tree: 038423fd0aae4a1e21e986c036e2e2d1b4efde7b'

AutorestCI · 2018-12-18T20:26:04Z

Automation for azure-sdk-for-js

Encountered an unknown error: (azure-sdk-for-js)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout 038423fd0aae4a1e21e986c036e2e2d1b4efde7b
  stderr: 'fatal: reference is not a tree: 038423fd0aae4a1e21e986c036e2e2d1b4efde7b'

AutorestCI · 2018-12-18T20:26:15Z

Automation for azure-sdk-for-java

Encountered an unknown error: (azure-sdk-for-java)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout 038423fd0aae4a1e21e986c036e2e2d1b4efde7b
  stderr: 'fatal: reference is not a tree: 038423fd0aae4a1e21e986c036e2e2d1b4efde7b'

AutorestCI · 2018-12-18T20:26:17Z

Automation for azure-sdk-for-python

Encountered an unknown error: (azure-sdk-for-python)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout 038423fd0aae4a1e21e986c036e2e2d1b4efde7b
  stderr: 'fatal: reference is not a tree: 038423fd0aae4a1e21e986c036e2e2d1b4efde7b'

AutorestCI · 2018-12-18T20:27:23Z

Automation for azure-sdk-for-node

Encountered an unknown error: (azure-sdk-for-node)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout 038423fd0aae4a1e21e986c036e2e2d1b4efde7b
  stderr: 'fatal: reference is not a tree: 038423fd0aae4a1e21e986c036e2e2d1b4efde7b'

azuresdkci · 2018-12-18T20:27:28Z

Can one of the admins verify this patch?

AutorestCI · 2018-12-18T20:28:10Z

Automation for azure-sdk-for-go

Encountered an unknown error: (azure-sdk-for-go)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout 038423fd0aae4a1e21e986c036e2e2d1b4efde7b
  stderr: 'fatal: reference is not a tree: 038423fd0aae4a1e21e986c036e2e2d1b4efde7b'

...ation/frontdoor/resource-manager/Microsoft.Network/preview/2018-08-01-preview/frontdoor.json

dsgouda · 2018-12-18T23:16:49Z

@MikhailTryakhov PTAL

dsgouda · 2018-12-19T16:57:04Z

Please retarget the PR to appropriate branch per @MikhailTryakhov 's recommendation

dsgouda · 2018-12-19T22:39:44Z

This is FrontDoor RP, not related to NRP.

openapi-portal-comment · 2018-12-19T22:39:45Z

If you're a MSFT employee, click this link
to view this PR's validation status on our new OpenAPI Hub spec management tool.

dsgouda

LGTM

dsgouda · 2018-12-19T22:43:40Z

...ation/frontdoor/resource-manager/Microsoft.Network/preview/2018-08-01-preview/frontdoor.json

+          "type": "string",
+          "description": "If left blank, then we will use the incoming host as the destination host."
+        },
+        "destinationPath": {


nit: you can use pattern specifiers to enforce this. Not blocking on this.
An example here

fezha-m · 2018-12-20T03:41:17Z

...ation/frontdoor/resource-manager/Microsoft.Network/preview/2018-08-01-preview/frontdoor.json

+        "routeType": {
+          "type": "string",
+          "enum": [
+            "Forwarding",


Nit: "Forward" instead of "Forwarding", or else "Redirecting" instead of "Redirect"

fezha-m · 2018-12-20T03:43:25Z

...ation/frontdoor/resource-manager/Microsoft.Network/preview/2018-08-01-preview/frontdoor.json

          }
+        },
+        "redirectConfiguration": {
+          "description": "A reference to the redirect routing configuration. It is null for a forward-routing rule. But it must not be null if the routeType property is set to Redirect.",


nit: "forward routing rule" remove '-'

fezha-m · 2018-12-20T05:01:39Z

...icrosoft.Network/preview/2018-08-01-preview/examples/FrontdoorRedirectRoutingRuleCreate.json

+            "destinationProtocol": "Https",
+            "destinationHost": "www.bing.com",
+            "destinationPath": "/api",
+            "preservePath": "No",


better to add destination fragment into the examples

fezha-m · 2018-12-20T05:04:30Z

...icrosoft.Network/preview/2018-08-01-preview/examples/FrontdoorRedirectRoutingRuleCreate.json

+            "destinationHost": "www.bing.com",
+            "destinationPath": "/api",
+            "preservePath": "No",
+            "preserveQueryString": "Yes"


Is it necessary to update the forwarding creation/update examples, to reflect the "routeType" and null "redirectionConfiguration"?
Is "routeType" a required field?

I see "routeType" must be optional to support backward compatibility

fezha-m · 2018-12-20T05:42:57Z

...ation/frontdoor/resource-manager/Microsoft.Network/preview/2018-08-01-preview/frontdoor.json

+            "modelAsString": true
+          }
+        },
+        "destinationProtocol": {


The SharedSchema use "destinationSchema", better to be consistent
the other fields are already consistent

dsgouda · 2019-01-22T23:55:08Z

Closing due to inactivity. If you are a Microsoft employee, please join Microsoft and Azure orgs on github. and open a new PR

zhuangquin added 3 commits December 17, 2018 14:55

Add the redirect configuration to support the redirect route

81caab7

Add the examples for rediret routing rrule

2ac4eec

Capitalize the first letter of Redirect

2fe92e4

kpajdzik added the review label Dec 18, 2018

AutorestCI mentioned this pull request Dec 18, 2018

[AutoPR frontdoor/resource-manager] Add RedirectConfiguration to support the redirect routing rule Azure/azure-sdk-for-js#863

Closed

AutorestCI mentioned this pull request Dec 18, 2018

[AutoPR frontdoor/resource-manager] Add RedirectConfiguration to support the redirect routing rule Azure/azure-sdk-for-python#4093

Closed

azuresdkci assigned dsgouda Dec 18, 2018

azuresdkci requested a review from dsgouda December 18, 2018 20:26

AutorestCI mentioned this pull request Dec 18, 2018

[AutoPR frontdoor/resource-manager] Add RedirectConfiguration to support the redirect routing rule Azure/azure-sdk-for-node#4478

Closed

AutorestCI mentioned this pull request Dec 18, 2018

[AutoPR frontdoor/resource-manager] Add RedirectConfiguration to support the redirect routing rule Azure/azure-sdk-for-go#3758

Closed

Change the structure of a RouteRule Enum value

0cb338a

dsgouda suggested changes Dec 18, 2018

View reviewed changes

...ation/frontdoor/resource-manager/Microsoft.Network/preview/2018-08-01-preview/frontdoor.json Show resolved Hide resolved

...ation/frontdoor/resource-manager/Microsoft.Network/preview/2018-08-01-preview/frontdoor.json Outdated Show resolved Hide resolved

dsgouda requested a review from MikhailTryakhov December 18, 2018 23:16

Add the routeType property

3c896b9

dsgouda closed this Dec 19, 2018

kpajdzik removed the review label Dec 19, 2018

dsgouda reopened this Dec 19, 2018

kpajdzik added the review label Dec 19, 2018

dsgouda reviewed Dec 19, 2018

View reviewed changes

dsgouda approved these changes Dec 19, 2018

View reviewed changes

zhuangquin added 2 commits December 19, 2018 16:12

Replace the boolean type with an Enum type with proper string values

d38f7ca

Update the examples

045d7a0

fezha-m reviewed Dec 20, 2018

View reviewed changes

dsgouda closed this Jan 22, 2019

Conversation

zhuangquin commented Dec 18, 2018

Uh oh!

openapi-portal-comment bot commented Dec 18, 2018

Uh oh!

AutorestCI commented Dec 18, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-ruby

Uh oh!

AutorestCI commented Dec 18, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-js

Uh oh!

AutorestCI commented Dec 18, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-java

Uh oh!

AutorestCI commented Dec 18, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-python

Uh oh!

AutorestCI commented Dec 18, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-node

Uh oh!

azuresdkci commented Dec 18, 2018

Uh oh!

AutorestCI commented Dec 18, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-go

Uh oh!

Uh oh!

Uh oh!

dsgouda commented Dec 18, 2018

Uh oh!

dsgouda commented Dec 19, 2018

Uh oh!

dsgouda commented Dec 19, 2018

Uh oh!

openapi-portal-comment bot commented Dec 19, 2018

Uh oh!

dsgouda left a comment

Choose a reason for hiding this comment

Uh oh!

dsgouda Dec 19, 2018

Choose a reason for hiding this comment

Uh oh!

fezha-m Dec 20, 2018

Choose a reason for hiding this comment

Uh oh!

fezha-m Dec 20, 2018

Choose a reason for hiding this comment

Uh oh!

fezha-m Dec 20, 2018

Choose a reason for hiding this comment

Uh oh!

fezha-m Dec 20, 2018

Choose a reason for hiding this comment

Uh oh!

fezha-m Dec 20, 2018

Choose a reason for hiding this comment

Uh oh!

fezha-m Dec 20, 2018

Choose a reason for hiding this comment

Uh oh!

dsgouda commented Jan 22, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

AutorestCI commented Dec 18, 2018 •

edited

Loading

AutorestCI commented Dec 18, 2018 •

edited

Loading

AutorestCI commented Dec 18, 2018 •

edited

Loading

AutorestCI commented Dec 18, 2018 •

edited

Loading

AutorestCI commented Dec 18, 2018 •

edited

Loading

AutorestCI commented Dec 18, 2018 •

edited

Loading