Skip to content
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
123 changes: 123 additions & 0 deletions specification/sql/resource-manager/readme.java.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,123 @@

### Java

These settings apply only when `--java` is specified on the command line.
Please also specify `--azure-libraries-for-java-folder=<path to the root directory of your azure-libraries-for-java clone>`.

``` yaml $(java)
azure-arm: true
fluent: true
namespace: com.microsoft.azure.management.sql
license-header: MICROSOFT_MIT_NO_CODEGEN
payload-flattening-threshold: 1
output-folder: $(azure-libraries-for-java-folder)/azure-mgmt-sql
```


### Java multi-api

``` yaml $(java) && $(multiapi)
batch:
- tag: package-pure-2014-04
- tag: package-pure-2015-05-preview
- tag: package-pure-fixed-2017-03-preview
- tag: package-pure-2017-10-preview
- tag: package-pure-2018-06-preview
```

### Tag: package-pure-2014-04 and java

These settings apply only when `--tag=package-pure-2014-04 --java` is specified on the command line.
Please also specify `--azure-libraries-for-java=<path to the root directory of your azure-sdk-for-java clone>`.

``` yaml $(tag) == 'package-pure-2014-04' && $(java) && $(multiapi)
java:
namespace: com.microsoft.azure.management.sql.v2014_04_01
output-folder: $(azure-libraries-for-java-folder)/sql/resource-manager/v2014_04_01
regenerate-manager: true
generate-interface: true
```

### Tag: package-pure-2015-05-preview and java

These settings apply only when `--tag=package-pure-2015-05-preview --java` is specified on the command line.
Please also specify `--azure-libraries-for-java=<path to the root directory of your azure-sdk-for-java clone>`.

``` yaml $(tag) == 'package-pure-2015-05-preview' && $(java) && $(multiapi)
java:
namespace: com.microsoft.azure.management.sql.v2015_05_01_preview
output-folder: $(azure-libraries-for-java-folder)/sql/resource-manager/v2015_05_01_preview
regenerate-manager: true
generate-interface: true
```

### Tag: package-pure-fixed-2017-03-previewand java

These settings apply only when `--tag=package-pure-fixed-2017-03-preview --java` is specified on the command line.
Please also specify `--azure-libraries-for-java=<path to the root directory of your azure-sdk-for-java clone>`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment about directive would be nice for future readers to understand the context.


``` yaml $(tag) == 'package-pure-fixed-2017-03-preview' && $(java) && $(multiapi)
java:
namespace: com.microsoft.azure.management.sql.v2017_03_01_preview
output-folder: $(azure-libraries-for-java-folder)/sql/resource-manager/v2017_03_01_preview
regenerate-manager: true
generate-interface: true
```

### Tag: package-pure-2017-10-preview and java

These settings apply only when `--tag=package-pure-2017-10-preview --java` is specified on the command line.
Please also specify `--azure-libraries-for-java=<path to the root directory of your azure-sdk-for-java clone>`.

``` yaml $(tag) == 'package-pure-2017-10-preview' && $(java) && $(multiapi)
java:
namespace: com.microsoft.azure.management.sql.v2017_10_01_preview
output-folder: $(azure-libraries-for-java-folder)/sql/resource-manager/v2017_10_01_preview
regenerate-manager: true
generate-interface: true
```

### Tag: package-pure-2018-06-preview and java

These settings apply only when `--tag=package-pure-2018-06-preview --java` is specified on the command line.
Please also specify `--azure-libraries-for-java=<path to the root directory of your azure-sdk-for-java clone>`.

``` yaml $(tag) == 'package-pure-2018-06-preview' && $(java) && $(multiapi)
java:
namespace: com.microsoft.azure.management.sql.v2018_06_01_preview
output-folder: $(azure-libraries-for-java-folder)/sql/resource-manager/v2018_06_01_preview
regenerate-manager: true
generate-interface: true
```

### Tag: package-pure-fixed-2017-03-preview

These settings apply only when `--tag=package-pure-fixed-2017-03-preview` is specified on the command line.

This section contains all input swagger files for version 2017-03-01-preview. All APIs of that version must be added this section when the API is ready for production.

APIs must only be added to this section when the API is publicly available in at least 1 production region and at least 1 generated client has been tested end-to-end.

These can be regenerated by running the following PowerShell script from this readme file's folder: `dir .\Microsoft.Sql\preview\2017-03-01-preview\ -File | Resolve-Path -Relative | % { " - $_".Replace("\", "/") }`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please explain in tag description how it is different from other tags :) What was the problem with dataWarehouseUserActivities.json ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jaredmoo investigating :) for some reason it is hitting autorest exception - https://github.com/Azure/azure-rest-api-specs/runs/40229948 . I'm trying to isolate the error. Error message does not make sense :(

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jaredmoo ok I found the issue. The problem is that in 2017-03-01-preview\dataWarehouseUserActivities.json operationIds are named as dataWarehouseUserActivities and there is actually model definition which contain model with the name dataWarehouseUserActivities and that creates generation collision. Fortunately for java multi-api generation I can add a directive to rename dataWarehouseUserActivities type to dataWarehouseUserActivity and get everything generated.

@jaredmoo I think that model should be renamed inside swagger. Why is it in plural form? it does not seems to contain any array or lists of objects.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, adding directive sounds awesome so that we don't need to add a new tag.

The reason it's plural is that it represents the aggregate status of recent activities, not just a single activity per resource. This collision is unfortunate, we could have renamed it on initial checkin if we knew about this problem :( but I want to maintain backcompat.


``` yaml $(tag) == 'package-pure-fixed-2017-03-preview'
input-file:
- ./Microsoft.Sql/preview/2017-03-01-preview/blobAuditing.json
- ./Microsoft.Sql/preview/2017-03-01-preview/cancelOperations.json
- ./Microsoft.Sql/preview/2017-03-01-preview/databases.json
- ./Microsoft.Sql/preview/2017-03-01-preview/databaseVulnerabilityAssessmentBaselines.json
- ./Microsoft.Sql/preview/2017-03-01-preview/databaseVulnerabilityAssessments.json
- ./Microsoft.Sql/preview/2017-03-01-preview/jobs.json
- ./Microsoft.Sql/preview/2017-03-01-preview/longTermRetention.json
- ./Microsoft.Sql/preview/2017-03-01-preview/ManagedBackupShortTermRetention.json
- ./Microsoft.Sql/preview/2017-03-01-preview/managedDatabases.json
- ./Microsoft.Sql/preview/2017-03-01-preview/renameDatabase.json
- ./Microsoft.Sql/preview/2017-03-01-preview/restorePoints.json
- ./Microsoft.Sql/preview/2017-03-01-preview/serverAutomaticTuning.json
- ./Microsoft.Sql/preview/2017-03-01-preview/serverDnsAliases.json
- ./Microsoft.Sql/preview/2017-03-01-preview/serverSecurityAlertPolicies.json

# Needed when there is more than one input file
override-info:
title: SqlManagementClient
```
48 changes: 1 addition & 47 deletions specification/sql/resource-manager/readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -644,53 +644,7 @@ See configuration in [readme.go.md](./readme.go.md)

### Java

These settings apply only when `--java` is specified on the command line.
Please also specify `--azure-libraries-for-java-folder=<path to the root directory of your azure-libraries-for-java clone>`.

``` yaml $(java)
azure-arm: true
fluent: true
namespace: com.microsoft.azure.management.sql
license-header: MICROSOFT_MIT_NO_CODEGEN
payload-flattening-threshold: 1
output-folder: $(azure-libraries-for-java-folder)/azure-mgmt-sql
```


### Java multi-api

``` yaml $(java) && $(multiapi)
batch:
- tag: package-pure-2017-10-preview
- tag: package-2014-04
```

### Tag: package-pure-2017-10-preview and java

These settings apply only when `--tag=package-pure-2017-10-preview --java` is specified on the command line.
Please also specify `--azure-libraries-for-java=<path to the root directory of your azure-sdk-for-java clone>`.

``` yaml $(tag) == 'package-pure-2017-10-preview' && $(java) && $(multiapi)
java:
namespace: com.microsoft.azure.management.sql.v2017_10_01_preview
output-folder: $(azure-libraries-for-java-folder)/sql/resource-manager/v2017_10_01_preview
regenerate-manager: true
generate-interface: true
```

### Tag: package-2014-04 and java

These settings apply only when `--tag=package-2014-04 --java` is specified on the command line.
Please also specify `--azure-libraries-for-java=<path to the root directory of your azure-sdk-for-java clone>`.

``` yaml $(tag) == 'package-2014-04' && $(java) && $(multiapi)
java:
namespace: com.microsoft.azure.management.sql.v2014_04_01
output-folder: $(azure-libraries-for-java-folder)/sql/resource-manager/v2014_04_01
regenerate-manager: true
generate-interface: true
```

See configuration in [readme.java.md](./readme.java.md)

## Validation

Expand Down