typo: relay/resource-manager/Microsoft.Relay by nschonni · Pull Request #4877 · Azure/azure-rest-api-specs

nschonni · 2018-12-11T04:34:31Z

successfuly -> successfully
Autorization -> Authorization
Regenrate -> Regenerate
retirve -> retrieve
usermetadata -> userMetadata
reponse -> response
namespce -> namespace
butthe -> but the
neeeds -> needs

openapi-portal-comment · 2018-12-11T04:34:32Z

If you're a MSFT employee, click this link
to view this PR's validation status on our new OpenAPI Hub spec management tool.

AutorestCI · 2018-12-11T04:35:16Z

Automation for azure-sdk-for-python

Encountered an unknown error: (azure-sdk-for-python)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout 3c3c7c0ce237770dd33ef9d93129465da0a5f849
  stderr: 'fatal: reference is not a tree: 3c3c7c0ce237770dd33ef9d93129465da0a5f849'

AutorestCI · 2018-12-11T04:35:24Z

Automation for azure-sdk-for-js

Encountered an unknown error: (azure-sdk-for-js)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout 3c3c7c0ce237770dd33ef9d93129465da0a5f849
  stderr: 'fatal: reference is not a tree: 3c3c7c0ce237770dd33ef9d93129465da0a5f849'

AutorestCI · 2018-12-11T04:35:42Z

Automation for azure-sdk-for-ruby

Encountered an unknown error: (azure-sdk-for-ruby)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout 3c3c7c0ce237770dd33ef9d93129465da0a5f849
  stderr: 'fatal: reference is not a tree: 3c3c7c0ce237770dd33ef9d93129465da0a5f849'

AutorestCI · 2018-12-11T04:36:19Z

Automation for azure-sdk-for-node

A PR has been created for you:
Azure/azure-sdk-for-node#5034

AutorestCI · 2018-12-11T04:36:51Z

Automation for azure-sdk-for-go

Encountered an unknown error: (azure-sdk-for-go)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout 3c3c7c0ce237770dd33ef9d93129465da0a5f849
  stderr: 'fatal: reference is not a tree: 3c3c7c0ce237770dd33ef9d93129465da0a5f849'

azuresdkci · 2018-12-11T04:36:54Z

Can one of the admins verify this patch?

AutorestCI · 2018-12-11T04:37:33Z

Automation for azure-sdk-for-java

Encountered an unknown error: (azure-sdk-for-java)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout 3c3c7c0ce237770dd33ef9d93129465da0a5f849
  stderr: 'fatal: reference is not a tree: 3c3c7c0ce237770dd33ef9d93129465da0a5f849'

nschonni · 2019-01-08T17:25:45Z

@anuchandy looks like the model check isn't passing from existing example issues, anything to change otherwise?

nschonni · 2019-02-12T04:10:22Z

@sethmanheim @v-Ajnava is this a generated API or are these fixes OK?

sethmanheim · 2019-02-12T16:34:07Z

@nschonni I am not working on Relay anymore -- you might check with @spelluru who can confirm with the engineering team.

spelluru · 2019-02-12T16:39:32Z

Clemens is the architect and PM of this service.

@clemensv - Please review when you get a chance. Thanks.

salameer · 2019-04-04T20:05:44Z

@anuchandy same question here I guess. if these are breaking changes on the generated SDKs, then we might have to abort these changes for now @nschonni :(

As sometime fixing these typose might acutally introduce breaking changes on the generated SDks for customers.

Changes on description are perfectly but it gets tricket with files names sometimes. @anu to verify

nschonni · 2019-04-04T20:24:14Z

Yup, in this case the file name changes are for example files, so I didn't think there should be anything client breaking.
Looks like the Avocado failures are from other example files in the repo, that aren't currently referenced by any specs, not a SDK failure

nschonni · 2019-04-12T03:42:52Z

@salameer I submitted #5621 to fix the Avocado failure. I can move the commit here if that's better

- successfuly -> successfully - Autorization -> Authorization - Regenrate -> Regenerate - retirve -> retrieve - usermetadata -> userMetadata - reponse -> response - namespce -> namespace - butthe -> but the - neeeds -> needs

The property isn't part of the model and causes Model Validation error

nschonni · 2019-04-12T17:50:06Z

@salameer @anuchandy I updated the example and now everything is green

salameer · 2019-04-23T21:02:16Z

Same for this PR, I would kindly request that we avoid changing the file names

nschonni · 2019-04-24T02:12:48Z

OK, I won't be resubmitting

AutorestCI mentioned this pull request Dec 11, 2018

[AutoPR relay/resource-manager] typo: relay/resource-manager/Microsoft.Relay Azure/azure-sdk-for-python#4039

Closed

AutorestCI mentioned this pull request Dec 11, 2018

[AutoPR relay/resource-manager] typo: relay/resource-manager/Microsoft.Relay Azure/azure-sdk-for-js#810

Closed

azuresdkci assigned anuchandy Dec 11, 2018

azuresdkci requested a review from anuchandy December 11, 2018 04:35

AutorestCI mentioned this pull request Dec 11, 2018

[AutoPR relay/resource-manager] typo: relay/resource-manager/Microsoft.Relay Azure/azure-sdk-for-ruby#2069

Closed

AutorestCI mentioned this pull request Dec 11, 2018

[AutoPR relay/resource-manager] typo: relay/resource-manager/Microsoft.Relay Azure/azure-sdk-for-node#4430

Closed

AutorestCI mentioned this pull request Dec 11, 2018

[AutoPR relay/resource-manager] typo: relay/resource-manager/Microsoft.Relay Azure/azure-sdk-for-go#3679

Closed

AutorestCI mentioned this pull request Dec 11, 2018

[AutoPR relay/resource-manager] typo: relay/resource-manager/Microsoft.Relay Azure/azure-sdk-for-java#2764

Closed

nschonni force-pushed the typo-relay/resource-manager/Microsoft.Relay branch from 5caaa7e to dc6eb55 Compare February 12, 2019 03:55

This was referenced Feb 12, 2019

[AutoPR relay/resource-manager] typo: relay/resource-manager/Microsoft.Relay Azure/azure-sdk-for-ruby#2223

Closed

[AutoPR relay/resource-manager] typo: relay/resource-manager/Microsoft.Relay Azure/azure-sdk-for-go#4069

Closed

nschonni force-pushed the typo-relay/resource-manager/Microsoft.Relay branch from dc6eb55 to c298d67 Compare March 22, 2019 18:52

nschonni mentioned this pull request Apr 12, 2019

chore: Remove orphan Relay examples #5621

Merged

typo: relay/resource-manager/Microsoft.Relay

78a533f

- successfuly -> successfully - Autorization -> Authorization - Regenrate -> Regenerate - retirve -> retrieve - usermetadata -> userMetadata - reponse -> response - namespce -> namespace - butthe -> but the - neeeds -> needs

nschonni force-pushed the typo-relay/resource-manager/Microsoft.Relay branch from c298d67 to 78a533f Compare April 12, 2019 17:15

AutorestCI mentioned this pull request Apr 12, 2019

[AutoPR relay/resource-manager] typo: relay/resource-manager/Microsoft.Relay Azure/azure-sdk-for-js#2209

Closed

fix: Remove "description" from examples

65e96ce

The property isn't part of the model and causes Model Validation error

salameer closed this Apr 23, 2019

nschonni deleted the typo-relay/resource-manager/Microsoft.Relay branch April 23, 2019 21:04

Conversation

nschonni commented Dec 11, 2018

Uh oh!

openapi-portal-comment bot commented Dec 11, 2018

Uh oh!

AutorestCI commented Dec 11, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-python

Uh oh!

AutorestCI commented Dec 11, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-js

Uh oh!

AutorestCI commented Dec 11, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-ruby

Uh oh!

AutorestCI commented Dec 11, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-node

Uh oh!

AutorestCI commented Dec 11, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-go

Uh oh!

azuresdkci commented Dec 11, 2018

Uh oh!

AutorestCI commented Dec 11, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-java

Uh oh!

nschonni commented Jan 8, 2019

Uh oh!

nschonni commented Feb 12, 2019

Uh oh!

sethmanheim commented Feb 12, 2019

Uh oh!

spelluru commented Feb 12, 2019

Uh oh!

salameer commented Apr 4, 2019

Uh oh!

nschonni commented Apr 4, 2019

Uh oh!

nschonni commented Apr 12, 2019

Uh oh!

nschonni commented Apr 12, 2019

Uh oh!

salameer commented Apr 23, 2019

Uh oh!

nschonni commented Apr 24, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

AutorestCI commented Dec 11, 2018 •

edited

Loading

AutorestCI commented Dec 11, 2018 •

edited

Loading

AutorestCI commented Dec 11, 2018 •

edited

Loading

AutorestCI commented Dec 11, 2018 •

edited

Loading

AutorestCI commented Dec 11, 2018 •

edited

Loading

AutorestCI commented Dec 11, 2018 •

edited

Loading