Merged
Conversation
|
If you're a MSFT employee, click this link |
Automation for azure-sdk-for-pythonThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-jsThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-rubyNothing to generate for azure-sdk-for-ruby |
Automation for azure-sdk-for-goEncountered a Subprocess error: (azure-sdk-for-go)
Command: ['/usr/local/bin/autorest', '/tmp/tmpsc86_whn/rest/specification/iothub/resource-manager/readme.md', '--go', '--go-sdk-folder=/tmp/tmpsc86_whn/src/github.com/Azure/azure-sdk-for-go', '--multiapi', '--preview-chk', '--use=@microsoft.azure/autorest.go@~2.1.127', '--use-onever', '--verbose'] AutoRest code generation utility [version: 2.0.4283; node: v8.12.0]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
Loading AutoRest core '/root/.autorest/@microsoft.azure_autorest-core@2.0.4289/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4289)
Including configuration file 'file:///tmp/tmpsc86_whn/rest/specification/iothub/resource-manager/readme.go.md'
Loading AutoRest extension '@microsoft.azure/autorest.go' (~2.1.127->2.1.127)
Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.38->2.3.38)
Processing batch task - {"tag":"package-2018-12-preview"} .
Including configuration file 'file:///tmp/tmpsc86_whn/rest/specification/iothub/resource-manager/readme.go.md'
FATAL: System.InvalidOperationException: codegen for preview swagger Microsoft.Devices/preview/2018-12-01-preview/iothub.json must be under a preview subdirectory
at AutoRest.Go.CodeGeneratorGo.<Generate>d__6.MoveNext() in /home/vsts/work/1/s/src/CodeGeneratorGo.cs:line 51
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at AutoRest.Go.Program.<ProcessInternal>d__3.MoveNext() in /home/vsts/work/1/s/src/Program.cs:line 107
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()
at NewPlugin.<Process>d__20.MoveNext() in /home/vsts/work/1/s/autorest.common/src/Plugins/NewPlugin.cs:line 163
FATAL: go/generate - FAILED
FATAL: Error: Plugin go reported failure.
Process() cancelled due to exception : Plugin go reported failure.
Failure during batch task - {"tag":"package-2018-12-preview"} -- Error: Plugin go reported failure..
Error: Plugin go reported failure. |
Automation for azure-sdk-for-nodeNothing to generate for azure-sdk-for-node |
Automation for azure-sdk-for-javaNothing to generate for azure-sdk-for-java |
Contributor
|
Can one of the admins verify this patch? |
anusapan
changed the title
jianghaolu
suggested changes
Dec 11, 2018
| ``` yaml $(tag) == 'package-2018-12' && $(java) && $(multiapi) | ||
| java: | ||
| namespace: com.microsoft.azure.management.iothub.v2018_12_01 | ||
| output-folder: $(azure-libraries-for-java-folder)/iothub/resource-manager/v2018_12_01 |
Contributor
There was a problem hiding this comment.
Contributor
There was a problem hiding this comment.
same for namespace. I would recommend having -preview on the tag as well.
jianghaolu
approved these changes
Dec 12, 2018
TalluriAnusha
pushed a commit
to AsrOneSdk/azure-rest-api-specs
that referenced
this pull request
Feb 6, 2019
* Add package-2018-12 to Go SDK build * fixed PR failure * Adding 2018-12-01-preview package to GO * removing preview from Go * fixed PR comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.