Skip to content

Conversation

@ankurkul
Copy link
Contributor

@ankurkul ankurkul commented Dec 7, 2018

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-portal-comment
Copy link

If you're a MSFT employee, click this link
to view this PR's validation status on our new OpenAPI Hub spec management tool.

@AutorestCI
Copy link

AutorestCI commented Dec 7, 2018

Automation for azure-sdk-for-js

Nothing to generate for azure-sdk-for-js

@AutorestCI
Copy link

AutorestCI commented Dec 7, 2018

Automation for azure-sdk-for-python

Nothing to generate for azure-sdk-for-python

@AutorestCI
Copy link

AutorestCI commented Dec 7, 2018

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@ankurkul
Copy link
Contributor Author

ankurkul commented Dec 7, 2018

@hovsepm This PR can be merged if it clears all the gates.

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI
Copy link

AutorestCI commented Dec 7, 2018

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@AutorestCI
Copy link

AutorestCI commented Dec 7, 2018

Automation for azure-sdk-for-node

Nothing to generate for azure-sdk-for-node

@AutorestCI
Copy link

AutorestCI commented Dec 7, 2018

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@ankurkul
Copy link
Contributor Author

ankurkul commented Dec 7, 2018

@amarzavery @hovsepm : Could one of your review this pr. would like to merge it soon.

@amarzavery
Copy link
Contributor

There is a failure in example validation. Please take a look at the logs over here

@amarzavery
Copy link
Contributor

There are still some model validator issues. You can find them here https://travis-ci.org/Azure/azure-rest-api-specs/jobs/466121837#L604. Please fix them.

@ankurkul
Copy link
Contributor Author

Yeah, I am looking into them.

@ankurkul
Copy link
Contributor Author

@amarzavery : Can I run these validations jobs locally before pushing them to PR?

@amarzavery
Copy link
Contributor

amarzavery commented Dec 10, 2018

I think so.
Set these environment variables for model validator

export MODE=model
export PR_ONLY=true
export CHECK_NAME="Model Validator"

Then from the root of the repo

  • npm install
  • node scripts/modelValidation.js

This should tell you if there are any model validation errors.

NOTE: make sure you have the latest LTS version of node.js installed on your system. You can get that from https://nodejs.org

@ankurkul
Copy link
Contributor Author

There is still one Job that fails while validating models which we haven't changed in this PR (intune.json etc). Not sure how can we resolve them: https://travis-ci.org/Azure/azure-rest-api-specs/jobs/466144309 @amarzavery

@ankurkul
Copy link
Contributor Author

All the other jobs passed. Are we good to merge now?

@amarzavery amarzavery merged commit 58cfc70 into Azure:master Dec 10, 2018
TalluriAnusha pushed a commit to AsrOneSdk/azure-rest-api-specs that referenced this pull request Feb 6, 2019
…zure#4823)

* Add DeviceStreams properties to IoTHub and modify RoutingTwin object for new preview API

* Add example files

* Fix the api version

* Fix build failure

* validation fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants