-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Add DeviceStreams properties to IoTHub and modify RoutingTwin object #4823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
If you're a MSFT employee, click this link |
Automation for azure-sdk-for-jsNothing to generate for azure-sdk-for-js |
Automation for azure-sdk-for-pythonNothing to generate for azure-sdk-for-python |
Automation for azure-sdk-for-rubyNothing to generate for azure-sdk-for-ruby |
|
@hovsepm This PR can be merged if it clears all the gates. |
|
Can one of the admins verify this patch? |
Automation for azure-sdk-for-goNothing to generate for azure-sdk-for-go |
Automation for azure-sdk-for-nodeNothing to generate for azure-sdk-for-node |
Automation for azure-sdk-for-javaNothing to generate for azure-sdk-for-java |
|
@amarzavery @hovsepm : Could one of your review this pr. would like to merge it soon. |
|
There is a failure in example validation. Please take a look at the logs over here |
|
There are still some model validator issues. You can find them here https://travis-ci.org/Azure/azure-rest-api-specs/jobs/466121837#L604. Please fix them. |
|
Yeah, I am looking into them. |
|
@amarzavery : Can I run these validations jobs locally before pushing them to PR? |
|
I think so. Then from the root of the repo
This should tell you if there are any model validation errors. NOTE: make sure you have the latest LTS version of node.js installed on your system. You can get that from https://nodejs.org |
|
There is still one Job that fails while validating models which we haven't changed in this PR (intune.json etc). Not sure how can we resolve them: https://travis-ci.org/Azure/azure-rest-api-specs/jobs/466144309 @amarzavery |
|
All the other jobs passed. Are we good to merge now? |
…zure#4823) * Add DeviceStreams properties to IoTHub and modify RoutingTwin object for new preview API * Add example files * Fix the api version * Fix build failure * validation fixes
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.