[Azure Data Factory] Adding refresh and get IntegrationRuntimeObjectMetadata API by meiyan-Li · Pull Request #4724 · Azure/azure-rest-api-specs

meiyan-Li · 2018-12-03T07:18:53Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

openapi-portal-comment · 2018-12-03T07:18:55Z

If you're a MSFT employee, click this link
to view this PR's validation status on our new OpenAPI Hub spec management tool.

AutorestCI · 2018-12-03T07:19:21Z

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

AutorestCI · 2018-12-03T07:20:32Z

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2293

azuresdkci · 2018-12-03T07:23:39Z

Can one of the admins verify this patch?

AutorestCI · 2018-12-03T07:28:19Z

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#4190

AutorestCI · 2018-12-03T07:36:13Z

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#3644

AutorestCI · 2018-12-03T07:39:57Z

Automation for azure-sdk-for-js

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-js#578

AutorestCI · 2018-12-03T07:49:34Z

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#2136

meiyan-Li · 2018-12-03T07:55:09Z

@hvermis Please help take a look, thanks!

KrisBash

LGTM for ARM

...cation/datafactory/resource-manager/Microsoft.DataFactory/stable/2018-06-01/datafactory.json

hvermis · 2018-12-07T02:17:03Z

...cation/datafactory/resource-manager/Microsoft.DataFactory/stable/2018-06-01/datafactory.json

+            "$ref": "./examples/IntegrationRuntimeObjectMetadata_Refresh.json"
+          }
+        },
+        "description": "Refresh a ssis integration runtime object metadata.",


Change to "SSIS"

hvermis · 2018-12-07T02:17:27Z

...cation/datafactory/resource-manager/Microsoft.DataFactory/stable/2018-06-01/datafactory.json

+            "$ref": "./examples/IntegrationRuntimeObjectMetadata_Get.json"
+          }
+        },
+        "description": "Get a ssis integration runtime object metadata by specified path. The return is pageable metadata list.",


Same here, and any other if there are more

...crosoft.DataFactory/stable/2018-06-01/examples/IntegrationRuntimeObjectMetadata_Refresh.json

meiyan-Li · 2018-12-07T03:48:27Z

@sergey-shandar Could you help merge the code?

sergey-shandar · 2018-12-07T22:57:02Z

@meiyan-Li could you fix model validation errors?

amarzavery · 2018-12-08T03:46:55Z

@meiyan-Li There are model validation failures. Please fix them. You can take a look at the logs over here.

amarzavery

fix model validation failures.

meiyan-Li · 2018-12-08T04:16:12Z

@amarzavery I have fixed my model validation issue. For the existing operation model validation issue, hermins have a backlog to fix it. Please see this PR for more info: #3957

meiyan-Li · 2018-12-11T02:55:23Z

@amarzavery Please help merge this PR

…etadata API (Azure#4724) * Adding refresh and get IntegrationRuntimeObjectMetadata API * Change ssis to upper case * Fix model validation issue

Adding refresh and get IntegrationRuntimeObjectMetadata API

aded924

AutorestCI mentioned this pull request Dec 3, 2018

[AutoPR datafactory/resource-manager] Adding refresh and get IntegrationRuntimeObjectMetadata API Azure/azure-sdk-for-python#3962

Merged

AutorestCI mentioned this pull request Dec 3, 2018

[AutoPR datafactory/resource-manager] Adding refresh and get IntegrationRuntimeObjectMetadata API Azure/azure-sdk-for-node#4291

Merged

azuresdkci assigned sergey-shandar Dec 3, 2018

azuresdkci requested a review from sergey-shandar December 3, 2018 07:30

AutorestCI mentioned this pull request Dec 3, 2018

[AutoPR datafactory/resource-manager] Adding refresh and get IntegrationRuntimeObjectMetadata API Azure/azure-sdk-for-go#3519

Merged

AutorestCI mentioned this pull request Dec 3, 2018

[AutoPR datafactory/resource-manager] Adding refresh and get IntegrationRuntimeObjectMetadata API Azure/azure-sdk-for-js#678

Merged

AutorestCI mentioned this pull request Dec 3, 2018

[AutoPR datafactory/resource-manager] Adding refresh and get IntegrationRuntimeObjectMetadata API Azure/azure-sdk-for-java#2710

Merged

sergey-shandar added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Dec 3, 2018

meiyan-Li changed the title ~~Adding refresh and get IntegrationRuntimeObjectMetadata API~~ [Azure Data Factory] Adding refresh and get IntegrationRuntimeObjectMetadata API Dec 6, 2018

KrisBash approved these changes Dec 6, 2018

View reviewed changes

KrisBash added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Dec 6, 2018

hvermis reviewed Dec 7, 2018

View reviewed changes

...cation/datafactory/resource-manager/Microsoft.DataFactory/stable/2018-06-01/datafactory.json Outdated Show resolved Hide resolved

hvermis reviewed Dec 7, 2018

View reviewed changes

...crosoft.DataFactory/stable/2018-06-01/examples/IntegrationRuntimeObjectMetadata_Refresh.json Show resolved Hide resolved

hvermis approved these changes Dec 7, 2018

View reviewed changes

Change ssis to upper case

38fb817

sergey-shandar added the Reassign label Dec 7, 2018

azuresdkci removed the Reassign label Dec 7, 2018

azuresdkci assigned amarzavery and unassigned sergey-shandar Dec 7, 2018

azuresdkci requested a review from amarzavery December 7, 2018 23:03

amarzavery suggested changes Dec 8, 2018

View reviewed changes

Fix model validation issue

43c2dab

amarzavery approved these changes Dec 11, 2018

View reviewed changes

amarzavery merged commit 026fdc7 into Azure:master Dec 11, 2018

meiyan-Li mentioned this pull request Jan 15, 2019

[Azure Data Factory] Generate new SDK Azure/azure-sdk-for-net#5142

Merged

9 tasks

Conversation

meiyan-Li commented Dec 3, 2018

Latest improvements:

Contribution checklist:

ARM API Review Checklist

Uh oh!

openapi-portal-comment bot commented Dec 3, 2018

Uh oh!

AutorestCI commented Dec 3, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-ruby

Uh oh!

AutorestCI commented Dec 3, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-python

Uh oh!

azuresdkci commented Dec 3, 2018

Uh oh!

AutorestCI commented Dec 3, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-node

Uh oh!

AutorestCI commented Dec 3, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-go

Uh oh!

AutorestCI commented Dec 3, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-js

Uh oh!

AutorestCI commented Dec 3, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-java

Uh oh!

meiyan-Li commented Dec 3, 2018

Uh oh!

KrisBash left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

hvermis Dec 7, 2018

Choose a reason for hiding this comment

Uh oh!

meiyan-Li Dec 7, 2018

Choose a reason for hiding this comment

Uh oh!

hvermis Dec 7, 2018

Choose a reason for hiding this comment

Uh oh!

meiyan-Li Dec 7, 2018

Choose a reason for hiding this comment

Uh oh!

Uh oh!

meiyan-Li commented Dec 7, 2018

Uh oh!

sergey-shandar commented Dec 7, 2018

Uh oh!

amarzavery commented Dec 8, 2018

Uh oh!

amarzavery left a comment

Choose a reason for hiding this comment

Uh oh!

meiyan-Li commented Dec 8, 2018

Uh oh!

meiyan-Li commented Dec 11, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

AutorestCI commented Dec 3, 2018 •

edited

Loading

AutorestCI commented Dec 3, 2018 •

edited

Loading

AutorestCI commented Dec 3, 2018 •

edited

Loading

AutorestCI commented Dec 3, 2018 •

edited

Loading

AutorestCI commented Dec 3, 2018 •

edited

Loading

AutorestCI commented Dec 3, 2018 •

edited

Loading