chore: Rename microsoft.insights to Microsoft.Insights #4713
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If you're a MSFT employee, click this link |
Automation for azure-sdk-for-goNothing to generate for azure-sdk-for-go |
Automation for azure-sdk-for-jsThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-rubyNothing to generate for azure-sdk-for-ruby |
Automation for azure-sdk-for-pythonThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-nodeThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-javaThe initial PR has been merged into your service PR: |
Contributor
|
Can one of the admins verify this patch? |
Contributor
Author
|
Looks like the automation can't handle the case change, but I'm not sure if it would be an issue after it lands |
This was referenced Dec 3, 2018
praries880
approved these changes
Dec 5, 2018
TalluriAnusha
pushed a commit
to AsrOneSdk/azure-rest-api-specs
that referenced
this pull request
Feb 6, 2019
* chore: Rename microsoft.insights to Microsoft.Insights * fix: Casing on applicationinsights/resource-manager YAML metadata
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are currently 2 folders with the different casing in https://github.com/Azure/azure-rest-api-specs/tree/master/specification/applicationinsights/resource-manager
These are the only files that showed up as diffs imediately when I enabled
git config core.ignorecase falsein order to change casing on some other files.The data-plane folder is also lowercase, but since it is all lowercase it doesn't cause the same issue.