Skip to content

New APIs for container instance #4643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jianghaolu merged 7 commits into from
Dec 13, 2018
Merged

New APIs for container instance #4643

jianghaolu merged 7 commits into from
Dec 13, 2018

Conversation

@yangl900
Copy link
Contributor

@yangl900 yangl900 commented Dec 1, 2018

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • [ X ] I have reviewed the documentation for the workflow.
  • [ X ] Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • [ X ] The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • [ X ] Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-portal-comment
Copy link

openapi-portal-comment bot commented Dec 1, 2018

If you're a MSFT employee, click this link
to view this PR's validation status on our new OpenAPI Hub spec management tool.

@AutorestCI AutorestCI mentioned this pull request Dec 1, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Dec 1, 2018 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#3979

@azuresdkci azuresdkci requested a review from jianghaolu December 1, 2018 00:20
@AutorestCI AutorestCI mentioned this pull request Dec 1, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Dec 1, 2018 •
edited
Loading

Automation for azure-sdk-for-js

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-js#706

@AutorestCI AutorestCI mentioned this pull request Dec 1, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Dec 1, 2018 •
edited
Loading

Automation for azure-sdk-for-ruby

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-ruby#1899

@azuresdkci
Copy link
Contributor

azuresdkci commented Dec 1, 2018

Can one of the admins verify this patch?

@AutorestCI AutorestCI mentioned this pull request Dec 1, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Dec 1, 2018 •
edited
Loading

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#2576

@yangl900
Copy link
Contributor Author

yangl900 commented Dec 1, 2018

I believe we need WaitForARMFeedback tag.

@vladimirjoanovic vladimirjoanovic added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required ARMReviewInProgress labels Dec 1, 2018
@AutorestCI
Copy link

AutorestCI commented Dec 1, 2018 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#3696

This was referenced Dec 1, 2018
Merged
Closed
@AutorestCI
Copy link

AutorestCI commented Dec 1, 2018 •
edited
Loading

Automation for azure-sdk-for-node

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-node#4321

yangl900
yangl900 commented Dec 4, 2018
View reviewed changes
Copy link
Contributor Author

@yangl900 yangl900 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved the comments. @ravbhatnagar please help take a look again.

@ruchikaguptaa ruchikaguptaa mentioned this pull request Dec 7, 2018
Closed
2 tasks
KrisBash
KrisBash approved these changes Dec 7, 2018
View reviewed changes
Copy link
Contributor

@KrisBash KrisBash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KrisBash KrisBash added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Dec 7, 2018
@yangl900
Copy link
Contributor Author

yangl900 commented Dec 8, 2018

anyone can help merge this PR? @jianghaolu ?

@ravbhatnagar
Copy link
Contributor

ravbhatnagar commented Dec 10, 2018

Re-Signing off from ARM side.

@jianghaolu jianghaolu merged commit dd4a045 into Azure:master Dec 13, 2018
TalluriAnusha pushed a commit to AsrOneSdk/azure-rest-api-specs that referenced this pull request Feb 6, 2019
@yangl900 @AnuTalluri
New APIs for container instance (Azure#4643)
77965dc 
* Add ACI spec

* fix swagger

* Fix casing

* Rename and fix warnings

* Fix warnings and typo

* add default response

* Add Id property.
mccleanp pushed a commit that referenced this pull request Mar 23, 2022
@subbartt
Adding disk props for specifying device name and type... (#4643)
21cc4b3 
* Adding disk props

* minor updates

* minor udpate

* update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@ravbhatnagar ravbhatnagar ravbhatnagar left review comments

@jianghaolu jianghaolu jianghaolu approved these changes

@KrisBash KrisBash KrisBash approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jianghaolu jianghaolu

Labels

ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@yangl900 @AutorestCI @azuresdkci @ravbhatnagar @jianghaolu @KrisBash @vladimirjoanovic