Adding sync scenarios to public preview swagger by ash1625 · Pull Request #4627 · Azure/azure-rest-api-specs

ash1625 · 2018-11-29T23:16:52Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

openapi-portal-comment · 2018-11-29T23:16:53Z

If you're a MSFT employee, click this link
to view this PR's validation status on our new OpenAPI Hub spec management tool.

azuresdkci · 2018-11-29T23:17:27Z

Can one of the admins verify this patch?

AutorestCI · 2018-11-29T23:17:51Z

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

AutorestCI · 2018-11-29T23:18:34Z

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#3814

AutorestCI · 2018-11-29T23:21:24Z

Automation for azure-sdk-for-js

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-js#519

AutorestCI · 2018-11-29T23:24:07Z

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#2603

AutorestCI · 2018-11-29T23:25:06Z

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#4123

AutorestCI · 2018-11-29T23:25:55Z

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#3728

...n/resource-manager/Microsoft.DataMigration/preview/2018-07-15-preview/definitions/Tasks.json

....DataMigration/preview/2018-07-15-preview/definitions/ConnectToSourcePostgreSqlSyncTask.json

...esource-manager/Microsoft.DataMigration/preview/2018-07-15-preview/definitions/Commands.json

....DataMigration/preview/2018-07-15-preview/definitions/ConnectToSourcePostgreSqlSyncTask.json

neetusingh-ms

Thanks Ashish.

praries880 · 2018-12-05T18:18:08Z

@ravbhatnagar can you kindly take a look at this?

ravbhatnagar · 2018-12-10T19:15:18Z

@ash1625 - There are a lot of changes in this PR. It might be quicker to review this over a meeting. Please feel to set something up with GauravBh and armapireview.

ravbhatnagar · 2018-12-14T01:45:41Z

Signing off from ARM side. Noted few issues during the in-person review. Service team is close to GA and may not be able to likely fix it for this api-version. But will likely consider for the next one.

Rename "errors" in MigrateSyncCompleteCommandOutput properties.
How to get information of all the commands on a task.
Implementation for updating an existing tasks.
migrationSetting/sourceSetting/targetSetting object (expand this object for known properties ) good for CLI/powershell users.

* Adding sync scenarios to public preview swagger * Fix comments on pull request * Add files to GA folder * Add missing file to swagger in GA folder * remove mongoDB chnages from stable folder * add orphaned user changes to the repo * minor string fix * Change orphanedUsers to orphanedUsersInfo * Change orphanedUsers to orphanedUsersInfo

Adding sync scenarios to public preview swagger

8df81ff

ash1625 requested a review from hitenjava as a code owner November 29, 2018 23:16

ash1625 requested review from neetusingh-ms and sichoudh November 29, 2018 23:17

ash1625 requested a review from swjain23 November 29, 2018 23:17

azuresdkci assigned praries880 Nov 29, 2018

azuresdkci requested a review from praries880 November 29, 2018 23:17

AutorestCI mentioned this pull request Nov 29, 2018

[AutoPR datamigration/resource-manager] Adding sync scenarios to public preview swagger Azure/azure-sdk-for-python#3901

Merged

AutorestCI mentioned this pull request Nov 29, 2018

[AutoPR datamigration/resource-manager] Adding sync scenarios to public preview swagger Azure/azure-sdk-for-js#617

Merged

AutorestCI mentioned this pull request Nov 29, 2018

[AutoPR datamigration/resource-manager] Adding sync scenarios to public preview swagger Azure/azure-sdk-for-java#2670

Merged

AutorestCI mentioned this pull request Nov 29, 2018

[AutoPR datamigration/resource-manager] Adding sync scenarios to public preview swagger Azure/azure-sdk-for-node#4224

Merged

AutorestCI mentioned this pull request Nov 29, 2018

[AutoPR datamigration/resource-manager] Adding sync scenarios to public preview swagger Azure/azure-sdk-for-go#3443

Closed

hitenjava reviewed Nov 30, 2018

View reviewed changes

...n/resource-manager/Microsoft.DataMigration/preview/2018-07-15-preview/definitions/Tasks.json Outdated Show resolved Hide resolved

hitenjava reviewed Nov 30, 2018

View reviewed changes

....DataMigration/preview/2018-07-15-preview/definitions/ConnectToSourcePostgreSqlSyncTask.json Outdated Show resolved Hide resolved

hitenjava reviewed Nov 30, 2018

View reviewed changes

...esource-manager/Microsoft.DataMigration/preview/2018-07-15-preview/definitions/Commands.json Outdated Show resolved Hide resolved

hitenjava reviewed Nov 30, 2018

View reviewed changes

...esource-manager/Microsoft.DataMigration/preview/2018-07-15-preview/definitions/Commands.json Outdated Show resolved Hide resolved

praries880 added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Dec 3, 2018

neetusingh-ms reviewed Dec 3, 2018

View reviewed changes

....DataMigration/preview/2018-07-15-preview/definitions/ConnectToSourcePostgreSqlSyncTask.json Outdated Show resolved Hide resolved

Fix comments on pull request

e07d780

neetusingh-ms approved these changes Dec 3, 2018

View reviewed changes

AutorestCI mentioned this pull request Dec 3, 2018

[AutoPR datamigration/resource-manager] Adding sync scenarios to public preview swagger Azure/azure-sdk-for-go#3541

Merged

hitenjava approved these changes Dec 4, 2018

View reviewed changes

ash1625 added 2 commits December 4, 2018 17:42

Add files to GA folder

2f43f0f

Add missing file to swagger in GA folder

4b9d3c3

ash1625 added 3 commits December 5, 2018 11:27

remove mongoDB chnages from stable folder

d82a179

add orphaned user changes to the repo

b3902e7

minor string fix

194999d

ravbhatnagar added the ARMReviewInProgress label Dec 10, 2018

hitenjava added 2 commits December 12, 2018 17:16

Change orphanedUsers to orphanedUsersInfo

9ab00bc

Change orphanedUsers to orphanedUsersInfo

e2c1966

ravbhatnagar mentioned this pull request Dec 14, 2018

[Microsoft.DataMigration] [APIIssue] PUT is not idempotent #4914

Open

ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMReviewInProgress WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Dec 14, 2018

praries880 approved these changes Dec 14, 2018

View reviewed changes

praries880 merged commit b2b7f82 into Azure:master Dec 14, 2018

ash1625 mentioned this pull request Jan 8, 2019

Add Postgres/MySql/ManagedInstance online migration scenarios Azure/azure-sdk-for-net#5120

Merged

9 tasks

Conversation

ash1625 commented Nov 29, 2018

Latest improvements:

Contribution checklist:

ARM API Review Checklist

Uh oh!

openapi-portal-comment bot commented Nov 29, 2018

Uh oh!

azuresdkci commented Nov 29, 2018

Uh oh!

AutorestCI commented Nov 29, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-ruby

Uh oh!

AutorestCI commented Nov 29, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-python

Uh oh!

AutorestCI commented Nov 29, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-js

Uh oh!

AutorestCI commented Nov 29, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-java

Uh oh!

AutorestCI commented Nov 29, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-node

Uh oh!

AutorestCI commented Nov 29, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-go

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

neetusingh-ms left a comment

Choose a reason for hiding this comment

Uh oh!

praries880 commented Dec 5, 2018

Uh oh!

ravbhatnagar commented Dec 10, 2018

Uh oh!

ravbhatnagar commented Dec 14, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Comments

AutorestCI commented Nov 29, 2018 •

edited

Loading

AutorestCI commented Nov 29, 2018 •

edited

Loading

AutorestCI commented Nov 29, 2018 •

edited

Loading

AutorestCI commented Nov 29, 2018 •

edited

Loading

AutorestCI commented Nov 29, 2018 •

edited

Loading

AutorestCI commented Nov 29, 2018 •

edited

Loading