Skip to content

Comments

Resource Health RP changes for new resource type /events and /impacte…#4601

Merged
anuchandy merged 6 commits intoAzure:masterfrom
HimanshuMisra1:azure-service-health-events-master
Dec 12, 2018
Merged

Resource Health RP changes for new resource type /events and /impacte…#4601
anuchandy merged 6 commits intoAzure:masterfrom
HimanshuMisra1:azure-service-health-events-master

Conversation

@HimanshuMisra1
Copy link
Contributor

@HimanshuMisra1 HimanshuMisra1 commented Nov 28, 2018

Resource Health RP changes for new resource type /events and /impactedResources.

This is a re-open from previous PR #2127 which was closed due to inactivity around an year back. Starting a new one with first iteration for changes which were already signed off by ARM (please check label in previous PR). Will add another update/iteration with changes that have happened since then, should be minor additions of additional properties.

We want a new preview api-version 2018-01-01-preview.

@openapi-portal-comment
Copy link

openapi-portal-comment bot commented Nov 28, 2018 •
edited by billytrend
Loading

If you're a MSFT employee, click this link
to view this PR's validation status on our new OpenAPI Hub spec management tool.

@AutorestCI
Copy link

AutorestCI commented Nov 28, 2018 •
edited
Loading

Automation for azure-sdk-for-python

Nothing to generate for azure-sdk-for-python

@AutorestCI
Copy link

AutorestCI commented Nov 28, 2018 •
edited
Loading

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI
Copy link

AutorestCI commented Nov 28, 2018 •
edited
Loading

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@AutorestCI AutorestCI mentioned this pull request Nov 28, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Nov 28, 2018 •
edited
Loading

Automation for azure-sdk-for-js

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-js#800

@AutorestCI AutorestCI mentioned this pull request Nov 28, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Nov 28, 2018 •
edited
Loading

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#4419

@azuresdkci
Copy link
Contributor

azuresdkci commented Nov 28, 2018

Can one of the admins verify this patch?

@AutorestCI
Copy link

AutorestCI commented Nov 28, 2018 •
edited
Loading

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@ravbhatnagar ravbhatnagar added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Nov 29, 2018
@KrisBash KrisBash added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Dec 6, 2018
KrisBash
KrisBash approved these changes Dec 6, 2018
View reviewed changes
Copy link
Contributor

@KrisBash KrisBash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see comment regarding missing Extension resource paths

@sergey-shandar
Copy link
Contributor

sergey-shandar commented Dec 7, 2018

@HimanshuMisra1 could you fix model validation errors https://travis-ci.org/Azure/azure-rest-api-specs/jobs/464693921 ?

@azuresdkci azuresdkci requested a review from anuchandy December 7, 2018 23:33
@anuchandy
Copy link
Member

anuchandy commented Dec 12, 2018

There seems couple of model Validation errors still pending https://travis-ci.org/Azure/azure-rest-api-specs/jobs/466782277, please take a look.

@anuchandy anuchandy merged commit 84f31a4 into Azure:master Dec 12, 2018
TalluriAnusha pushed a commit to AsrOneSdk/azure-rest-api-specs that referenced this pull request Feb 6, 2019
@HimanshuMisra1 @AnuTalluri
Resource Health RP changes for new resource type /events and /impacte… (
7fdd680 
Azure#4601)

* Resource Health RP changes for new resource type /events and /impactedResources

* Update with additional properties

* Add additional path for single resource

* Fixing examples

* More model validator fixes

* Model validator fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anuchandy anuchandy anuchandy approved these changes

+2 more reviewers

@sergey-shandar sergey-shandar sergey-shandar approved these changes

@KrisBash KrisBash KrisBash approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@anuchandy anuchandy

Labels

ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@HimanshuMisra1 @AutorestCI @azuresdkci @sergey-shandar @anuchandy @KrisBash @ravbhatnagar