Add support for List Operation on global reach connections by dedhar · Pull Request #4589 · Azure/azure-rest-api-specs

dedhar · 2018-11-27T17:42:07Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

[Y ] I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

…01 to version 2018-10-01

* Update specification/network/resource-manager/Microsoft.Network/stable/2018-08-01/networkWatcher.json [Networkwatcher] add a new field "Format" with new type"FlowLogFormat" to FlowLogProperties * Revert "Update specification/network/resource-manager/Microsoft.Network/stable/2018-08-01/networkWatcher.json" This reverts commit f4f438a. * Update specification/network/resource-manager/Microsoft.Network/stable/2018-10-01/networkWatcher.json [networkwatcer] add FlowLogFormatParameters

…ure#4420)

…ceid (Azure#4459)

* Adds base for updating Microsoft.Network from version stable/2018-08-01 to version 2018-10-01 * Updates readme * Updates API version in new specs and examples * Adds Rewrite rule set for Header CRUD Adds the structure of rewriteRuleSets in the applicationGatewayProperties. Adds recursively the sub structures in the rewriteRuleSet. Adds the reference to rewriteRuleSet in the requestRoutingRule for both Basic rule and Path based rule. * Adds examples for the Header CRUD in application gateway * Fix the examples; replacing rules with rewriteRules. * Fixing the properties of application Gateway rewriteRule * Revert "Fixing the properties of application Gateway rewriteRule" This reverts commit 05c9c91. * Fixing the properties of application Gateway rewriteRule * Mark the provisioning state as readOnly * Mark etag as readOnly

…rces" (Azure#4467) * Revert "Application Gateway - Adds Rewrite rule set for Header CRUD (Azure#4331)" This reverts commit 633d12d. * Revert "Port fix from PR 4459 to 2018-10-01 (Azure#4463)" This reverts commit 5ea0c7b. * Revert "change container nics property type on container nic config to resourceid (Azure#4459)" This reverts commit baf31d9.

* identity and keyvault * Capitalization comment

…zure-rest-api-specs

openapi-portal-comment · 2018-11-27T17:42:09Z

If you're a MSFT employee, click this link
to view this PR's validation status on our new OpenAPI Hub spec management tool.

azuresdkci · 2018-11-27T17:42:40Z

Can one of the admins verify this patch?

dedhar · 2018-11-27T17:43:52Z

https://msazure.visualstudio.com/One/_workitems/edit/3334271 -- Tracking workitem

AutorestCI · 2018-11-27T17:47:39Z

Automation for azure-sdk-for-js

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-js#593

AutorestCI · 2018-11-27T17:47:57Z

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

dedhar · 2018-11-27T17:56:42Z

Tested the change using local NRP and ARM Client
D:>armclient get "http://127.0.0.1/subscriptions/873b0459-81fb-4b4d-a304-68c4abb58ce6/resourceGroups/rg1/providers/Microsoft.Network/expressRouteCircuits/circuit_local526/peerings/AzurePrivatePeering/connections?api-version=2018-02-01"
{
"value": [
{
"name": "circuitConnectionCktAToB",
"id": "/subscriptions/873b0459-81fb-4b4d-a304-68c4abb58ce6/resourceGroups/rg1/providers/Microsoft.Network/expressRouteCircuits/circuit_local526/peerings/AzurePrivatePeering/connections/circuitConnectionCktAToB",
"etag": "W/"e7c5535a-40c8-4c47-810a-2a6f09b6c383"",
"properties": {
"provisioningState": "Succeeded",
"expressRouteCircuitPeering": {
"id": "/subscriptions/873b0459-81fb-4b4d-a304-68c4abb58ce6/resourceGroups/rg1/providers/Microsoft.Network/expressRouteCircuits/circuit_local526/peerings/AzurePrivatePeering"
},
"peerExpressRouteCircuitPeering": {
"id": "/subscriptions/873b0459-81fb-4b4d-a304-68c4abb58ce6/resourceGroups/rg1/providers/Microsoft.Network/expressRouteCircuits/circuit_peer526/peerings/AzurePrivatePeering"
},
"addressPrefix": "10.0.0.0/29",
"circuitConnectionStatus": "Connected"
},
"type": "Microsoft.Network/expressRouteCircuits/peerings/connections"
},
{
"name": "circuitConnectionCktAToC",
"id": "/subscriptions/873b0459-81fb-4b4d-a304-68c4abb58ce6/resourceGroups/rg1/providers/Microsoft.Network/expressRouteCircuits/circuit_local526/peerings/AzurePrivatePeering/connections/circuitConnectionCktAToC",
"etag": "W/"e7c5535a-40c8-4c47-810a-2a6f09b6c383"",
"properties": {
"provisioningState": "Succeeded",
"expressRouteCircuitPeering": {
"id": "/subscriptions/873b0459-81fb-4b4d-a304-68c4abb58ce6/resourceGroups/rg1/providers/Microsoft.Network/expressRouteCircuits/circuit_local526/peerings/AzurePrivatePeering"
},
"peerExpressRouteCircuitPeering": {
"id": "/subscriptions/873b0459-81fb-4b4d-a304-68c4abb58ce6/resourceGroups/rg1/providers/Microsoft.Network/expressRouteCircuits/circuit_third526/peerings/AzurePrivatePeering"
},
"addressPrefix": "20.0.0.0/29",
"circuitConnectionStatus": "Connected"
},
"type": "Microsoft.Network/expressRouteCircuits/peerings/connections"
}
]
}

AutorestCI · 2018-11-27T17:56:55Z

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#3779

syfarogh

Thanks for the update

AutorestCI · 2018-11-27T18:22:01Z

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#3422

AutorestCI · 2018-11-27T18:23:27Z

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#4205

AutorestCI · 2018-11-27T18:40:35Z

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

MikhailTryakhov · 2018-11-27T20:02:46Z

merge directly to master approved cause we haven't created new branch yet

MikhailTryakhov · 2018-11-27T20:10:06Z

@jianghaolu please merge

MikhailTryakhov and others added 18 commits October 30, 2018 12:42

Adds base for updating Microsoft.Network from version stable/2018-08-…

a656032

…01 to version 2018-10-01

Updates readme

c3cd206

Updates API version in new specs and examples

1c4c949

[Network wathcer] add a new field trafficAnalyticsInterval for TA (Az…

66d8777

…ure#4420)

Make NIC VM ref readonly (Azure#4443)

92d2e0a

Mark private IP address read-only (Azure#4447)

5a95c8f

change container nics property type on container nic config to resour…

baf31d9

…ceid (Azure#4459)

Port fix from PR 4459 to 2018-10-01 (Azure#4463)

5ea0c7b

Fixes the missing array for the header actions (Azure#4497)

f321a6c

Network py 2018-10

8f92958

add package-2018-10 to Go SDK codegen

d5e3525

Application gateway Identity and Keyvault support (Azure#4387)

e582297

* identity and keyvault * Capitalization comment

Ported fix from master branch (Azure#4547)

89199d6

Merge branch 'network-november-release' of https://github.com/Azure/a…

9273ebf

…zure-rest-api-specs

Add support for list api for global reach connections

b9c1d43

dedhar requested a review from MikhailTryakhov as a code owner November 27, 2018 17:42

azuresdkci assigned jianghaolu Nov 27, 2018

azuresdkci requested a review from jianghaolu November 27, 2018 17:42

dedhar requested review from syfarogh and vinayada1 November 27, 2018 17:44

AutorestCI mentioned this pull request Nov 27, 2018

[AutoPR network/resource-manager] Add support for List Operation on global reach connections Azure/azure-sdk-for-js#588

Merged

AutorestCI mentioned this pull request Nov 27, 2018

[AutoPR network/resource-manager] Add support for List Operation on global reach connections Azure/azure-sdk-for-python#3884

Merged

address farhan comment

72a407c

syfarogh reviewed Nov 27, 2018

View reviewed changes

syfarogh approved these changes Nov 27, 2018

View reviewed changes

AutorestCI mentioned this pull request Nov 27, 2018

[AutoPR network/resource-manager] Add support for List Operation on global reach connections Azure/azure-sdk-for-go#3415

Merged

AutorestCI mentioned this pull request Nov 27, 2018

[AutoPR network/resource-manager] Add support for List Operation on global reach connections Azure/azure-sdk-for-node#4201

Merged

MikhailTryakhov approved these changes Nov 27, 2018

View reviewed changes

jianghaolu merged commit 2aebd7d into Azure:master Nov 27, 2018

Conversation

dedhar commented Nov 27, 2018

Latest improvements:

Contribution checklist:

Uh oh!

openapi-portal-comment bot commented Nov 27, 2018

Uh oh!

azuresdkci commented Nov 27, 2018

Uh oh!

dedhar commented Nov 27, 2018

Uh oh!

AutorestCI commented Nov 27, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-js

Uh oh!

AutorestCI commented Nov 27, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-ruby

Uh oh!

dedhar commented Nov 27, 2018

Uh oh!

AutorestCI commented Nov 27, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-python

Uh oh!

syfarogh left a comment

Choose a reason for hiding this comment

Uh oh!

AutorestCI commented Nov 27, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-go

Uh oh!

AutorestCI commented Nov 27, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-node

Uh oh!

AutorestCI commented Nov 27, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-java

Uh oh!

MikhailTryakhov commented Nov 27, 2018

Uh oh!

MikhailTryakhov commented Nov 27, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

14 participants

AutorestCI commented Nov 27, 2018 •

edited

Loading

AutorestCI commented Nov 27, 2018 •

edited

Loading

AutorestCI commented Nov 27, 2018 •

edited

Loading

AutorestCI commented Nov 27, 2018 •

edited

Loading

AutorestCI commented Nov 27, 2018 •

edited

Loading

AutorestCI commented Nov 27, 2018 •

edited

Loading