Skip to content

Comments

Microsoft.StorageSync - Fix Issue 4559 and other known problems with preview version#4565

Merged
sergey-shandar merged 3 commits intoAzure:masterfrom
ankushbindlish2:StorageSync-Fix-Issues-In-Preview-Version
Nov 27, 2018
Merged

Microsoft.StorageSync - Fix Issue 4559 and other known problems with preview version#4565
sergey-shandar merged 3 commits intoAzure:masterfrom
ankushbindlish2:StorageSync-Fix-Issues-In-Preview-Version

Conversation

@ankushbindlish2
Copy link
Member

@ankushbindlish2 ankushbindlish2 commented Nov 26, 2018

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

@openapi-portal-comment
Copy link

If you're a MSFT employee, click this link
to view this PR's validation status on our new OpenAPI Hub spec management tool.

@AutorestCI
Copy link

AutorestCI commented Nov 26, 2018

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI
Copy link

AutorestCI commented Nov 26, 2018

Automation for azure-sdk-for-python

Nothing to generate for azure-sdk-for-python

@AutorestCI
Copy link

AutorestCI commented Nov 26, 2018

Automation for azure-sdk-for-js

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-js#590

@AutorestCI
Copy link

AutorestCI commented Nov 26, 2018

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#4124

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI
Copy link

AutorestCI commented Nov 26, 2018

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#3418

@AutorestCI
Copy link

AutorestCI commented Nov 26, 2018

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@nschonni
Copy link
Contributor

Closes #4559

@sergey-shandar sergey-shandar added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required potential-sdk-breaking-change labels Nov 26, 2018
@ankushbindlish2
Copy link
Member Author

@sergey-shandar this is a preview folder apiversion . Not sure if it still qualifies for above labels.

Copy link
Contributor

@KrisBash KrisBash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for ARM

@KrisBash KrisBash added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Nov 27, 2018
@sergey-shandar sergey-shandar merged commit 92f4bec into Azure:master Nov 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review potential-sdk-breaking-change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants