add customKeyIdentifier to password credential#4507
Conversation
|
If you're a MSFT employee, click this link |
Automation for azure-sdk-for-pythonThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-jsThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-rubyThe initial PR has been merged into your service PR: |
|
Can one of the admins verify this patch? |
Automation for azure-sdk-for-goThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-javaThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-nodeThe initial PR has been merged into your service PR: |
|
@lmazuel, please review. If you are happy, please publish the python sdk |
| }, | ||
| "customKeyIdentifier": { | ||
| "type":"string", | ||
| "format": "byte", |
There was a problem hiding this comment.
Cert based id should be a plain string with the thumbprint as the value
There was a problem hiding this comment.
byte – base64-encoded characters, for example, U3dhZ2dlciByb2Nrcw==
So it depends only if you have base64 string on the wire. If yes, the right value is "byte". If no, the right value is "string"
There was a problem hiding this comment.
After check, this string is actually not byte on the wire and the fix is right.
| }, | ||
| "customKeyIdentifier": { | ||
| "type": "string", | ||
| "format": "byte", |
There was a problem hiding this comment.
byte – base64-encoded characters, for example, U3dhZ2dlciByb2Nrcw==
So it depends only if you have base64 string on the wire. If yes, the right value is "byte". If no, the right value is "string"
There was a problem hiding this comment.
Checked on Fiddler, this one is definitley base64 (and then byte)
lmazuel
left a comment
lmazuel
left a comment
There was a problem hiding this comment.
Double checked and tested with CLI
5 participants
//CC: @lmazuel. CLI users want this
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist: