Skip to content

Comments

upgrade ManagedServiceIdentity Api-Version to 2018-11-30#4488

Closed
wendyNEU wants to merge 1 commit intoAzure:masterfrom
wendyNEU:UpdateManagedServiceIdentityApiVersion
Closed

upgrade ManagedServiceIdentity Api-Version to 2018-11-30#4488
wendyNEU wants to merge 1 commit intoAzure:masterfrom
wendyNEU:UpdateManagedServiceIdentityApiVersion

Conversation

@wendyNEU
Copy link
Contributor

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the worflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

Update Managed Service Identity Api-version to 2018-11-30, the new-version haven't be deployed to PROD, and review now, but merge after the new version finish deployment

Result of validation

Use autorest to validate readme.md:

C:\azure-rest-api-specs\specification\msi\resource-manager>autorest readme.md
AutoRest code generation utility [version: 2.0.4283; node: v7.10.0]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
Loading AutoRest core 'C:\Users\diqiu.autorest@microsoft.azure_autorest-core@2.0.4289\node_modules@microsoft.azure\autorest-core\dist' (2.0.4289)

User oav to validate ManagedIdentity.json:

C:\azure-rest-api-specs\specification\msi\resource-manager\Microsoft.ManagedIdentity\2018-11-30>oav validate-example ManagedIdentity.json
{ message: 'Validating "examples" and "x-ms-examples" in ManagedIdentity.json:\n',
level: '\u001b[32minfo\u001b[39m' }
{ message: 'Request parameters for x-ms-example "MsiOperationsList" in operation "Operations_List" is valid.',
level: '\u001b[32minfo\u001b[39m' }
{ message: 'Response with statusCode "200" for x-ms-example "MsiOperationsList" in operation "Operations_List" is valid.',
level: '\u001b[32minfo\u001b[39m' }
{ message: 'Request parameters for x-ms-example "IdentityListBySubscription" in operation "UserAssignedIdentities_ListBySubscription" is valid.',
level: '\u001b[32minfo\u001b[39m' }
{ message: 'Response with statusCode "200" for x-ms-example "IdentityListBySubscription" in operation "UserAssignedIdentities_ListBySubscription" is valid.',
level: '\u001b[32minfo\u001b[39m' }
{ message: 'Request parameters for x-ms-example "IdentityListByResourceGroup" in operation "UserAssignedIdentities_ListByResourceGroup" is valid.',
level: '\u001b[32minfo\u001b[39m' }
{ message: 'Response with statusCode "200" for x-ms-example "IdentityListByResourceGroup" in operation "UserAssignedIdentities_ListByResourceGroup" is valid.',
level: '\u001b[32minfo\u001b[39m' }
{ message: 'Request parameters for x-ms-example "IdentityCreate" in operation "UserAssignedIdentities_CreateOrUpdate" is valid.',
level: '\u001b[32minfo\u001b[39m' }
{ message: 'Response with statusCode "200" for x-ms-example "IdentityCreate" in operation "UserAssignedIdentities_CreateOrUpdate" is valid.',
level: '\u001b[32minfo\u001b[39m' }
{ message: 'Response with statusCode "201" for x-ms-example "IdentityCreate" in operation "UserAssignedIdentities_CreateOrUpdate" is valid.',
level: '\u001b[32minfo\u001b[39m' }
{ message: 'Request parameters for x-ms-example "IdentityUpdate" in operation "UserAssignedIdentities_Update" is valid.',
level: '\u001b[32minfo\u001b[39m' }
{ message: 'Response with statusCode "200" for x-ms-example "IdentityUpdate" in operation "UserAssignedIdentities_Update" is valid.',
level: '\u001b[32minfo\u001b[39m' }
{ message: 'Request parameters for x-ms-example "IdentityGet" in operation "UserAssignedIdentities_Get" is valid.',
level: '\u001b[32minfo\u001b[39m' }
{ message: 'Response with statusCode "200" for x-ms-example "IdentityGet" in operation "UserAssignedIdentities_Get" is valid.',
level: '\u001b[32minfo\u001b[39m' }
{ message: 'Request parameters for x-ms-example "IdentityDelete" in operation "UserAssignedIdentities_Delete" is valid.',
level: '\u001b[32minfo\u001b[39m' }
{ message: 'Response with statusCode "200" for x-ms-example "IdentityDelete" in operation "UserAssignedIdentities_Delete" is valid.',
level: '\u001b[32minfo\u001b[39m' }
{ message: 'Response with statusCode "204" for x-ms-example "IdentityDelete" in operation "UserAssignedIdentities_Delete" is valid.',
level: '\u001b[32minfo\u001b[39m' }
{ message: 'No Errors were found.',
level: '\u001b[32minfo\u001b[39m' }

@openapi-portal-comment
Copy link

If you're a MSFT employee, click this link
to view this PR's validation status on our new OpenAPI Hub spec management tool.

@AutorestCI
Copy link

AutorestCI commented Nov 16, 2018

Automation for azure-sdk-for-python

Encountered an unknown error: (azure-sdk-for-python)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout e876ffb25b44ac075b7bf18de08db1212fef5b5e
  stderr: 'fatal: reference is not a tree: e876ffb25b44ac075b7bf18de08db1212fef5b5e'

@AutorestCI
Copy link

AutorestCI commented Nov 16, 2018

Automation for azure-sdk-for-js

Encountered an unknown error: (azure-sdk-for-js)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout e876ffb25b44ac075b7bf18de08db1212fef5b5e
  stderr: 'fatal: reference is not a tree: e876ffb25b44ac075b7bf18de08db1212fef5b5e'

@AutorestCI
Copy link

AutorestCI commented Nov 16, 2018

Automation for azure-sdk-for-node

Encountered an unknown error: (azure-sdk-for-node)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout e876ffb25b44ac075b7bf18de08db1212fef5b5e
  stderr: 'fatal: reference is not a tree: e876ffb25b44ac075b7bf18de08db1212fef5b5e'

@AutorestCI
Copy link

AutorestCI commented Nov 16, 2018

Automation for azure-sdk-for-ruby

Encountered an unknown error: (azure-sdk-for-ruby)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout e876ffb25b44ac075b7bf18de08db1212fef5b5e
  stderr: 'fatal: reference is not a tree: e876ffb25b44ac075b7bf18de08db1212fef5b5e'

@AutorestCI
Copy link

AutorestCI commented Nov 16, 2018

Automation for azure-sdk-for-java

Encountered an unknown error: (azure-sdk-for-java)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout e876ffb25b44ac075b7bf18de08db1212fef5b5e
  stderr: 'fatal: reference is not a tree: e876ffb25b44ac075b7bf18de08db1212fef5b5e'

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI
Copy link

AutorestCI commented Nov 16, 2018

Automation for azure-sdk-for-go

Encountered an unknown error: (azure-sdk-for-go)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout e876ffb25b44ac075b7bf18de08db1212fef5b5e
  stderr: 'fatal: reference is not a tree: e876ffb25b44ac075b7bf18de08db1212fef5b5e'

@wendyNEU
Copy link
Contributor Author

"If you're a MSFT employee, click this link", I can't open that open, is it blank

@wendyNEU
Copy link
Contributor Author

I can't add a reviewer to my pr, will ask my teammate help me to take a look.
image

@hovsepm
Copy link
Contributor

hovsepm commented Nov 16, 2018

@wendyNEU please rework your PR in a way that it will contain 2 commits where the first one is just a copy from the already existing spec and the second one is modification.

You can use OpenAPI Hub tool to do that.

@wendyNEU wendyNEU closed this Nov 16, 2018
@wendyNEU wendyNEU reopened this Nov 16, 2018
@openapi-portal-comment
Copy link

If you're a MSFT employee, click this link
to view this PR's validation status on our new OpenAPI Hub spec management tool.

@wendyNEU
Copy link
Contributor Author

Send another pr to fit the require of reviewer.

@wendyNEU wendyNEU closed this Nov 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants