Skip to content

Update sensitivityLabels.json #4479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sarangan12 merged 4 commits into from
Nov 24, 2018
Merged

Update sensitivityLabels.json #4479

sarangan12 merged 4 commits into from
Nov 24, 2018

Conversation

@bashahee
Copy link
Contributor

@bashahee bashahee commented Nov 15, 2018 •
edited
Loading

Removing duplication of sensitivityLabels.json files
I noticed that same files are sitting under 2018-06-01-preview and 2017-03-01-preview versions, hence removing duplication.

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

@bashahee
Add sensitivityLabels.json to readme.md
b8e6c49 
Removing duplication of sensitivityLabels.json files, and updating readme.md
@openapi-portal-comment
Copy link

openapi-portal-comment bot commented Nov 15, 2018

If you're a MSFT employee, click this link
to view this PR's validation status on our new OpenAPI Hub spec management tool.

@bashahee bashahee requested a review from jaredmoo November 15, 2018 09:48
@AutorestCI AutorestCI mentioned this pull request Nov 15, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Nov 15, 2018 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#3769

@AutorestCI AutorestCI mentioned this pull request Nov 15, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Nov 15, 2018 •
edited
Loading

Automation for azure-sdk-for-ruby

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-ruby#1871

@azuresdkci
Copy link
Contributor

azuresdkci commented Nov 15, 2018

Can one of the admins verify this patch?

@AutorestCI AutorestCI mentioned this pull request Nov 15, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Nov 15, 2018 •
edited
Loading

Automation for azure-sdk-for-js

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-js#570

@AutorestCI
Copy link

AutorestCI commented Nov 15, 2018 •
edited
Loading

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@AutorestCI AutorestCI mentioned this pull request Nov 15, 2018
Closed
@AutorestCI
Copy link

AutorestCI commented Nov 15, 2018 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#3389

@AutorestCI AutorestCI mentioned this pull request Nov 15, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Nov 15, 2018 •
edited
Loading

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#4181

@AutorestCI AutorestCI mentioned this pull request Nov 18, 2018
Merged
@bashahee
Copy link
Contributor Author

bashahee commented Nov 19, 2018

@jaredmoo can you please review?

jaredmoo
jaredmoo suggested changes Nov 19, 2018
View reviewed changes
Copy link
Contributor

@jaredmoo jaredmoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are discussing this API offline, please do not merge for now.

@bashahee bashahee changed the title Add sensitivityLabels.json to readme.md Update sensitivityLabels.json Nov 19, 2018
@bashahee
Copy link
Contributor Author

bashahee commented Nov 19, 2018

@jaredmoo PR was updated

@sarangan12 sarangan12 merged commit 3c8a16b into Azure:master Nov 24, 2018
mccleanp pushed a commit that referenced this pull request Mar 23, 2022
@banggaurav
resolving correctness error in private branch (#4479)
f334fbe 
* resolving correctness error in private branch

* go sdk error fix

Co-authored-by: Gaurav Bang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@jaredmoo jaredmoo jaredmoo requested changes

@sarangan12 sarangan12 sarangan12 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@sarangan12 sarangan12

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@bashahee @AutorestCI @azuresdkci @sarangan12 @jaredmoo