Add initial set for changes for ANT79 by naveedaz · Pull Request #4435 · Azure/azure-rest-api-specs

naveedaz · 2018-11-08T23:13:52Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

openapi-portal-comment · 2018-11-08T23:13:53Z

If you're a MSFT employee, click this link
to view this PR's validation status on our new OpenAPI Hub spec management tool.

azuresdkci · 2018-11-08T23:15:44Z

Can one of the admins verify this patch?

AutorestCI · 2018-11-08T23:16:29Z

Automation for azure-sdk-for-python

A PR has been created for you:
Azure/azure-sdk-for-python#3764

AutorestCI · 2018-11-08T23:17:07Z

Automation for azure-sdk-for-ruby

A PR has been created for you:
Azure/azure-sdk-for-ruby#1885

AutorestCI · 2018-11-08T23:19:06Z

Automation for azure-sdk-for-js

A PR has been created for you:
Azure/azure-sdk-for-js#455

dsgouda

Please rearrange the changes so that the diff is accurate and easier to review

AutorestCI · 2018-11-08T23:25:36Z

Automation for azure-sdk-for-go

A PR has been created for you:
Azure/azure-sdk-for-go#3267

AutorestCI · 2018-11-08T23:46:51Z

Automation for azure-sdk-for-node

A PR has been created for you:
Azure/azure-sdk-for-node#4064

AutorestCI · 2018-11-08T23:50:11Z

Automation for azure-sdk-for-java

A PR has been created for you:
Azure/azure-sdk-for-java#2581

naveedaz · 2018-11-09T07:55:30Z

@dsgouda We auto-generate the swagger files. For now I have re-arranged it. I'll look into whether we can maintain this order while generating for future PRs.
Please review these changes.

dsgouda · 2018-11-09T17:11:44Z

Thanks @naveedaz

dsgouda

Left a few comments

dsgouda · 2018-11-09T17:12:38Z

specification/web/resource-manager/Microsoft.Web/stable/2018-02-01/CommonDefinitions.json

            "type": "string"
          }
+        },
+        "supportCredentials": {


Why are these changes being made to an existing stable version?

Changes to stable released versions must be approved by ARM

These changes are additive. We do not want to release a new API-version for small non-breaking changes.

Yes, missed that. Since these are additive changes I would guess these are not breaking changes.

dsgouda · 2018-11-09T17:18:39Z

specification/web/resource-manager/Microsoft.Web/stable/2018-02-01/WebApps.json

      }
    },
-    "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Web/sites/{name}/config/virtualNetwork": {
+    "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Web/sites/{name}/networkConfig/virtualNetwork": {


This may be beyond the scope of this PR, but this spec has a few operations that define 404 error status codes explicitly. AutoRest does not support these today (we have an experimental extension to handle this if you really need it). Please remove these error status codes (or apply the extension) and regenerate the SDKs

@dsgouda Thanks for calling out the 404 status codes. I will talk to the feature owners to figure out if we should remove the status codes or use the experimental extension. We will change that as a new PR.
Please share the link to the extension, I could not find it on https://github.com/Azure/autorest/blob/master/docs/extensions/readme.md

Are you good with all the other changes? If so, please approve.

Here is a brief explanation

dsgouda

LGTM

* Add initial set for changes for ANT79 (#4435) * Add initial set for changes for ANT79 * Fix ordering of swift VNET APIs * Add GeoRegion to DeletedSite Model (#4453)

* Add initial set for changes for ANT79 (Azure#4435) * Add initial set for changes for ANT79 * Fix ordering of swift VNET APIs * Add GeoRegion to DeletedSite Model (Azure#4453)

Add initial set for changes for ANT79

4430795

azuresdkci assigned dsgouda Nov 8, 2018

azuresdkci requested a review from dsgouda November 8, 2018 23:14

AutorestCI mentioned this pull request Nov 8, 2018

[AutoPR web/resource-manager] Add initial set for changes for ANT79 Azure/azure-sdk-for-python#3764

Merged

AutorestCI mentioned this pull request Nov 8, 2018

[AutoPR web/resource-manager] Add initial set for changes for ANT79 Azure/azure-sdk-for-ruby#1885

Merged

AutorestCI mentioned this pull request Nov 8, 2018

[AutoPR web/resource-manager] Add initial set for changes for ANT79 Azure/azure-sdk-for-js#455

Merged

dsgouda suggested changes Nov 8, 2018

View reviewed changes

dsgouda added the Changes Required label Nov 8, 2018

AutorestCI mentioned this pull request Nov 8, 2018

[AutoPR web/resource-manager] Add initial set for changes for ANT79 Azure/azure-sdk-for-go#3267

Merged

Fix ordering of swift VNET APIs

0091bef

AutorestCI mentioned this pull request Nov 8, 2018

[AutoPR web/resource-manager] Add initial set for changes for ANT79 Azure/azure-sdk-for-node#4064

Merged

AutorestCI mentioned this pull request Nov 8, 2018

[AutoPR web/resource-manager] Add initial set for changes for ANT79 Azure/azure-sdk-for-java#2581

Merged

dsgouda suggested changes Nov 9, 2018

View reviewed changes

dsgouda added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Nov 9, 2018

dsgouda approved these changes Nov 9, 2018

View reviewed changes

dsgouda removed the Changes Required label Nov 9, 2018

dsgouda merged commit 586159e into Azure:dev-web-Microsoft.Web-ANT79 Nov 9, 2018

Conversation

naveedaz commented Nov 8, 2018

Latest improvements:

Contribution checklist:

Uh oh!

openapi-portal-comment bot commented Nov 8, 2018

Uh oh!

azuresdkci commented Nov 8, 2018

Uh oh!

AutorestCI commented Nov 8, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-python

Uh oh!

AutorestCI commented Nov 8, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-ruby

Uh oh!

AutorestCI commented Nov 8, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-js

Uh oh!

dsgouda left a comment

Choose a reason for hiding this comment

Uh oh!

AutorestCI commented Nov 8, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-go

Uh oh!

AutorestCI commented Nov 8, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-node

Uh oh!

AutorestCI commented Nov 8, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-java

Uh oh!

naveedaz commented Nov 9, 2018

Uh oh!

dsgouda commented Nov 9, 2018

Uh oh!

dsgouda left a comment

Choose a reason for hiding this comment

Uh oh!

dsgouda Nov 9, 2018

Choose a reason for hiding this comment

Uh oh!

dsgouda Nov 9, 2018

Choose a reason for hiding this comment

Uh oh!

naveedaz Nov 9, 2018

Choose a reason for hiding this comment

Uh oh!

dsgouda Nov 9, 2018

Choose a reason for hiding this comment

Uh oh!

dsgouda Nov 9, 2018

Choose a reason for hiding this comment

Uh oh!

naveedaz Nov 9, 2018

Choose a reason for hiding this comment

Uh oh!

dsgouda Nov 9, 2018

Choose a reason for hiding this comment

Uh oh!

dsgouda left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

AutorestCI commented Nov 8, 2018 •

edited

Loading

AutorestCI commented Nov 8, 2018 •

edited

Loading

AutorestCI commented Nov 8, 2018 •

edited

Loading

AutorestCI commented Nov 8, 2018 •

edited

Loading

AutorestCI commented Nov 8, 2018 •

edited

Loading

AutorestCI commented Nov 8, 2018 •

edited

Loading