update swagger for ANT79 milestone by suwatch · Pull Request #4410 · Azure/azure-rest-api-specs

suwatch · 2018-11-06T23:31:52Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

AutorestCI · 2018-11-06T23:34:06Z

Automation for azure-sdk-for-ruby

Encountered an unknown error: (azure-sdk-for-ruby)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout 40d336ac7c28d7c4063355f8f815b98c8d7c598f
  stderr: 'fatal: reference is not a tree: 40d336ac7c28d7c4063355f8f815b98c8d7c598f'

AutorestCI · 2018-11-06T23:34:14Z

Automation for azure-sdk-for-python

Encountered an unknown error: (azure-sdk-for-python)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout 40d336ac7c28d7c4063355f8f815b98c8d7c598f
  stderr: 'fatal: reference is not a tree: 40d336ac7c28d7c4063355f8f815b98c8d7c598f'

azuresdkci · 2018-11-06T23:35:16Z

Can one of the admins verify this patch?

AutorestCI · 2018-11-06T23:37:11Z

Automation for azure-sdk-for-js

Encountered an unknown error: (azure-sdk-for-js)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout 40d336ac7c28d7c4063355f8f815b98c8d7c598f
  stderr: 'fatal: reference is not a tree: 40d336ac7c28d7c4063355f8f815b98c8d7c598f'

AutorestCI · 2018-11-06T23:43:18Z

Automation for azure-sdk-for-go

Encountered an unknown error: (azure-sdk-for-go)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout 40d336ac7c28d7c4063355f8f815b98c8d7c598f
  stderr: 'fatal: reference is not a tree: 40d336ac7c28d7c4063355f8f815b98c8d7c598f'

annatisch · 2018-11-06T23:45:24Z

Hi @suwatch - this PR appears to be additions to a stable API version without incrementing the version?

Or are these simply omissions in the original swagger spec that are being corrected?

AutorestCI · 2018-11-07T00:01:39Z

Automation for azure-sdk-for-java

Encountered an unknown error: (azure-sdk-for-java)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout 40d336ac7c28d7c4063355f8f815b98c8d7c598f
  stderr: 'fatal: reference is not a tree: 40d336ac7c28d7c4063355f8f815b98c8d7c598f'

AutorestCI · 2018-11-07T00:16:32Z

Automation for azure-sdk-for-node

Encountered an unknown error: (azure-sdk-for-node)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout 40d336ac7c28d7c4063355f8f815b98c8d7c598f
  stderr: 'fatal: reference is not a tree: 40d336ac7c28d7c4063355f8f815b98c8d7c598f'

suwatch · 2018-11-07T08:17:56Z

Hi @suwatch - this PR appears to be additions to a stable API version without incrementing the version?

Or are these simply omissions in the original swagger spec that are being corrected?

@annatisch the nature of the change is simply additional optional properties and apis. Properties wise, they all are optional meaning non breaking change with the current api-version or existing CLI. Hence, we don't bump up the api-version.

annatisch · 2018-11-07T15:28:00Z

Thanks for the clarification @suwatch - however this is still not good practice.
We generate SDKs in 7 different languages based on the spec - each of which handles optional properties, method signatures and models in different ways - so it's not as simple as saying whether an additional property is "breaking" or not.
Have these changes already been deployed?

suwatch · 2018-11-07T17:39:02Z

@annatisch thanks for the comment. concerning best practices and new optional properties, let take this discussion aside since this has been our team's common practice - our team guideline is always new version if breaking change. We may need to adjust if that is required.

Have these changes already been deployed?

Not yet but coming in 2-3 weeks. If you need production to be ready before this is merging, I understand. BTW, I assume what is supposed to happen is we should have a different branch for upcoming (not using master which represents the current functional state).

annatisch · 2018-11-07T17:44:10Z

Thanks @suwatch - indeed we will not merge the spec until the service is deployed.
In this case we simply tag the PR as do not merge and wait on your team to confirm whether it's ready to go.

annatisch · 2018-11-07T17:50:17Z

Additionally - if you could please resolve the semantic validation errors:

 error : 
code: DUPLICATE_OPERATIONID
message: >-
  Cannot have multiple operations with the same operationId:
  WebApps_GetSwiftVirtualNetworkConnection
path:
  - get
  - operationId
jsonUrl: >-
  specification/web/resource-manager/Microsoft.Web/stable/2018-02-01/WebApps.json

 error : 
code: DUPLICATE_OPERATIONID
message: >-
  Cannot have multiple operations with the same operationId:
  WebApps_CreateOrUpdateSwiftVirtualNetworkConnection
path:
  - put
  - operationId
jsonUrl: >-
  specification/web/resource-manager/Microsoft.Web/stable/2018-02-01/WebApps.json

 error : 
code: DUPLICATE_OPERATIONID
message: >-
  Cannot have multiple operations with the same operationId:
  WebApps_DeleteSwiftVirtualNetwork
path:
  - delete
  - operationId
jsonUrl: >-
  specification/web/resource-manager/Microsoft.Web/stable/2018-02-01/WebApps.json

 error : 
code: DUPLICATE_OPERATIONID
message: >-
  Cannot have multiple operations with the same operationId:
  WebApps_UpdateSwiftVirtualNetworkConnection
path:
  - patch
  - operationId
jsonUrl: >-
  specification/web/resource-manager/Microsoft.Web/stable/2018-02-01/WebApps.json

 error : 
code: DUPLICATE_OPERATIONID
message: >-
  Cannot have multiple operations with the same operationId:
  WebApps_GetSwiftVirtualNetworkConnectionSlot
path:
  - get
  - operationId
jsonUrl: >-
  specification/web/resource-manager/Microsoft.Web/stable/2018-02-01/WebApps.json

 error : 
code: DUPLICATE_OPERATIONID
message: >-
  Cannot have multiple operations with the same operationId:
  WebApps_CreateOrUpdateSwiftVirtualNetworkConnectionSlot
path:
  - put
  - operationId
jsonUrl: >-
  specification/web/resource-manager/Microsoft.Web/stable/2018-02-01/WebApps.json

 error : 
code: DUPLICATE_OPERATIONID
message: >-
  Cannot have multiple operations with the same operationId:
  WebApps_DeleteSwiftVirtualNetworkSlot
path:
  - delete
  - operationId
jsonUrl: >-
  specification/web/resource-manager/Microsoft.Web/stable/2018-02-01/WebApps.json

 error : 
code: DUPLICATE_OPERATIONID
message: >-
  Cannot have multiple operations with the same operationId:
  WebApps_UpdateSwiftVirtualNetworkConnectionSlot
path:
  - patch
  - operationId
jsonUrl: >-
  specification/web/resource-manager/Microsoft.Web/stable/2018-02-01/WebApps.json

There are also a number of model validation errors:
https://travis-ci.org/Azure/azure-rest-api-specs/jobs/451637719

suwatch · 2018-11-07T18:15:50Z

Additionally - if you could please resolve the semantic validation errors:

 error : 
code: DUPLICATE_OPERATIONID
message: >-
  Cannot have multiple operations with the same operationId:
  WebApps_GetSwiftVirtualNetworkConnection
path:
  - get
  - operationId
jsonUrl: >-
  specification/web/resource-manager/Microsoft.Web/stable/2018-02-01/WebApps.json

 error : 
code: DUPLICATE_OPERATIONID
message: >-
  Cannot have multiple operations with the same operationId:
  WebApps_CreateOrUpdateSwiftVirtualNetworkConnection
path:
  - put
  - operationId
jsonUrl: >-
  specification/web/resource-manager/Microsoft.Web/stable/2018-02-01/WebApps.json

 error : 
code: DUPLICATE_OPERATIONID
message: >-
  Cannot have multiple operations with the same operationId:
  WebApps_DeleteSwiftVirtualNetwork
path:
  - delete
  - operationId
jsonUrl: >-
  specification/web/resource-manager/Microsoft.Web/stable/2018-02-01/WebApps.json

 error : 
code: DUPLICATE_OPERATIONID
message: >-
  Cannot have multiple operations with the same operationId:
  WebApps_UpdateSwiftVirtualNetworkConnection
path:
  - patch
  - operationId
jsonUrl: >-
  specification/web/resource-manager/Microsoft.Web/stable/2018-02-01/WebApps.json

 error : 
code: DUPLICATE_OPERATIONID
message: >-
  Cannot have multiple operations with the same operationId:
  WebApps_GetSwiftVirtualNetworkConnectionSlot
path:
  - get
  - operationId
jsonUrl: >-
  specification/web/resource-manager/Microsoft.Web/stable/2018-02-01/WebApps.json

 error : 
code: DUPLICATE_OPERATIONID
message: >-
  Cannot have multiple operations with the same operationId:
  WebApps_CreateOrUpdateSwiftVirtualNetworkConnectionSlot
path:
  - put
  - operationId
jsonUrl: >-
  specification/web/resource-manager/Microsoft.Web/stable/2018-02-01/WebApps.json

 error : 
code: DUPLICATE_OPERATIONID
message: >-
  Cannot have multiple operations with the same operationId:
  WebApps_DeleteSwiftVirtualNetworkSlot
path:
  - delete
  - operationId
jsonUrl: >-
  specification/web/resource-manager/Microsoft.Web/stable/2018-02-01/WebApps.json

 error : 
code: DUPLICATE_OPERATIONID
message: >-
  Cannot have multiple operations with the same operationId:
  WebApps_UpdateSwiftVirtualNetworkConnectionSlot
path:
  - patch
  - operationId
jsonUrl: >-
  specification/web/resource-manager/Microsoft.Web/stable/2018-02-01/WebApps.json

There are also a number of model validation errors:
https://travis-ci.org/Azure/azure-rest-api-specs/jobs/451637719

@naveedaz this is generated automatically by tool. could you help investigate whether the tooling issue or we have to fix the api?

ravbhatnagar · 2018-11-12T19:03:15Z

specification/web/resource-manager/Microsoft.Web/stable/2018-02-01/WebApps.json

        }
      }
    },
+    "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Web/sites/{name}/networkConfig/virtualNetwork": {


Is networkConfig a singleton? not sure if virtualNetwork is a resourceType or an instance of networkConfig? To close on this quicker, please feel free to set up a review with armapireview.

ravbhatnagar · 2018-11-12T19:05:33Z

specification/web/resource-manager/Microsoft.Web/stable/2018-02-01/CommonDefinitions.json

+            "$ref": "#/definitions/IpSecurityRestriction"
+          }
+        },
+        "scmIpSecurityRestrictionsUseMain": {


bools are typically not recommended since they are less descriptive and dont allow for future expansion of values in case its needed.

@suwatch - Any response on this comment?

ravbhatnagar · 2018-11-12T19:06:09Z

specification/web/resource-manager/Microsoft.Web/stable/2018-02-01/WebApps.json

+            "$ref": "#/parameters/apiVersionParameter"
+          }
+        ],
+        "responses": {


The newly added models like swiftVirtualNetwork are not showing up in this PR?

update swagger for ANT79 milestone

c20fca3

azuresdkci assigned annatisch Nov 6, 2018

azuresdkci requested a review from annatisch November 6, 2018 23:32

AutorestCI mentioned this pull request Nov 6, 2018

[AutoPR web/resource-manager] update swagger for ANT79 milestone Azure/azure-sdk-for-ruby#1872

Closed

AutorestCI mentioned this pull request Nov 6, 2018

[AutoPR web/resource-manager] update swagger for ANT79 milestone Azure/azure-sdk-for-python#3751

Closed

AutorestCI mentioned this pull request Nov 6, 2018

[AutoPR web/resource-manager] update swagger for ANT79 milestone Azure/azure-sdk-for-js#421

Closed

AutorestCI mentioned this pull request Nov 6, 2018

[AutoPR web/resource-manager] update swagger for ANT79 milestone Azure/azure-sdk-for-go#3249

Closed

annatisch added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Nov 6, 2018

AutorestCI mentioned this pull request Nov 7, 2018

[AutoPR web/resource-manager] update swagger for ANT79 milestone Azure/azure-sdk-for-java#2571

Closed

AutorestCI mentioned this pull request Nov 7, 2018

[AutoPR web/resource-manager] update swagger for ANT79 milestone Azure/azure-sdk-for-node#4040

Closed

annatisch added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Nov 7, 2018

ravbhatnagar reviewed Nov 12, 2018

View reviewed changes

ravbhatnagar added ARMReviewInProgress labels Nov 12, 2018

annatisch added the Reassign label Nov 28, 2018

azuresdkci removed the Reassign label Nov 28, 2018

azuresdkci assigned amarzavery and unassigned annatisch Nov 28, 2018

azuresdkci requested a review from amarzavery November 28, 2018 19:07

annatisch removed their request for review November 28, 2018 20:13

amarzavery assigned anuchandy and unassigned amarzavery Jan 2, 2019

naveedaz closed this Feb 7, 2019

Conversation

suwatch commented Nov 6, 2018

Latest improvements:

Contribution checklist:

Uh oh!

AutorestCI commented Nov 6, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-ruby

Uh oh!

AutorestCI commented Nov 6, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-python

Uh oh!

azuresdkci commented Nov 6, 2018

Uh oh!

AutorestCI commented Nov 6, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-js

Uh oh!

AutorestCI commented Nov 6, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-go

Uh oh!

annatisch commented Nov 6, 2018

Uh oh!

AutorestCI commented Nov 7, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-java

Uh oh!

AutorestCI commented Nov 7, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-node

Uh oh!

suwatch commented Nov 7, 2018

Uh oh!

annatisch commented Nov 7, 2018

Uh oh!

suwatch commented Nov 7, 2018

Uh oh!

annatisch commented Nov 7, 2018

Uh oh!

annatisch commented Nov 7, 2018

Uh oh!

suwatch commented Nov 7, 2018

Uh oh!

ravbhatnagar Nov 12, 2018

Choose a reason for hiding this comment

Uh oh!

ravbhatnagar Nov 12, 2018

Choose a reason for hiding this comment

Uh oh!

amarzavery Dec 4, 2018

Choose a reason for hiding this comment

Uh oh!

ravbhatnagar Nov 12, 2018

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

AutorestCI commented Nov 6, 2018 •

edited

Loading

AutorestCI commented Nov 6, 2018 •

edited

Loading

AutorestCI commented Nov 6, 2018 •

edited

Loading

AutorestCI commented Nov 6, 2018 •

edited

Loading

AutorestCI commented Nov 7, 2018 •

edited

Loading

AutorestCI commented Nov 7, 2018 •

edited

Loading