Move version 2018-01-01 to stable folder #4384
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@jhendrixMSFT FYI for Go SDK |
Automation for azure-sdk-for-javaNothing to generate for azure-sdk-for-java |
Automation for azure-sdk-for-pythonNothing to generate for azure-sdk-for-python |
Contributor
|
Can one of the admins verify this patch? |
Automation for azure-sdk-for-rubyThe initial PR has been merged into your service PR: |
jhendrixMSFT
reviewed
Nov 2, 2018
| @@ -35,7 +35,7 @@ These settings apply only when `--tag=package-2018-01 --go` is specified on the | |||
| Please also specify `--go-sdk-folder=<path to the root directory of your azure-sdk-for-go clone>`. | |||
|
|
|||
| ``` yaml $(tag) == 'package-2018-01' && $(go) | |||
| output-folder: $(go-sdk-folder)/services/preview/$(namespace)/mgmt/2018-01-01/$(namespace) | |||
| output-folder: $(go-sdk-folder)/services/stable/$(namespace)/mgmt/2018-01-01/$(namespace) | |||
Member
There was a problem hiding this comment.
Removing preview is sufficient as all packages not under preview are considered stable.
Automation for azure-sdk-for-jsThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-goThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-nodeNothing to generate for azure-sdk-for-node |
annatisch
approved these changes
Nov 2, 2018
Member
annatisch
left a comment
annatisch
left a comment
There was a problem hiding this comment.
LGTM - I can merge once you have addressed @jhendrixMSFT's comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-versionin the path should match theapi-versionin the spec).Quality of Swagger