[DataFactory]Add sensitive fields extracted from connection string in swagger for AKV reference #4375

boxiao-o · 2018-11-01T07:30:04Z

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

…akv reference

azuresdkci · 2018-11-01T07:30:20Z

Can one of the admins verify this patch?

AutorestCI · 2018-11-01T07:30:30Z

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

AutorestCI · 2018-11-01T07:31:45Z

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2293

AutorestCI · 2018-11-01T07:49:47Z

Automation for azure-sdk-for-js

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-js#411

AutorestCI · 2018-11-01T07:52:58Z

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#2136

AutorestCI · 2018-11-01T07:57:49Z

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#3244

AutorestCI · 2018-11-01T08:01:23Z

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#4031

jhendrixMSFT

Can you please update the affected examples with the new fields?

boxiao-o · 2018-11-02T02:56:29Z

@jhendrixMSFT May I know which file to update? If LinkedServices_Create.json in examples folder, those fields I added is optional and will only be used in some special cases, so may not need to be added there.

…AzureKeyVaultSecretReference, same with connection string.

jhendrixMSFT · 2018-11-02T16:13:58Z

@boxiao-o If these fields are optional then perhaps it makes more sense to add a new example that uses them?

hvermis · 2018-11-02T22:12:17Z

...tory/resource-manager/Microsoft.DataFactory/stable/2018-06-01/entityTypes/LinkedService.json

          "description": "An ODBC connection string. Type: string, SecureString or AzureKeyVaultSecretReference.",
          "type": "object"
        },
+        "pwd": {


Why is this one named pwd while others password?

The property name needs to be same with the name in connection string. In this Netezza linked service case, a typical connection string is Server=<server>;Port=<port>;Database=<database>;UID=<user name>;PWD=<password>.

hvermis · 2018-11-02T22:13:56Z

...tory/resource-manager/Microsoft.DataFactory/stable/2018-06-01/entityTypes/LinkedService.json

          "description": "An ODBC connection string. Type: string, SecureString or AzureKeyVaultSecretReference.",
          "type": "object"
        },
+        "credString": {


Here too, please use full words in names

Same here. This field will be back-filled into connection string, so the name should be the same.

boxiao-o · 2018-11-05T02:49:02Z

@jhendrixMSFT Seems based on our convention, we usually do not update example here, but I will update the examples in sdk JsonSamples

jhendrixMSFT · 2018-11-05T17:32:26Z

@boxiao-o I'm not sure what you mean by "based on our convention". The example files are used to generate documentation so if you want these fields doc'ed you should add an example for them.

Add sensitive fields extracted from connection string in swagger for …

5e66be9

…akv reference

azuresdkci assigned jhendrixMSFT Nov 1, 2018

azuresdkci requested a review from jhendrixMSFT November 1, 2018 07:31

AutorestCI mentioned this pull request Nov 1, 2018

[AutoPR datafactory/resource-manager] [DataFactory]Add sensitive fields extracted from connection string in swagger for AKV reference Azure/azure-sdk-for-python#3730

Merged

AutorestCI mentioned this pull request Nov 1, 2018

[AutoPR datafactory/resource-manager] [DataFactory]Add sensitive fields extracted from connection string in swagger for AKV reference Azure/azure-sdk-for-js#376

Merged

AutorestCI mentioned this pull request Nov 1, 2018

[AutoPR datafactory/resource-manager] [DataFactory]Add sensitive fields extracted from connection string in swagger for AKV reference Azure/azure-sdk-for-java#2556

Merged

AutorestCI mentioned this pull request Nov 1, 2018

[AutoPR datafactory/resource-manager] [DataFactory]Add sensitive fields extracted from connection string in swagger for AKV reference Azure/azure-sdk-for-go#3198

Closed

AutorestCI mentioned this pull request Nov 1, 2018

[AutoPR datafactory/resource-manager] [DataFactory]Add sensitive fields extracted from connection string in swagger for AKV reference Azure/azure-sdk-for-node#4001

Merged

jhendrixMSFT requested changes Nov 1, 2018

View reviewed changes

Change sasUri type to object as it supports string, SecureString and …

f0f730d

…AzureKeyVaultSecretReference, same with connection string.

AutorestCI mentioned this pull request Nov 2, 2018

[AutoPR datafactory/resource-manager] [DataFactory]Add sensitive fields extracted from connection string in swagger for AKV reference Azure/azure-sdk-for-go#3209

Merged

hvermis reviewed Nov 2, 2018

View reviewed changes

jhendrixMSFT approved these changes Nov 6, 2018

View reviewed changes

jhendrixMSFT merged commit 3869689 into Azure:master Nov 6, 2018

[DataFactory]Add sensitive fields extracted from connection string in swagger for AKV reference #4375

[DataFactory]Add sensitive fields extracted from connection string in swagger for AKV reference #4375

Uh oh!

Conversation

boxiao-o commented Nov 1, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR information

Quality of Swagger

Uh oh!

azuresdkci commented Nov 1, 2018

Uh oh!

AutorestCI commented Nov 1, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-ruby

Uh oh!

AutorestCI commented Nov 1, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-python

Uh oh!

AutorestCI commented Nov 1, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-js

Uh oh!

AutorestCI commented Nov 1, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-java

Uh oh!

AutorestCI commented Nov 1, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-go

Uh oh!

AutorestCI commented Nov 1, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-node

Uh oh!

jhendrixMSFT left a comment

Choose a reason for hiding this comment

Uh oh!

boxiao-o commented Nov 2, 2018

Uh oh!

jhendrixMSFT commented Nov 2, 2018

Uh oh!

hvermis Nov 2, 2018

Choose a reason for hiding this comment

Uh oh!

boxiao-o Nov 5, 2018

Choose a reason for hiding this comment

Uh oh!

hvermis Nov 2, 2018

Choose a reason for hiding this comment

Uh oh!

boxiao-o Nov 5, 2018

Choose a reason for hiding this comment

Uh oh!

boxiao-o commented Nov 5, 2018

Uh oh!

jhendrixMSFT commented Nov 5, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

boxiao-o commented Nov 1, 2018 •

edited

Loading

AutorestCI commented Nov 1, 2018 •

edited

Loading

AutorestCI commented Nov 1, 2018 •

edited

Loading

AutorestCI commented Nov 1, 2018 •

edited

Loading

AutorestCI commented Nov 1, 2018 •

edited

Loading

AutorestCI commented Nov 1, 2018 •

edited

Loading

AutorestCI commented Nov 1, 2018 •

edited

Loading