Skip to content

Update openapi-authoring-automated-guidelines.md #4369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
praries880 merged 1 commit into from
Nov 1, 2018
Merged

Update openapi-authoring-automated-guidelines.md #4369

praries880 merged 1 commit into from
Nov 1, 2018

Conversation

@mozehgir
Copy link
Contributor

@mozehgir mozehgir commented Oct 31, 2018

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@AutorestCI
Copy link

AutorestCI commented Oct 31, 2018 •
edited
Loading

Automation for azure-sdk-for-python

Unable to detect any generation context from this PR.

@AutorestCI
Copy link

AutorestCI commented Oct 31, 2018 •
edited
Loading

Automation for azure-sdk-for-go

Unable to detect any generation context from this PR.

@AutorestCI
Copy link

AutorestCI commented Oct 31, 2018 •
edited
Loading

Automation for azure-sdk-for-node

Unable to detect any generation context from this PR.

@AutorestCI
Copy link

AutorestCI commented Oct 31, 2018 •
edited
Loading

Automation for azure-sdk-for-ruby

Unable to detect any generation context from this PR.

@AutorestCI
Copy link

AutorestCI commented Oct 31, 2018 •
edited
Loading

Automation for azure-sdk-for-js

Unable to detect any generation context from this PR.

@AutorestCI
Copy link

AutorestCI commented Oct 31, 2018 •
edited
Loading

Automation for azure-sdk-for-java

Unable to detect any generation context from this PR.

@azuresdkci azuresdkci requested a review from praries880 October 31, 2018 21:27
@azuresdkci
Copy link
Contributor

azuresdkci commented Oct 31, 2018

Can one of the admins verify this patch?

@praries880 praries880 merged commit 6cf0272 into master Nov 1, 2018
@mozehgir mozehgir deleted the mozehgir-patch-1 branch November 9, 2018 02:23
mccleanp pushed a commit that referenced this pull request Mar 23, 2022
@jiandongcui @nickweeds2 @samaddip
[Hub Generated] Review request for Microsoft.MobileNetwork to add ver…
fe047f8 
…sion preview/2021-04-01-preview (#4369)

* [Hub Generated] Review request for Microsoft.MobileNetwork to add version preview/2021-04-01-preview (#4303)

* msazuredev/12524 merge sim and simProfile

* fix duplicated example warning

* Remove spurious mobile network Sims_ListByMobileNetwork operation (#4317)

* Dev mobilenetwork microsoft.mobile network 2021 04 01 preview 6452 (#4329)

* mobile network name pattern after confirmed with Fiona

* iccid, imsi, ki and opc code pattern

* make sim examples comply with patterns

* Update mobileNetwork.json (#4319)

* Update mobileNetwork.json

* Create SimIdListByNetwork.json

* Rename SimIdListByNetwork.json to SimIdListByMobileNetwork.json

Co-authored-by: jiandongcui <[email protected]>

* fix examples for deleted sims field in mobile network

* resolve r2063

* resolve lint error

* resolve more lint error

* prettier fix format

* examples in 2021-04-01 should use api-version 2021-04-01-preview

* Add Go multi-api section

Co-authored-by: nickweeds2 <[email protected]>
Co-authored-by: samaddip <[email protected]>
Co-authored-by: Sathiyan Sivathas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@praries880 praries880 praries880 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@praries880 praries880

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mozehgir @AutorestCI @azuresdkci @praries880