Skip to content

Fix network trace API bugs (Retake) #4363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
annatisch merged 2 commits into from
Nov 1, 2018
Merged

Fix network trace API bugs (Retake) #4363

annatisch merged 2 commits into from
Nov 1, 2018

Conversation

@michimune
Copy link
Contributor

@michimune michimune commented Oct 30, 2018

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@azuresdkci azuresdkci requested a review from annatisch October 30, 2018 23:14
@AutorestCI
Copy link

AutorestCI commented Oct 30, 2018 •
edited
Loading

Automation for azure-sdk-for-ruby

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-ruby#1802

@AutorestCI AutorestCI mentioned this pull request Oct 30, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Oct 30, 2018 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#3312

@azuresdkci
Copy link
Contributor

azuresdkci commented Oct 30, 2018

Can one of the admins verify this patch?

@AutorestCI AutorestCI mentioned this pull request Oct 30, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Oct 30, 2018 •
edited
Loading

Automation for azure-sdk-for-js

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-js#380

@AutorestCI AutorestCI mentioned this pull request Oct 30, 2018
Closed
@AutorestCI
Copy link

AutorestCI commented Oct 30, 2018 •
edited
Loading

Automation for azure-sdk-for-go

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-go#3203

@AutorestCI AutorestCI mentioned this pull request Oct 31, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Oct 31, 2018 •
edited
Loading

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#2218

@AutorestCI AutorestCI mentioned this pull request Oct 31, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Oct 31, 2018 •
edited
Loading

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#4005

annatisch
annatisch reviewed Oct 31, 2018
View reviewed changes
Copy link
Member

@annatisch annatisch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of breaking changes that I want to confirm are intentional.

specification/web/resource-manager/Microsoft.Web/stable/2018-02-01/WebApps.json Outdated
"summary": "Gets a named operation for a network trace capturing (or deployment slot, if specified).",
"description": "Gets a named operation for a network trace capturing (or deployment slot, if specified).",
"operationId": "WebApps_GetNetworkTracesSlotV2",
"operationId": "WebApps_GetNetworkTracesV2Slot",
Copy link
Member

@annatisch annatisch Oct 31, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a breaking change that will require a major version bump in any published SDKs - are you sure this is necessary?

Copy link
Contributor Author

@michimune michimune Oct 31, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bug was merged last week, so if no SDKs were published since then, we are fine. Do you know when was the last published date?

Copy link
Contributor Author

@michimune michimune Nov 1, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted the change.

specification/web/resource-manager/Microsoft.Web/stable/2018-02-01/WebApps.json Outdated
"summary": "Gets a named operation for a network trace capturing (or deployment slot, if specified).",
"description": "Gets a named operation for a network trace capturing (or deployment slot, if specified).",
"operationId": "WebApps_GetNetworkTraceOperationSlotV2",
"operationId": "WebApps_GetNetworkTraceOperationV2Slot",
Copy link
Member

@annatisch annatisch Oct 31, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a breaking change that will require a major version bump in any published SDKs - are you sure this is necessary?

Copy link
Contributor Author

@michimune michimune Oct 31, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above.

Copy link
Contributor Author

@michimune michimune Nov 1, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted this change.

Copy link
Contributor Author

@michimune michimune Nov 1, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@annatisch The PR has been updated. Please take a look.

@AutorestCI AutorestCI mentioned this pull request Nov 1, 2018
Merged
annatisch
annatisch approved these changes Nov 1, 2018
View reviewed changes
Copy link
Member

@annatisch annatisch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@annatisch annatisch merged commit 47a559d into Azure:master Nov 1, 2018
@AutorestCI AutorestCI mentioned this pull request Nov 1, 2018
Merged
@michimune
Copy link
Contributor Author

michimune commented Nov 1, 2018

Thank you so much!

@annatisch
Copy link
Member

annatisch commented Nov 1, 2018

Welcome :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@annatisch annatisch annatisch approved these changes

Assignees

@annatisch annatisch

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@michimune @AutorestCI @azuresdkci @annatisch