Skip to content

Add list and get software to GuestConfiguration #4343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hovsepm merged 2 commits into from
Oct 31, 2018
Merged

Add list and get software to GuestConfiguration #4343

hovsepm merged 2 commits into from
Oct 31, 2018

Conversation

@abhinav-ghai
Copy link
Member

@abhinav-ghai abhinav-ghai commented Oct 27, 2018

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@AutorestCI
Copy link

AutorestCI commented Oct 27, 2018 •
edited
Loading

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@AutorestCI
Copy link

AutorestCI commented Oct 27, 2018 •
edited
Loading

Automation for azure-sdk-for-python

Nothing to generate for azure-sdk-for-python

@AutorestCI
Copy link

AutorestCI commented Oct 27, 2018 •
edited
Loading

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI
Copy link

AutorestCI commented Oct 27, 2018 •
edited
Loading

Automation for azure-sdk-for-js

Nothing to generate for azure-sdk-for-js

@AutorestCI
Copy link

AutorestCI commented Oct 27, 2018 •
edited
Loading

Automation for azure-sdk-for-node

Nothing to generate for azure-sdk-for-node

@azuresdkci
Copy link
Contributor

azuresdkci commented Oct 27, 2018

Can one of the admins verify this patch?

@azuresdkci azuresdkci requested a review from hovsepm October 27, 2018 00:15
@AutorestCI
Copy link

AutorestCI commented Oct 27, 2018 •
edited
Loading

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

sourabhguha
sourabhguha reviewed Oct 29, 2018
View reviewed changes
...ce-manager/Microsoft.GuestConfiguration/preview/2018-01-20-preview/examples/getSoftware.json
@@ -0,0 +1,25 @@
{
"parameters": {
"subscriptionId": "mySubscriptionId",
Copy link

@sourabhguha sourabhguha Oct 27, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor: Have a guid for subscriptionId example

...urce-manager/Microsoft.GuestConfiguration/preview/2018-01-20-preview/guestconfiguration.json Outdated
"SoftwareProperties": {
"description": "Properties of the software object.",
"properties": {
"name": {
Copy link

@sourabhguha sourabhguha Oct 27, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are all the properties required?

Copy link
Member Author

@abhinav-ghai abhinav-ghai Oct 31, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the contract we are giving in the View model of user so we have to specify all the properties we plan on exposing.

nitinbps
nitinbps reviewed Oct 30, 2018
View reviewed changes
...urce-manager/Microsoft.GuestConfiguration/preview/2018-01-20-preview/guestconfiguration.json Outdated
}
},
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Compute/virtualMachines/{vmName}/providers/Microsoft.GuestConfiguration/software/{softwareId}": {
"get": {
Copy link

@nitinbps nitinbps Oct 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

get [](start = 7, length = 3)

Would extension resource be cached in the future, please confirm with ARM team? Basically the pattern of exposing only GET without creating actual ARM resource, would that cause any problem. Are there other RP using this pattern?

Copy link
Member Author

@abhinav-ghai abhinav-ghai Oct 31, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I am checking this with some one from ARM team.

@hovsepm
Copy link
Contributor

hovsepm commented Oct 31, 2018

@sourabhguha @AnatoliB @nitinbps please approve this PR when you are done with the review.

nitinbps
nitinbps approved these changes Oct 31, 2018
View reviewed changes
Copy link

@nitinbps nitinbps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@hovsepm hovsepm merged commit d4365e6 into Azure:master Oct 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sourabhguha sourabhguha sourabhguha approved these changes

+3 more reviewers

@hovsepm hovsepm hovsepm approved these changes

@AnatoliB AnatoliB AnatoliB approved these changes

@nitinbps nitinbps nitinbps approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@hovsepm hovsepm

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@abhinav-ghai @AutorestCI @azuresdkci @hovsepm @sourabhguha @AnatoliB @nitinbps