Skip to content

Oct10#4335

Merged
annatisch merged 2 commits intoAzure:masterfrom
juniwang:oct10
Oct 29, 2018
Merged

Oct10#4335
annatisch merged 2 commits intoAzure:masterfrom
juniwang:oct10

Conversation

@juniwang
Copy link
Member

Azure SignalR Service is adding a new api-version 2018-10-01 since we already went GA. However there is no new API comparing to the spec for 2018-03-01-preview. We only changed the version in readme files, spec and examples.

Two commits included. Ther first one copied the files from 2018-03-01-preview. And the second added a api-version.

Quality control:
All validations documented at https://github.com/Azure/adx-documentation-pr/wiki/Azure-Swagger-Tools passed.

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI
Copy link

AutorestCI commented Oct 26, 2018

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#3706

@AutorestCI
Copy link

AutorestCI commented Oct 26, 2018

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#3973

@AutorestCI
Copy link

AutorestCI commented Oct 26, 2018

Automation for azure-sdk-for-js

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-js#339

@AutorestCI
Copy link

AutorestCI commented Oct 26, 2018

Automation for azure-sdk-for-ruby

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-ruby#1813

@AutorestCI
Copy link

AutorestCI commented Oct 26, 2018

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#3159

@AutorestCI
Copy link

AutorestCI commented Oct 26, 2018

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#2154

@annatisch
Copy link
Member

Thanks @juniwang for such a clean PR :)
I can't see any API changes over the preview version - does that sound right?

@juniwang
Copy link
Member Author

Thanks @juniwang for such a clean PR :)
I can't see any API changes over the preview version - does that sound right?

@juniwang
Copy link
Member Author

Sorry. Closed by mistake. @annatisch , It's as expected. What we need is a GA version of our RP/API/SDK.

@annatisch annatisch merged commit 2cebed8 into Azure:master Oct 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants