Service Bus: Revert PR 4245 from 2017

[v-Ajnava]

Note: We have reverted the PR #4245, as there are more service side changes, VNet team wants to standardize there APIs which will changes few VNet and IPFilter rules API. So we are reverting these API from the stable 2017 swagger.

No Clients were published with PR #4245

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

• The title of the PR is clear and informative.
• There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
• Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
• If applicable, the PR references the bug/issue that it fixes.
• Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

• I have read the contribution guidelines.
• My spec meets the review criteria:
  • The spec conforms to the Swagger 2.0 specification.
  • The spec follows the guidelines described in the Swagger checklist document.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.

[azuresdkci]

Can one of the admins verify this patch?

[AutorestCI]

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#3633

[AutorestCI]

Automation for azure-sdk-for-js

Nothing to generate for azure-sdk-for-js

[AutorestCI]

Automation for azure-sdk-for-ruby

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-ruby#1782

[AutorestCI]

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#3160

[AutorestCI]

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#3974

[annatisch]

Hi @v-Ajnava - a couple of questions:

• when PR Service Bus: moved VNet and IpFilter rules from 2018-preview to 2017 API version #4245 was merged it was considered a deployed API version. Does this mean you are pulling down or breaking an existing API version?
• Is there any reason you cannot publish the API changes as a new API version?
• Additionally, are you aware that once the earlier PR was merged and the Go SDK was generated and merged it is already considered published?
• Do you know the status of other auto-generated SDKs like Ruby, NodeJs and Java?

Finally - you will also need to remove all the tags in the readme files that point to this version. This includes the language-specific tags added for those SDKs that support multi-API versions.

[annatisch]

@v-Ajnava - based on the offline email conversation, it sounds like this API version was never deployed.
In this case, please simply remove all the readme tags pointing to this spec.

Thanks!

[v-Ajnava]

@annatisch , the API version 2017 is stable version, the VNet and IPFilter features were not deployed in 2017, but unfortunately by our mistake these were added to 2017 API version swagger and merged.
correct me if I am wrong, the readme will have tags pointing to 2017 API version.

[annatisch]

Thanks @v-Ajnava - I see you're right, I misread the diff.
However the Java CI is still failing - which seem to be related to the readme parameters?

[AutorestCI]

Automation for azure-sdk-for-java

Encountered a Subprocess error: (azure-sdk-for-java)

Command: ['/usr/local/bin/autorest', '/tmp/tmp96chbq8q/rest/specification/servicebus/resource-manager/readme.md', '--azure-libraries-for-java-folder=/tmp/tmp96chbq8q/sdk', '--java', '--multiapi', '--use=@microsoft.azure/autorest.java@preview', '--verbose']
Finished with return code 1
and output:

AutoRest code generation utility [version: 2.0.4283; node: v8.12.0]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@microsoft.azure_autorest-core@2.0.4289/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4289)
   Loading AutoRest extension '@microsoft.azure/autorest.java' (preview->2.1.85)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.38->2.3.38)
Processing batch task - {"tag":"package-2015-08"} .
Processing batch task - {"tag":"package-2017-04"} .
FATAL: System.Exception: Duplicate File Generation: src/main/java/com/microsoft/azure/management/servicebus/v2017_04_01/PremiumMessagingRegions.java
   at AutoRest.Core.CodeGenerator.<Write>d__13.MoveNext() in /home/vsts/work/1/s/autorest.common/src/CodeGenerator.cs:line 151
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at AutoRest.Core.CodeGenerator.<Write>d__12.MoveNext() in /home/vsts/work/1/s/autorest.common/src/CodeGenerator.cs:line 121
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at AutoRest.Java.Azure.Fluent.CodeGeneratorJvaf.<Generate>d__6.MoveNext() in /home/vsts/work/1/s/src/azurefluent/CodeGeneratorJvaf.cs:line 134
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at AutoRest.Java.Program.<ProcessInternal>d__3.MoveNext() in /home/vsts/work/1/s/src/Program.cs:line 114
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()
   at NewPlugin.<Process>d__20.MoveNext() in /home/vsts/work/1/s/autorest.common/src/Plugins/NewPlugin.cs:line 163
FATAL: java/generate - FAILED
FATAL: Error: Plugin java reported failure.
Process() cancelled due to exception : Plugin java reported failure.
Failure during batch task - {"tag":"package-2017-04"} -- Error: Plugin java reported failure..
  Error: Plugin java reported failure.