Add example with nested segmentation, fix number types, remove extraneous `produces` by alexeldeib · Pull Request #4311 · Azure/azure-rest-api-specs

alexeldeib · 2018-10-23T19:04:56Z

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

AutorestCI · 2018-10-23T19:05:33Z

Automation for azure-sdk-for-go

A PR has been created for you:
Azure/azure-sdk-for-go#3181

azuresdkci · 2018-10-23T19:05:33Z

Can one of the admins verify this patch?

AutorestCI · 2018-10-23T19:05:34Z

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

AutorestCI · 2018-10-23T19:05:35Z

Automation for azure-sdk-for-node

A PR has been created for you:
Azure/azure-sdk-for-node#3937

AutorestCI · 2018-10-23T19:05:47Z

Automation for azure-sdk-for-python

A PR has been created for you:
Azure/azure-sdk-for-python#3675

AutorestCI · 2018-10-23T19:06:09Z

Automation for azure-sdk-for-js

A PR has been created for you:
Azure/azure-sdk-for-js#292

annatisch · 2018-10-24T22:15:25Z

Thanks @alexeldeib - are you able to fix the two failing CI passes?
The Go SDK generation is still failing and there's a number of model validation errors:
https://travis-ci.org/Azure/azure-rest-api-specs/jobs/445374245

Thanks!

alexeldeib · 2018-10-25T00:04:39Z

@annatisch Fixed csv formatting for the example, but I have questions about the other issues.

Go SDK. I see: FATAL: System.InvalidOperationException: codegen for preview swagger microsoft.insights/preview/v1/AppInsights.json must be under a preview subdirectory, but the file is under a preview subdirectory? Any insight here?
Model validation is failing with an error that this property doesn't exist, but it's in the swagger? Possibly due to @ in key name?

"message": 
  "Reference could not be resolved: 
    #/definitions/generated.nested.definitions.eventsResult.properties.%40ai.messages",
    "path" : [
      "definitions","eventsResult","properties","@ai.messages","$ref"],
      "error": "JSON Pointer points to missing location: 
      #/definitions/generated.nested.definitions.eventsResult.properties.%40ai.messages"
    ]

alexeldeib · 2018-10-25T00:15:48Z

Still addressing a model validation issue with additionalProperties.

alexeldeib · 2018-10-25T00:21:35Z

Also have a few unchanged XML request/responses which are now failing CI.

The XML is stuffed as a giant string off the response body -- I think when we wrote these examples, this was the only way to incorporate an XML response that worked. Is there a better way to do this?

alexeldeib · 2018-10-30T01:22:04Z

@annatisch thoughts on above?

annatisch · 2018-10-30T18:24:31Z

Hi @marstr - Do you know what would cause this error in the Go generator?

codegen for preview swagger microsoft.insights/preview/v1/AppInsights.json must be under a preview subdirectory

annatisch · 2018-10-30T19:07:01Z

Hi @lmazuel - do you know if there have been changes to how XML data is represented in Swagger examples? Samples like this one are now failing:
https://github.com/Azure/azure-rest-api-specs/blob/master/specification/applicationinsights/data-plane/microsoft.insights/preview/v1/examples/events-get-metadata.json

Error:

operationId: Events_GetOdataMetadata
scenario: eventMetadata
source: response
responseCode: '200'
errorDetails:
  code: INVALID_TYPE
  params:
    - object
    - string
  message: Expected type object but found type string

marstr · 2018-10-30T22:36:57Z

@annatisch says:
Hi @marstr - Do you know what would cause this error in the Go generator?
codegen for preview swagger microsoft.insights/preview/v1/AppInsights.json must be under a preview subdirectory

Ah yeah, the output path configured for the Azure SDK for Go must be in the "services/preview" folder because this spec is in the preview folder in the specs repository.

annatisch · 2018-10-30T22:45:16Z

Thanks @marstr!

Additionally I've confirmed with @sergey-shandar that the model validation errors with regards to XML can be ignored for now.

alexeldeib · 2018-10-30T22:49:03Z

@marstr I think this is due to #3084 creating the preview/stable folders. When the spec was originally introduced, there were no folders to differentiate stable/preview. What's the preferred solution for you? I can update the path here but you'll end up with a redundant version of the SDK in azure-sdk-for-go.

@annatisch thanks for clarifying. I think I covered the other issues with examples, let me know if I missed anything.

e: did fix the Go configuration, so waiting for that to finish.

AutorestCI · 2018-10-30T23:53:25Z

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

* [Nginx] Add certificate API * Fix * Fix 2 * Fix 3

Ace Eldeib added 3 commits October 22, 2018 16:07

add segmented metrics example, minor fixes

6b93c22

add example, return metric get full to previous state

545b89f

remove duplicate file

050672a

AutorestCI mentioned this pull request Oct 23, 2018

[AutoPR applicationinsights/data-plane] Add example with nested segmentation, fix number types, remove extraneous produces Azure/azure-sdk-for-python#3674

Merged

AutorestCI mentioned this pull request Oct 23, 2018

[AutoPR applicationinsights/data-plane] Add example with nested segmentation, fix number types, remove extraneous produces Azure/azure-sdk-for-js#284

Closed

azuresdkci assigned annatisch Oct 23, 2018

azuresdkci requested a review from annatisch October 23, 2018 19:06

Ace Eldeib added 2 commits October 23, 2018 14:10

Fix examples

1b9e17a

fix go object type

ee017b9

fix build issues on parameters

15e15b9

fix go configuration

1dfbab7

AutorestCI mentioned this pull request Oct 30, 2018

[AutoPR operationalinsights/data-plane/applicationinsights/data-plane] Add example with nested segmentation, fix number types, remove extraneous produces Azure/azure-sdk-for-go#3181

Merged

annatisch approved these changes Oct 31, 2018

View reviewed changes

annatisch merged commit 29b57c9 into Azure:master Oct 31, 2018

mccleanp pushed a commit that referenced this pull request Mar 23, 2022

[Nginx] Add certificate API (#4311)

3eb0227

* [Nginx] Add certificate API * Fix * Fix 2 * Fix 3

Comments

Conversation

alexeldeib commented Oct 23, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR information

Quality of Swagger

Uh oh!

AutorestCI commented Oct 23, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-go

Uh oh!

azuresdkci commented Oct 23, 2018

Uh oh!

AutorestCI commented Oct 23, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-ruby

Uh oh!

AutorestCI commented Oct 23, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-node

Uh oh!

AutorestCI commented Oct 23, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-python

Uh oh!

AutorestCI commented Oct 23, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-js

Uh oh!

annatisch commented Oct 24, 2018

Uh oh!

alexeldeib commented Oct 25, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alexeldeib commented Oct 25, 2018

Uh oh!

alexeldeib commented Oct 25, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alexeldeib commented Oct 30, 2018

Uh oh!

annatisch commented Oct 30, 2018

Uh oh!

annatisch commented Oct 30, 2018

Uh oh!

marstr commented Oct 30, 2018

Uh oh!

annatisch commented Oct 30, 2018

Uh oh!

alexeldeib commented Oct 30, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AutorestCI commented Oct 30, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-java

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

alexeldeib commented Oct 23, 2018 •

edited

Loading

AutorestCI commented Oct 23, 2018 •

edited

Loading

AutorestCI commented Oct 23, 2018 •

edited

Loading

AutorestCI commented Oct 23, 2018 •

edited

Loading

AutorestCI commented Oct 23, 2018 •

edited

Loading

AutorestCI commented Oct 23, 2018 •

edited

Loading

alexeldeib commented Oct 25, 2018 •

edited

Loading

alexeldeib commented Oct 25, 2018 •

edited

Loading

alexeldeib commented Oct 30, 2018 •

edited

Loading

AutorestCI commented Oct 30, 2018 •

edited

Loading