Added Reimage API support for ephemeral os disks in single VM #4299

hari-bodicherla · 2018-10-19T23:58:53Z

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- [X ] The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

… Ephemeral VM\VMSS

azuresdkci · 2018-10-20T00:00:28Z

Can one of the admins verify this patch?

AutorestCI · 2018-10-20T00:00:53Z

Automation for azure-sdk-for-js

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-js#295

AutorestCI · 2018-10-20T00:01:23Z

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#3668

AutorestCI · 2018-10-20T00:03:12Z

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#3949

AutorestCI · 2018-10-20T00:06:54Z

Automation for azure-sdk-for-go

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-go#3099

jhendrixMSFT

There are model validation failures for this new operation that need to be fixed, please see the log for details.

jhendrixMSFT · 2018-10-22T16:20:34Z

specification/compute/resource-manager/Microsoft.Compute/stable/2018-06-01/compute.json

            "required": false,
            "schema": {
-              "$ref": "#/definitions/VirtualMachineScaleSetVMInstanceIDs"
+              "$ref": "#/definitions/VirtualMachineScaleSetReimageParameters"


This introduces breaking changes in SDK codegen, is it necessary?

hi, VirtualMachineScaleSetReimageParameters is the wrapper class around the VirtualMachineScaleSetVMInstanceIDs containing new inputs like osdisk, datadisk list of lun values and temp disk reiamge inputs for the customer. This needs to be added

hari-bodicherla · 2018-10-22T19:25:45Z

Hi Joel, I had looked into validation errors but not having any clue why they are failing which are unrelated to my new changes. Could you please let me know if I can do something from my side to fix these

jhendrixMSFT · 2018-10-22T19:29:13Z

If you do a search in the log for the example name, e.g. Reimage a Virtual Machine., you will find the relevant failures. Here's an example.
error : operationId: VirtualMachines_Reimage scenario: Reimage a Virtual Machine. source: request responseCode: ALL severity: 0 errorCode: OBJECT_ADDITIONAL_PROPERTIES errorDetails: code: OBJECT_ADDITIONAL_PROPERTIES params: - - properties - location message: 'Additional properties not allowed: properties,location' path: '' title: /definitions/VirtualMachineReimageParameters description: Paramaters for Reimaging Virtual Machine. position: line: 4917 column: 40 url: >- specification/compute/resource-manager/Microsoft.Compute/stable/2018-06-01/compute.json

AutorestCI · 2018-10-24T00:29:15Z

Automation for azure-sdk-for-ruby

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-ruby#1790

jhendrixMSFT · 2018-10-24T00:47:35Z

...ute/resource-manager/Microsoft.Compute/stable/2018-06-01/examples/ReimageVirtualMachine.json

+    "api-version": "2018-06-01",
+    "vmName": "myVMName",
+    "parameters": {
+      "location": "West US",


This isn't in the schema and is causing one of the model validation failures.

jhendrixMSFT · 2018-10-24T00:48:11Z

...ute/resource-manager/Microsoft.Compute/stable/2018-10-01/examples/ReimageVirtualMachine.json

+    "api-version": "2018-10-01",
+    "vmName": "myVMName",
+    "parameters": {
+      "location": "West US",


This isn't in the schema and is causing one of the model validation failures.

Joel, is location parameter culprit?

Yes I believe so. Note that you can run this validation locally to verify the fix before updating the PR, see the docs here.

Thanks Joel for the tool to validate locally. I had updated the examples and validated it.

However I see there are other validation errors coming for others unrelated to mine

jhendrixMSFT · 2018-10-24T18:48:01Z

@hari-bodicherla while it would be nice to clean up the other failures, since they weren't introduced in this PR it's not necessary. Let me know how you want to proceed.

hari-bodicherla · 2018-10-24T21:33:05Z

Hi Joel, I had cleaned up the other failures too which are unrelated to my changes and sent new iteration . Thanks..

hari-bodicherla added 11 commits September 18, 2018 12:53

Added diffDiskSettings property as part of Swagger changes needed for…

fa03850

… Ephemeral VM\VMSS

updated comment

2f52195

updated swagger specs for diffdisksettings property

3286411

updated swagger spec comments for diff disk settings [property

f8934d4

added example to create Diff OS disk scaleset

6fdc54f

Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs

1adb5e3

updated 2018-10-01 version specs with diffdisk property

474d5b0

added example file for creating VM with diffdisksettings property

59315ed

Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs

4f1e089

Merge remote-tracking branch 'upstream/master'

41e9b0d

updated swagger changes for reimage operation in single vm

80e525c

azuresdkci assigned jhendrixMSFT Oct 19, 2018

azuresdkci requested a review from jhendrixMSFT October 19, 2018 23:59

AutorestCI mentioned this pull request Oct 20, 2018

[AutoPR compute/resource-manager] Added Reimage API support for ephemeral os disks in single VM Azure/azure-sdk-for-node#3921

Merged

AutorestCI mentioned this pull request Oct 20, 2018

[AutoPR compute/resource-manager] Added Reimage API support for ephemeral os disks in single VM Azure/azure-sdk-for-go#3092

Closed

jhendrixMSFT requested changes Oct 22, 2018

View reviewed changes

jhendrixMSFT reviewed Oct 22, 2018

View reviewed changes

jhendrixMSFT added the potential-sdk-breaking-change label Oct 22, 2018

update examples

27378b6

AutorestCI mentioned this pull request Oct 24, 2018

[AutoPR compute/resource-manager] Added Reimage API support for ephemeral os disks in single VM Azure/azure-sdk-for-ruby#1789

Merged

jhendrixMSFT reviewed Oct 24, 2018

View reviewed changes

udpated examples

af7abc6

fixed validation errors

adb0812

jhendrixMSFT approved these changes Oct 24, 2018

View reviewed changes

jhendrixMSFT merged commit a0adc09 into Azure:master Oct 24, 2018

hyonholee mentioned this pull request Dec 4, 2018

[Compute] VM and VMSS reimage API Azure/azure-sdk-for-net#5062

Merged

9 tasks

Added Reimage API support for ephemeral os disks in single VM #4299

Added Reimage API support for ephemeral os disks in single VM #4299

Uh oh!

Conversation

hari-bodicherla commented Oct 19, 2018

PR information

Quality of Swagger

Uh oh!

azuresdkci commented Oct 20, 2018

Uh oh!

AutorestCI commented Oct 20, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-js

Uh oh!

AutorestCI commented Oct 20, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-python

Uh oh!

AutorestCI commented Oct 20, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-node

Uh oh!

AutorestCI commented Oct 20, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-go

Uh oh!

jhendrixMSFT left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hari-bodicherla commented Oct 22, 2018

Uh oh!

jhendrixMSFT commented Oct 22, 2018

Uh oh!

AutorestCI commented Oct 24, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-ruby

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jhendrixMSFT commented Oct 24, 2018

Uh oh!

hari-bodicherla commented Oct 24, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

AutorestCI commented Oct 20, 2018 •

edited

Loading

AutorestCI commented Oct 20, 2018 •

edited

Loading

AutorestCI commented Oct 20, 2018 •

edited

Loading

AutorestCI commented Oct 20, 2018 •

edited

Loading

AutorestCI commented Oct 24, 2018 •

edited

Loading