Skip to content

add armRoleReceiver to ActionGroup API and update API version to 2018-09-01 #4268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sarangan12 merged 2 commits into from
Oct 22, 2018
Merged

add armRoleReceiver to ActionGroup API and update API version to 2018-09-01 #4268

sarangan12 merged 2 commits into from
Oct 22, 2018

Conversation

@RyanD1
Copy link
Contributor

@RyanD1 RyanD1 commented Oct 18, 2018

and update API version to 2018-09-01

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

add armRoleReceiver to ActionGroup API
39d45de 
and update API version to 2018-09-01
@AutorestCI AutorestCI mentioned this pull request Oct 18, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Oct 18, 2018 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2761

@azuresdkci azuresdkci requested a review from sarangan12 October 18, 2018 18:43
@AutorestCI AutorestCI mentioned this pull request Oct 18, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Oct 18, 2018 •
edited
Loading

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#3929

@AutorestCI AutorestCI mentioned this pull request Oct 18, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Oct 18, 2018 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#3104

@azuresdkci
Copy link
Contributor

azuresdkci commented Oct 18, 2018

Can one of the admins verify this patch?

RyanD1
RyanD1 commented Oct 18, 2018
View reviewed changes
...fication/monitor/resource-manager/microsoft.insights/stable/2018-09-01/actionGroups_API.json
"$ref": "#/definitions/ArmRoleReceiver"
},
"description": "The list of arm role receivers that are part of this action group."
}
Copy link
Contributor Author

@RyanD1 RyanD1 Oct 18, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change: adding armRoleReceiver

RyanD1
RyanD1 commented Oct 18, 2018
View reviewed changes
...fication/monitor/resource-manager/microsoft.insights/stable/2018-09-01/actionGroups_API.json
"name",
"roleId"
]
},
Copy link
Contributor Author

@RyanD1 RyanD1 Oct 18, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change: adding armRoleReceiver

RyanD1
RyanD1 commented Oct 18, 2018
View reviewed changes
...esource-manager/microsoft.insights/stable/2018-09-01/examples/createOrUpdateActionGroup.json
"name": "Sample armRole",
"roleId": "8e3af657-a8ff-443c-a75c-2fe8c4bcb635"
}
]
Copy link
Contributor Author

@RyanD1 RyanD1 Oct 18, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change: adding armRoleReceiver

RyanD1
RyanD1 commented Oct 18, 2018
View reviewed changes
...esource-manager/microsoft.insights/stable/2018-09-01/examples/createOrUpdateActionGroup.json
"name": "Sample armRole",
"roleId": "8e3af657-a8ff-443c-a75c-2fe8c4bcb635"
}
]
Copy link
Contributor Author

@RyanD1 RyanD1 Oct 18, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change: adding armRoleReceiver

RyanD1
RyanD1 commented Oct 18, 2018
View reviewed changes
...esource-manager/microsoft.insights/stable/2018-09-01/examples/createOrUpdateActionGroup.json
{
"name": "Sample armRole",
"roleId": "8e3af657-a8ff-443c-a75c-2fe8c4bcb635"
}
Copy link
Contributor Author

@RyanD1 RyanD1 Oct 18, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change: adding armRoleReceiver

@AutorestCI AutorestCI mentioned this pull request Oct 18, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Oct 18, 2018 •
edited
Loading

Automation for azure-sdk-for-js

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-js#274

@RyanD1
Copy link
Contributor Author

RyanD1 commented Oct 18, 2018 •
edited
Loading

@ravbhatnagar Could you help review?
Mostly everything is copied directly from 2018-03-01 API-version which was already approved. We are not introducing a new API, but a new receiver type and updating the API version so the PR may seem conceivably large. I've marked all the changes actually made (diff between 2018-03-01 and 2018-09-01). Please let me know if you have any questions, thanks!

@ravbhatnagar
Copy link
Contributor

ravbhatnagar commented Oct 22, 2018

This PR has added the armroleReceiver type only. PLease update the description to clarify that these are the Azure RBAC roles and only built-in are currently supported. Signing off.

@ravbhatnagar ravbhatnagar added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Oct 22, 2018
@sarangan12 sarangan12 merged commit 007434d into Azure:master Oct 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sarangan12 sarangan12 sarangan12 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@sarangan12 sarangan12

Labels

ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review potential-sdk-breaking-change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@RyanD1 @AutorestCI @azuresdkci @ravbhatnagar @sarangan12