Skip to content

Comments

enableHttpCorrelationHeaders property is added to the Diagnostic entity#4248

Merged
veronicagg merged 1 commit intoAzure:masterfrom
promoisha:gkfeokti_diagnostic_new_property
Oct 23, 2018
Merged

enableHttpCorrelationHeaders property is added to the Diagnostic entity#4248
veronicagg merged 1 commit intoAzure:masterfrom
promoisha:gkfeokti_diagnostic_new_property

Conversation

@promoisha
Copy link
Contributor

@promoisha promoisha commented Oct 16, 2018

Please, do not merge yet.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI
Copy link

AutorestCI commented Oct 16, 2018

Automation for azure-sdk-for-python

Nothing to generate for azure-sdk-for-python

@AutorestCI
Copy link

AutorestCI commented Oct 16, 2018

Automation for azure-sdk-for-js

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-js#294

@AutorestCI
Copy link

AutorestCI commented Oct 16, 2018

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#3116

@AutorestCI
Copy link

AutorestCI commented Oct 16, 2018

Automation for azure-sdk-for-node

Nothing to generate for azure-sdk-for-node

@praries880
Copy link

@azuresdkci add to whitelist

Copy link

@praries880 praries880 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@promoisha promoisha force-pushed the gkfeokti_diagnostic_new_property branch from b2e03ce to 860e637 Compare October 18, 2018 18:44
@praries880
Copy link

@veronicagg Can you help merge this change in? I do not have permissions to merge stuff into the branch.

@promoisha
Copy link
Contributor Author

@praries880 @veronicagg folks, like I mentioned in the description, please, do not merge it yet!

@veronicagg veronicagg changed the title enableHttpCorrelationHeaders property is added to the Diagnostic entity [do-not-merge] enableHttpCorrelationHeaders property is added to the Diagnostic entity Oct 19, 2018
@veronicagg
Copy link
Contributor

@promoisha I've edited the title to indicate that we shouldn't merge yet. thx.

@praries880 praries880 added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Oct 19, 2018
@promoisha promoisha force-pushed the gkfeokti_diagnostic_new_property branch from 860e637 to 3a2eac5 Compare October 19, 2018 21:54
@promoisha promoisha changed the title [do-not-merge] enableHttpCorrelationHeaders property is added to the Diagnostic entity enableHttpCorrelationHeaders property is added to the Diagnostic entity Oct 22, 2018
@promoisha
Copy link
Contributor Author

@veronicagg could you merge the PR now? Thanks! :)

@promoisha
Copy link
Contributor Author

@veronicagg, @praries880 Friendly ping to merge the PR, thanks!

@AutorestCI
Copy link

AutorestCI commented Oct 23, 2018

Automation for azure-sdk-for-ruby

A PR has been created for you:
Azure/azure-sdk-for-ruby#1787

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DoNotMerge <valid label in PR review process> use to hold merge after approval

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants