-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Add RecreatingStandby #41270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Add RecreatingStandby #41270
Changes from 66 commits
Commits
Show all changes
71 commits
Select commit
Hold shift + click to select a range
93a4bff
add RecreatingStandby
nehrao1 39f722c
edit models.tsp
nehrao1 6356122
[copilot-setup-steps.yaml] Skip azure/login on user forks (#41175)
Copilot 010e41d
Sync eng/common directory with azure-sdk-tools for PR 14405 (#41142)
azure-sdk 297e19e
Updated client.tsp file (#41031)
aviranjan24 8635018
java api-version (#41041)
audunn 51797f7
Make the public devOps feed the default registry for npmrc creation. …
azure-sdk 68f245a
[commerce] Update client.tsp (#41185)
ChenxiJiang333 789d2a1
[TSP Migration]Migrate cosmosdb from Swagger to TypeSpec (#37995)
welovej 713282a
[TSP Migration][securityinsights] Migrate Swagger 2025-07-01-preview …
melina5656 5af4574
update JS config for recoveryservices (#40670)
kazrael2119 d8d7d95
Refactor(keyvault): migrate to unified folder structure (#38668)
v-xuto 38882a3
Refactor(compute): migrate to unified folder structure (#39105)
v-xuto 0794113
Refactor(frontdoor): migrate to unified folder structure (#40992)
v-xuto d1432b8
fix(containerregistry): adjust csharp emitter to align with sdk namin…
CodeJourneys 4fdc406
fix(containerregistrytasks): update C# emitter configuration to align…
CodeJourneys 782833a
fix(containerregistrytasks): rename RunRequest to RunContent in C# cl…
CodeJourneys a2bb513
Use create-authenticated-npmrc.yml for npmrc authentication (#41141)
chidozieononiwu 030092f
Sync eng/common directory with azure-sdk-tools for PR 14400 (#41201)
azure-sdk be3af02
Update Monitor Exporter tsp config (#40722)
pvaneck 0dc3253
Add rust to widget example (#41212)
catalinaperalta 05c1891
Review request for Microsoft.ContainerService/aks to add version stab…
FumingZhang bf26b22
Updated powershell emitter config to release 2026-03-15 powershell mo…
aviranjan24 f71415a
MPG migration Spec - RedisEnterprise (#40081)
mzhongl524 a27be6c
Updating the api description for repeating time interval (#40906)
Shashank1306s 25652d3
[TSP Migration]--datafactory (#38941)
welovej d7964f7
MDC: Adding 2025-10-01-preview version to Microsoft.Security/Pricings…
surashed a825e9b
Rhurey/vl specs (#36009)
rhurey a5cbad6
Adding Alerts and Asset Level DQ Apis
Sreeramulu-dev e5a17a7
Add Microsoft.AppLink API specs for 2025-08-01-preview (public previe…
deveshdama f13f1cb
Use both NPM_CONFIG_USERCONFIG and NPM_CONFIG_REGISTRY to give the pi…
azure-sdk a0bc902
Sync eng/common directory with azure-sdk-tools for PR 14253 (#41046)
azure-sdk f198a75
add RecreatingStandby
nehrao1 9844ed7
Feizhao/tts2026 (#40823)
ms-feizhao 7efebba
revert
nehrao1 dbc2d83
Remove unused code (#41273)
azure-sdk 8c89dbe
fix(containerregistrytasks): added C# client naming and type decorato…
CodeJourneys a120f44
fix(containerregistry): added C# client naming for import source for …
CodeJourneys 244bc71
build(deps): bump marked from 17.0.3 to 17.0.4 in /.github (#41278)
dependabot[bot] 3ffb4e9
build(deps): bump marked from 17.0.3 to 17.0.4 in /.github/shared (#4…
dependabot[bot] 67d47ca
Bump tar from 7.5.10 to 7.5.11 in /eng/common/tsp-client (#41233)
azure-sdk 7f65331
build(deps): bump tar from 7.5.10 to 7.5.11 (#41266)
dependabot[bot] e620e30
fix(containerregistrytasks): update flatten properties for .NET SDK c…
CodeJourneys ca36e83
mgmt, java, web, config for typespec (#40742)
weidongxu-microsoft 3527a37
Update TypeSpec config and client.tsp for azure-resourcemanager-searc…
weidongxu-microsoft 0a7b657
Update tspconfig.yaml for TrafficManager Java SDK migration (#41239)
weidongxu-microsoft ac83ad1
bump simple-git to 3.33.0 in package-lock.json files (#41287)
Copilot 102bf94
fix(containerregistrytasks): adjust property naming case and add unit…
CodeJourneys 4ac7057
Api version 2025-12-01 added to mover (#40954)
cptolookfor 7d006d8
[.github] Fix syntax in package.json (#41291)
mikeharder 647e928
cdn, fix java naming (#41246)
weidongxu-microsoft 3128363
[exec.js] Add "prefix" option to execNpm() (#41236)
mikeharder 0db92a1
Fix the enum member order issue in keyvault (#41297)
ArcturusZhang 67ab38b
update (#41243)
welovej 71b59eb
MPG migration - Confluent (#39519)
mzhongl524 1078a06
Add C# mgmt emitter config and clientName decorators for Maps (#41283)
live1206 a6754f7
Fix the customPatch causing JS failure issue in `client.tsp` (#41184)
kazrael2119 3095652
Client Rename nfsV4IDDomain (#41250)
audunn f46c993
Microsoft.NetworkCloud TypeSpec Conversion 2025-09-01, 2026-01-01-pre…
bryan-strassner 59c8fcd
[NetAppFiles] Fix filepath casing, update examples (#41312)
audunn 32dc2a4
Added new stable api spec for ConfidentialLdger. Removed the obsolete…
prathod09 f860256
computeupdatingbyfailover
nehrao1 0f83c6a
fix
nehrao1 16941c8
manual merge
nehrao1 50fb61d
add changes
nehrao1 c8de6e0
Merge branch 'main' into nehrao/recreatingStandby
nehrao1 0bcb278
Merge branch 'main' into nehrao/recreatingStandby
nachoalonsoportillo 1ddfd7d
manual merge
nehrao1 6802194
remove suppressions and add descriptions
nehrao1 24233aa
remove unrelated file
nehrao1 1f76a20
fix typespec validation
nehrao1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
179 changes: 179 additions & 0 deletions
179
specification/redisenterprise/RedisEnterprise.Management/client.tsp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,179 @@ | ||
| import "@azure-tools/typespec-client-generator-core"; | ||
| import "@azure-tools/typespec-azure-resource-manager"; | ||
|
|
||
| import "./main.tsp"; | ||
|
|
||
| using Azure.ClientGenerator.Core; | ||
| using Microsoft.Cache; | ||
|
|
||
| @@clientName(Microsoft.Cache, "RedisEnterpriseManagementClient", "javascript"); | ||
| @@clientName(Microsoft.Cache, "RedisEnterpriseManagementClient", "python"); | ||
|
|
||
| @@clientName(Azure.ResourceManager.CommonTypes.PrivateEndpointConnection, | ||
| "ArmPrivateEndpointConnection", | ||
| "python" | ||
| ); | ||
|
|
||
| // csharp configurations | ||
| @@clientName(AccessKeys, "RedisEnterpriseDataAccessKeys", "csharp"); | ||
| @@clientName(AccessKeyType, "RedisEnterpriseAccessKeyType", "csharp"); | ||
| @@clientName(AofFrequency.OneS, "OneSecond", "csharp"); | ||
| @@clientName(AzureCacheForRedisMigrationProperties.switchDns, | ||
| "IsSwitchDns", | ||
| "csharp" | ||
| ); | ||
| @@clientName(AzureCacheForRedisMigrationProperties.skipDataMigration, | ||
| "IsSkipDataMigration", | ||
| "csharp" | ||
| ); | ||
| @@clientName(AofFrequency, "PersistenceSettingAofFrequency", "csharp"); | ||
| @@clientName(Cluster, "RedisEnterpriseCluster", "csharp"); | ||
| @@clientName(ClusteringPolicy, "RedisEnterpriseClusteringPolicy", "csharp"); | ||
| @@clientName(ClusteringPolicy.OSSCluster, "OssCluster", "csharp"); | ||
| @@clientName(ClusterList, "RedisEnterpriseClusterList", "csharp"); | ||
| @@clientName(ClusterPropertiesEncryptionCustomerManagedKeyEncryption, | ||
| "RedisEnterpriseCustomerManagedKeyEncryption", | ||
| "csharp" | ||
| ); | ||
| @@clientName(ClusterPropertiesEncryptionCustomerManagedKeyEncryptionKeyIdentity, | ||
| "RedisEnterpriseCustomerManagedKeyEncryptionKeyIdentity", | ||
| "csharp" | ||
| ); | ||
| @@clientName(ClusterUpdate, "RedisEnterpriseClusterUpdate", "csharp"); | ||
| @@clientName(CmkIdentityType, | ||
| "RedisEnterpriseCustomerManagedKeyIdentityType", | ||
| "csharp" | ||
| ); | ||
| @@clientName(Database, "RedisEnterpriseDatabase", "csharp"); | ||
| @@clientName(DatabaseList, "RedisEnterpriseDatabaseList", "csharp"); | ||
| @@clientName(DatabasePropertiesGeoReplication, | ||
| "RedisEnterpriseDatabaseGeoReplication", | ||
| "csharp" | ||
| ); | ||
| @@clientName(EvictionPolicy, "RedisEnterpriseEvictionPolicy", "csharp"); | ||
| @@clientName(EvictionPolicy.AllKeysLFU, "AllKeysLfu", "csharp"); | ||
| @@clientName(EvictionPolicy.AllKeysLRU, "AllKeysLru", "csharp"); | ||
| @@clientName(EvictionPolicy.VolatileLRU, "VolatileLfu", "csharp"); | ||
| @@clientName(EvictionPolicy.VolatileLFU, "VolatileLru", "csharp"); | ||
| @@clientName(EvictionPolicy.VolatileTTL, "VolatileTtl", "csharp"); | ||
| @@clientName(ExportClusterParameters, | ||
| "ExportRedisEnterpriseDatabaseContent", | ||
| "csharp" | ||
| ); | ||
| @@clientName(FlushParameters, "FlushRedisEnterpriseDatabaseContent", "csharp"); | ||
| @@clientName(ForceLinkParameters, "ForceLinkContent", "csharp"); | ||
| @@clientName(ForceUnlinkParameters, | ||
| "ForceUnlinkRedisEnterpriseDatabaseContent", | ||
| "csharp" | ||
| ); | ||
| @@clientName(HighAvailability, "RedisEnterpriseHighAvailability", "csharp"); | ||
| @@clientName(ImportClusterParameters, | ||
| "ImportRedisEnterpriseDatabaseContent", | ||
| "csharp" | ||
| ); | ||
| @@clientName(LinkedDatabase, "RedisEnterpriseLinkedDatabase", "csharp"); | ||
| @@clientName(LinkState, "RedisEnterpriseDatabaseLinkState", "csharp"); | ||
| @@clientName(Module, "RedisEnterpriseModule", "csharp"); | ||
| @@clientName(Migration, "RedisEnterpriseMigration", "csharp"); | ||
| @@clientName(MaintenanceDayOfWeek, | ||
| "RedisEnterpriseMaintenanceDayOfWeek", | ||
| "csharp" | ||
| ); | ||
| @@clientName(MaintenanceWindow, "RedisEnterpriseMaintenanceWindow", "csharp"); | ||
| @@clientName(MaintenanceWindowType, | ||
| "RedisEnterpriseMaintenanceWindowType", | ||
| "csharp" | ||
| ); | ||
| @@clientName(MigrationProperties, | ||
| "RedisEnterpriseMigrationProperties", | ||
| "csharp" | ||
| ); | ||
| @@clientName(MigrationProvisioningState, | ||
| "RedisEnterpriseMigrationProvisioningState", | ||
| "csharp" | ||
| ); | ||
| @@clientName(OperationStatus, "RedisEnterpriseOperationStatus", "csharp"); | ||
| @@clientName(OperationStatus.error, "ErrorResponse", "csharp"); | ||
| @@clientName(OperationStatus.startTime, "StartOn", "csharp"); | ||
| @@clientName(OperationStatus.endTime, "EndOn", "csharp"); | ||
| @@clientName(Persistence.aofEnabled, "IsAofEnabled", "csharp"); | ||
| @@clientName(Persistence.rdbEnabled, "IsRdbEnabled", "csharp"); | ||
| @@clientName(Persistence, "RedisPersistenceSettings", "csharp"); | ||
| @@clientName(PrivateEndpointConnection, | ||
| "RedisEnterprisePrivateEndpointConnection", | ||
| "csharp" | ||
| ); | ||
| @@clientName(Azure.ResourceManager.CommonTypes.PrivateEndpointConnectionProperties.privateLinkServiceConnectionState, | ||
| "ConnectionState", | ||
| "csharp" | ||
| ); | ||
| @@clientName(Protocol.Plaintext, "PlainText", "csharp"); | ||
| @@clientName(Protocol, "RedisEnterpriseClientProtocol", "csharp"); | ||
| @@clientName(ProvisioningState, "RedisEnterpriseProvisioningStatus", "csharp"); | ||
| @@clientName(PublicNetworkAccess, | ||
| "RedisEnterprisePublicNetworkAccess", | ||
| "csharp" | ||
| ); | ||
| @@clientName(RdbFrequency.TwelveH, "TwelveHours", "csharp"); | ||
| @@clientName(RdbFrequency.OneH, "OneHour", "csharp"); | ||
| @@clientName(RdbFrequency.SixH, "SixHours", "csharp"); | ||
| @@clientName(RdbFrequency, "PersistenceSettingRdbFrequency", "csharp"); | ||
| @@clientName(RedundancyMode, "RedisEnterpriseRedundancyMode", "csharp"); | ||
| @@clientName(RegenerateKeyParameters, | ||
| "RedisEnterpriseRegenerateKeyContent", | ||
| "csharp" | ||
| ); | ||
| @@clientName(ResourceState, "RedisEnterpriseClusterResourceState", "csharp"); | ||
| @@clientName(Sku, "RedisEnterpriseSku", "csharp"); | ||
| @@clientName(SkuName, "RedisEnterpriseSkuName", "csharp"); | ||
| @@clientName(SkuDetails, "RedisEnterpriseSkuDetails", "csharp"); | ||
| @@clientName(SkuDetailsList, "RedisEnterpriseSkuDetailsList", "csharp"); | ||
| @@clientName(TlsVersion, "RedisEnterpriseTlsVersion", "csharp"); | ||
| @@clientName(OperationsStatusOperationGroup.get, | ||
| "GetRedisEnterpriseOperationsStatus", | ||
| "csharp" | ||
| ); | ||
| @@clientName(Clusters.listByCluster, | ||
| "GetPrivateLinkResourcesByCluster", | ||
| "csharp" | ||
| ); | ||
| @@alternateType(MaintenanceWindow.duration, duration, "csharp"); | ||
| @@alternateType(AccessPolicyAssignmentPropertiesUser.objectId, | ||
| Azure.Core.uuid, | ||
| "csharp" | ||
| ); | ||
| @@alternateType(ClusterPropertiesEncryptionCustomerManagedKeyEncryptionKeyIdentity.userAssignedIdentityResourceId, | ||
| Azure.Core.armResourceIdentifier, | ||
| "csharp" | ||
| ); | ||
| @@alternateType(LinkedDatabase.id, Azure.Core.armResourceIdentifier, "csharp"); | ||
| @@alternateType(ForceUnlinkParameters.ids, | ||
| Azure.Core.armResourceIdentifier[], | ||
| "csharp" | ||
| ); | ||
| @@alternateType(OperationStatus.id, Azure.Core.armResourceIdentifier, "csharp"); | ||
| @@alternateType(OperationStatus.startTime, utcDateTime, "csharp"); | ||
| @@alternateType(OperationStatus.endTime, utcDateTime, "csharp"); | ||
| @@alternateType(ExportClusterParameters.sasUri, url, "csharp"); | ||
| @@alternateType(ClusterPropertiesEncryptionCustomerManagedKeyEncryption.keyEncryptionKeyUrl, | ||
| url, | ||
| "csharp" | ||
| ); | ||
| // `RedisEnterprise` configured in `back-compatible` has a namespace name conflict, so it is reconfigured here. | ||
| @@clientLocation(Clusters.get, "RedisEnterpriseCluster", "csharp"); | ||
| @@clientLocation(Clusters.create, "RedisEnterpriseCluster", "csharp"); | ||
| @@clientLocation(Clusters.update, "RedisEnterpriseCluster", "csharp"); | ||
| @@clientLocation(Clusters.delete, "RedisEnterpriseCluster", "csharp"); | ||
| @@clientLocation(Clusters.listByResourceGroup, | ||
| "RedisEnterpriseCluster", | ||
| "csharp" | ||
| ); | ||
| @@clientLocation(Clusters.list, "RedisEnterpriseCluster", "csharp"); | ||
| @@clientLocation(Clusters.listSkusForScaling, | ||
| "RedisEnterpriseCluster", | ||
| "csharp" | ||
| ); | ||
| #suppress "@azure-tools/typespec-azure-core/no-legacy-usage" "FIXME: Update justification, follow aka.ms/tsp/conversion-fix for details" | ||
| @@Legacy.flattenProperty(Azure.ResourceManager.CommonTypes.PrivateLinkResource.properties, | ||
| "csharp" | ||
| ); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why are you adding this suppression in place of adding descriptions for the enum values? #Resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@razvanbadea-msft We created a separate PR to add missing descriptions to all our enum values (which, BTW, we had before our swaggers were translated to TypeSpec), and tsp compile insists on removing those descriptions.
This is the PR I'm referring to: #41428
Is there any way in which we can add those descriptions back?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please post the TSP compiler issue you are seeing to the Typespec Discussion Teams channel here: https://teams.microsoft.com/l/channel/19%3A906c1efbbec54dc8949ac736633e6bdf%40thread.skype/TypeSpec%20Discussion?groupId=3e17dcb0-4257-4a30-b843-77f47f1d4121&tenantId=72f988bf-86f1-41af-91ab-2d7cd011db47.
Also, if you aren't able to remove the suppressions, please replace the boilerplate with the actual justification for your suppression (just do this always).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mentat9. I was finally able to figure it out and corrected what I was doing wrong in that other PR.