Skip to content

Adding swagger for container registry dataplane APIs#4101

Merged
hovsepm merged 2 commits intoAzure:masterfrom
Jinhuafei:acr_dataplane
Oct 10, 2018
Merged

Adding swagger for container registry dataplane APIs#4101
hovsepm merged 2 commits intoAzure:masterfrom
Jinhuafei:acr_dataplane

Conversation

@Jinhuafei
Copy link
Copy Markdown
Contributor

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Oct 8, 2018

Automation for azure-sdk-for-python

Nothing to generate for azure-sdk-for-python

@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Oct 8, 2018

Automation for azure-sdk-for-js

Nothing to generate for azure-sdk-for-js

@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Oct 8, 2018

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Oct 8, 2018

Automation for azure-sdk-for-node

Nothing to generate for azure-sdk-for-node

@azuresdkci
Copy link
Copy Markdown
Contributor

Can one of the admins verify this patch?

@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Oct 8, 2018

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@Jinhuafei
Copy link
Copy Markdown
Contributor Author

/CC @sajayantony

@hovsepm
Copy link
Copy Markdown
Contributor

hovsepm commented Oct 9, 2018

@Jinhuafei could you take a look to model validator errors? https://travis-ci.org/Azure/azure-rest-api-specs/jobs/438781681
many of those are due to errors in the provided examples.

@Jinhuafei
Copy link
Copy Markdown
Contributor Author

@hovsepm how can I verify that locally? I didn't see any error when running autorest validation.

@hovsepm
Copy link
Copy Markdown
Contributor

hovsepm commented Oct 9, 2018

@Jinhuafei
Copy link
Copy Markdown
Contributor Author

@hovsepm Fixed all the errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants