Skip to content

Comments

Add signarl/resource-manager/readme.typescript.md#4097

Merged
kpajdzik merged 2 commits intomasterfrom
daschult/signalr
Oct 10, 2018
Merged

Add signarl/resource-manager/readme.typescript.md#4097
kpajdzik merged 2 commits intomasterfrom
daschult/signalr

Conversation

@ghost
Copy link

@ghost ghost commented Oct 5, 2018

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@AutorestCI
Copy link

AutorestCI commented Oct 5, 2018

Automation for azure-sdk-for-python

A PR has been created for you:
Azure/azure-sdk-for-python#3504

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@lmazuel
Copy link
Member

lmazuel commented Oct 6, 2018

@AutorestCI rebuild

@AutorestCI
Copy link

AutorestCI commented Oct 6, 2018

Automation for azure-sdk-for-js

Nothing to generate for azure-sdk-for-js

@AutorestCI
Copy link

AutorestCI commented Oct 6, 2018

Automation for azure-sdk-for-node

A PR has been created for you:
Azure/azure-sdk-for-node#3652

@AutorestCI
Copy link

AutorestCI commented Oct 6, 2018

Automation for azure-sdk-for-java

A PR has been created for you:
Azure/azure-sdk-for-java#2414

@AutorestCI
Copy link

AutorestCI commented Oct 6, 2018

Automation for azure-sdk-for-ruby

A PR has been created for you:
Azure/azure-sdk-for-ruby#1678

typescript:
azure-arm: true
package-name: "@azure/arm-signalr"
output-folder: $(typescript-sdks-folder)/packages/arm-signlar
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo. Should be arm-signalr

Copy link
Contributor

@kpajdzik kpajdzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo in output-folder

@kpajdzik kpajdzik merged commit fd6e3f5 into master Oct 10, 2018
@vladbarosan vladbarosan deleted the daschult/signalr branch March 28, 2019 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants