Skip to content

Move ACR C# specific config to C##4070

Merged
jhendrixMSFT merged 1 commit intoAzure:masterfrom
jianghaolu:acrsharpfix
Oct 3, 2018
Merged

Move ACR C# specific config to C##4070
jhendrixMSFT merged 1 commit intoAzure:masterfrom
jianghaolu:acrsharpfix

Conversation

@jianghaolu
Copy link
Contributor

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@AutorestCI
Copy link

AutorestCI commented Oct 3, 2018

Automation for azure-sdk-for-js

Nothing to generate for azure-sdk-for-js

@AutorestCI
Copy link

AutorestCI commented Oct 3, 2018

Automation for azure-sdk-for-python

Nothing to generate for azure-sdk-for-python

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI
Copy link

AutorestCI commented Oct 3, 2018

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI
Copy link

AutorestCI commented Oct 3, 2018

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#3760

@jianghaolu jianghaolu requested review from fearthecowboy and removed request for jhendrixMSFT October 3, 2018 21:10
@AutorestCI
Copy link

AutorestCI commented Oct 3, 2018

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@AutorestCI
Copy link

AutorestCI commented Oct 3, 2018

Automation for azure-sdk-for-java

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-java#2176


``` yaml $(csharp)
csharp:
# stop the simplifier from making Task conflict:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is correct.

By having csharp: in the global package scope, it does activate csharp every time.

(my bad!)

@jhendrixMSFT jhendrixMSFT merged commit 6426636 into Azure:master Oct 3, 2018
mccleanp pushed a commit that referenced this pull request Mar 23, 2022
* Copying old api version for easier review

* Changing api version

* Update readme

* Addressing issues

* Updating examples to match new sku name

* Adding properties back

* Removing wrong descriptions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants