Skip to content

Copy of PR #40395: Microsoft.NetworkCloud 2026-01-01-preview#40398

Closed
Copilot wants to merge 7 commits intomainfrom
copilot/create-draft-pr-copy-files
Closed

Copy of PR #40395: Microsoft.NetworkCloud 2026-01-01-preview#40398
Copilot wants to merge 7 commits intomainfrom
copilot/create-draft-pr-copy-files

Conversation

Copy link
Contributor

Copilot AI commented Feb 12, 2026

Create draft PR with files from PR #40395

This PR replicates the files from #40395 which adds Microsoft.NetworkCloud 2026-01-01-preview API version.

Plan:

Changes Applied:

  • Added new directory: specification/networkcloud/resource-manager/Microsoft.NetworkCloud/preview/2026-01-01-preview/
    • Main API spec: networkcloud.json (590KB)
    • 155 example JSON files in examples/ subdirectory
  • Modified: specification/networkcloud/resource-manager/readme.md
    • Updated default tag to package-2026-01-01-preview
    • Added new tag configuration for 2026-01-01-preview API version
    • Added suppressions for:
      • PatchBodyParametersSchema for Clusters PATCH operation
      • PostResponseCodes for ClusterManagers_UpdateRelayPrivateEndpointConnection (L2410) - JSON path: $.paths[...].post
      • PostResponseCodes for Clusters_Inspect (L3473) - JSON path: $.paths[...].post

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI and others added 2 commits February 12, 2026 22:23
Co-authored-by: mikeharder <9459391+mikeharder@users.noreply.github.com>
@github-actions
Copy link

github-actions bot commented Feb 12, 2026

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ This PR targets either the main branch of the public specs repo or the RPSaaSMaster branch of the private specs repo. These branches are not intended for iterative development. Therefore, you must acknowledge you understand that after this PR is merged, the APIs are considered shipped to Azure customers. Any further attempts at in-place modifications to the APIs will be subject to Azure's versioning and breaking change policies. Additionally, for control plane APIs, you must acknowledge that you are following all the best practices documented by ARM at aka.ms/armapibestpractices. If you do intend to release the APIs to your customers by merging this PR, add the PublishToCustomers label to your PR in acknowledgement of the above. Otherwise, retarget this PR onto a feature branch, i.e. with prefix release- (see aka.ms/azsdk/api-versions#release--branches).


Comment generated by summarize-checks workflow run.

Copilot AI changed the title [WIP] Create draft PR with copied files from #40395 Copy of PR #40395: Microsoft.NetworkCloud 2026-01-01-preview Feb 12, 2026
Copilot AI requested a review from mikeharder February 12, 2026 22:25
@github-actions github-actions bot added brownfield Brownfield services will soon be required to convert to TypeSpec. See https://aka.ms/azsdk/typespec. resource-manager RPaaS labels Feb 12, 2026
@github-actions
Copy link

github-actions bot commented Feb 12, 2026

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Language API Review for Package
Swagger Microsoft.NetworkCloud
Go sdk/resourcemanager/networkcloud/armnetworkcloud
Java com.azure.resourcemanager:azure-resourcemanager-networkcloud
JavaScript @azure/arm-networkcloud

@mikeharder
Copy link
Member

@copilot: add suppressions to readme.md, for the two failing errors reported from check "Swagger LintDiff - Analyze Code"

Co-authored-by: mikeharder <9459391+mikeharder@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Feb 12, 2026

@copilot: add suppressions to readme.md, for the two failing errors reported from check "Swagger LintDiff - Analyze Code"

Added two PatchBodyParametersSchema suppressions in commit b5d5d10:

  1. VirtualMachine PATCH operation - suppresses required property errors for nested objects
  2. Console PATCH operation - suppresses required property errors for nested objects

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • https://api.github.com/repos/Azure/azure-rest-api-specs/actions/runs/21966595869/jobs
    • Triggering command: /usr/bin/curl curl -sL REDACTED -H Accept: application/vnd.github&#43;json (http block)

If you need me to access, download, or install something from one of these locations, you can either:

@mikeharder
Copy link
Member

@copilot: Your previous commit appears close, but I think you suppressed the wrong error instances. Suppress only these two:

❌ PostResponseCodes Long-running POST operations must initially return 202 with a default response and no schema. The final response must be 200 with a schema if one is required, or 204 with no schema if not. No other response codes are permitted.
Location: Microsoft.NetworkCloud/preview/2026-01-01-preview/networkcloud.json#L2410 RPC-Async-V1-11, RPC-Async-V1-14, RPC-POST-V1-02, RPC-POST-V1-03

❌ PostResponseCodes Long-running POST operations must initially return 202 with a default response and no schema. The final response must be 200 with a schema if one is required, or 204 with no schema if not. No other response codes are permitted.
Location: Microsoft.NetworkCloud/preview/2026-01-01-preview/networkcloud.json#L3473 RPC-Async-V1-11, RPC-Async-V1-14, RPC-POST-V1-02, RPC-POST-V1-03

…Codes for L2410 and L3473

Co-authored-by: mikeharder <9459391+mikeharder@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Feb 12, 2026

@copilot: Your previous commit appears close, but I think you suppressed the wrong error instances. Suppress only these two:

❌ PostResponseCodes Long-running POST operations must initially retur...

Fixed in commit 67ac633. Replaced the incorrect PatchBodyParametersSchema suppressions with PostResponseCodes suppressions for:

  • L2410: ClusterManagers_UpdateRelayPrivateEndpointConnection
  • L3473: Clusters_Inspect

@mikeharder
Copy link
Member

@copilot: closer, but I think your last attempt is still usign the wrong "where" clause. Follow the instructions in this doc:

https://github.com/Azure/azure-rest-api-specs/wiki/Swagger-LintDiff#adding-scoped-suppressions

Co-authored-by: mikeharder <9459391+mikeharder@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Feb 12, 2026

@copilot: closer, but I think your last attempt is still usign the wrong "where" clause. Follow the instructions in this doc:

https://github.com/Azure/azure-rest-api-specs/wiki/Swagger-LintDiff#ad...

Fixed in commit 7363946. Updated the "where" clauses to use the correct JSON path from the error logs:

  • Removed .responses suffix
  • Now using $.paths[...].post as specified in the jsonpath array from the LintDiff error output

@mikeharder mikeharder closed this Feb 13, 2026
@mikeharder mikeharder deleted the copilot/create-draft-pr-copy-files branch February 13, 2026 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

brownfield Brownfield services will soon be required to convert to TypeSpec. See https://aka.ms/azsdk/typespec. resource-manager RPaaS SuppressionReviewRequired

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants