Skip to content

fixing model validation errors#40364

Merged
jeremyfrosti merged 9 commits intoAzure:publish-sql-Microsoft.Sql-2025-02-01-previewfrom
mitesh-pv:dev/mvishwakarma/model-validation-fixes-2
Feb 11, 2026
Merged

fixing model validation errors#40364
jeremyfrosti merged 9 commits intoAzure:publish-sql-Microsoft.Sql-2025-02-01-previewfrom
mitesh-pv:dev/mvishwakarma/model-validation-fixes-2

Conversation

@mitesh-pv
Copy link
Member

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

spec_pr_review_workflow_diagram

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

  • New resource provider.
  • New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix OpenAPI spec quality issues in S360.
  • Convert existing OpenAPI spec to TypeSpec spec (do not combine this with implementing changes for a new API version).
  • Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

  • I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • I have reviewed following Resource Provider guidelines, including
    ARM resource provider contract and
    REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
  • A release plan has been created. If not, please create one as it will help guide you through the REST API and SDK creation process.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.
  • For guidance on SDK breaking change review, refer to https://aka.ms/ci-fix.

@github-actions
Copy link

github-actions bot commented Feb 11, 2026

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

Comment generated by summarize-checks workflow run.

@github-actions
Copy link

github-actions bot commented Feb 11, 2026

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Language API Review for Package
Go sdk/resourcemanager/sql/armsql
Java com.azure.resourcemanager:azure-resourcemanager-sql-generated

@mitesh-pv mitesh-pv force-pushed the dev/mvishwakarma/model-validation-fixes-2 branch from 88c044d to 24f79f3 Compare February 11, 2026 22:06
@github-actions github-actions bot added the brownfield Brownfield services will soon be required to convert to TypeSpec. See https://aka.ms/azsdk/typespec. label Feb 11, 2026
@jeremyfrosti jeremyfrosti merged commit 0af1ed2 into Azure:publish-sql-Microsoft.Sql-2025-02-01-preview Feb 11, 2026
32 of 37 checks passed
jeremyfrosti added a commit that referenced this pull request Mar 4, 2026
* Create base of release-sql-Microsoft.Sql-2025-02-01-preview via Copy-ApiVersion.ps1 (#36370)

* Copy files from preview/2024-11-01-preview

Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.

* Update version to preview/2025-02-01-preview

Updated the API version from preview/2024-11-01-preview to preview/2025-02-01-preview.

* Added tag for 2025-02-01-preview in readme file

---------

Co-authored-by: Mitesh Vishwakarma <mvishwakarma@microsoft.com>

* Swagger changes for Paginated List DDM rules API (#36819)

Co-authored-by: Santosh Padhy <santoshpadhy@microsoft.com>

* Datasync UAMI support API in 2025-02-01-preview (#35876)

* Datasync UAMI support API in 2025-02-01-preview

* Updated json to fix validation failure

* Spell, lint fix

* Fix error message

* Updating error codes

---------

Co-authored-by: Hareesh Kumar Gajulapalli <hgajulapalli@microsoft.com>

* Azure SQL API Parity (#38442)

* Azure SQL API Parity

* avocado error update

* fixes lint diff errors

---------

Co-authored-by: mvishwakarma <mvishwakarma@microsoft.com>

* Removing datasync breaking change because of required fields (#39059)

Co-authored-by: Hareesh Kumar Gajulapalli <hgajulapalli@microsoft.com>

* Added back the legacy params (#39317)

Co-authored-by: Santosh Padhy <santoshpadhy@microsoft.com>

* 20250201-preview breaking change fix for databases.json (#40027)

* breaking change fix

* fix model validation failure

---------

Co-authored-by: mvishwakarma <mvishwakarma@microsoft.com>

* fixing model validation errors (#40364)

* fixing model validation errors

* adds model validation fix

* fixes model validation errors

* Fixes model validation errors

* fixes model validation failures

* model valdation fixes '

* model validation fix

* model validation fixes

* fixes model validation errors

---------

Co-authored-by: mvishwakarma <mvishwakarma@microsoft.com>

* fix semantic error

* fix semantic error

* add v2

* fix breaking change (#40593)

Co-authored-by: mvishwakarma <mvishwakarma@microsoft.com>

* Adding suppressions previously approved in #38470 (#40764)

* Removing the list import export operation results from Servers API (#40836)

* Adding suppressions previously approved in #38470

* Removing the list import export operation results from Servers API

* Fix for lint-diff errors (#40792)

* Fix for lint-diff errors

* Rectifies suppression for ResourceNamePattern

* Remove ResourceNameRestriction validation code

Removed ResourceNameRestriction code from parameters.

* Fix formatting issue

Fix formatting issue

---------

Co-authored-by: mvishwakarma <mvishwakarma@microsoft.com>
Co-authored-by: Jeremy Frosti <111934615+jeremyfrosti@users.noreply.github.com>

* Add suppression for ElasticPools to match existing suppression in Databases (#40862)

* Adding suppressions previously approved in #38470

* Removing the list import export operation results from Servers API

* Adding suppression for new currentSku in ElasticPool update

---------

Co-authored-by: Mitesh Vishwakarma <mvishwakarma@microsoft.com>
Co-authored-by: skpadhy33 <35034191+skpadhy33@users.noreply.github.com>
Co-authored-by: Santosh Padhy <santoshpadhy@microsoft.com>
Co-authored-by: hareeshghk <hareeshghk@users.noreply.github.com>
Co-authored-by: Hareesh Kumar Gajulapalli <hgajulapalli@microsoft.com>
Co-authored-by: zedy <zedy@wicresoft.com>
Co-authored-by: Jeremy Frosti <111934615+jeremyfrosti@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

brownfield Brownfield services will soon be required to convert to TypeSpec. See https://aka.ms/azsdk/typespec. resource-manager SQL

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants