Add Pipeline Variables / Set Variable Activity / Append Variable Activity#4028
Add Pipeline Variables / Set Variable Activity / Append Variable Activity#4028annatisch merged 8 commits intoAzure:masterfrom leonliang33:master
Conversation
This reverts commit 41a5cc1.
Automation for azure-sdk-for-jsNothing to generate for azure-sdk-for-js |
Automation for azure-sdk-for-rubyNothing to generate for azure-sdk-for-ruby |
Automation for azure-sdk-for-pythonThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-nodeThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-javaThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-goThe initial PR has been merged into your service PR: |
|
Can one of the admins verify this patch? |
|
Thanks @leonliang33 - these two swagger specs have a large volume of model validation errors - are you able to address some of these? |
annatisch
left a comment
There was a problem hiding this comment.
LGTM - just a few minor docs comments.
| ] | ||
| }, | ||
| "VariableDefinitionSpecification": { | ||
| "description": "Definition of all variables for an Pipeline.", |
There was a problem hiding this comment.
"a Pipeline"
Additionally - this description says "Definition of all variables - yet it only references a single Specification.
Should it be referencing an array of VariableSpecifications? If not - maybe alter this description.
| } | ||
| }, | ||
| "VariableSpecification": { | ||
| "description": "Definition of a single variable for an pipeline.", |
|
Need more changes @haricr requests |
|
Reopened, decided no more changes are necessary |
|
@annatisch I will fix the validation errors later. We need to update our capture examples code to get 304-s and most of the errors are about that. |
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-versionin the path should match theapi-versionin the spec).Quality of Swagger