Skip to content

Add ContextPath and source location URL for encode task and run type, support for pull request based triggers#4026

Merged
anuchandy merged 2 commits intoAzure:masterfrom
mnltejaswini:naduggar/context
Oct 1, 2018
Merged

Add ContextPath and source location URL for encode task and run type, support for pull request based triggers#4026
anuchandy merged 2 commits intoAzure:masterfrom
mnltejaswini:naduggar/context

Conversation

@mnltejaswini
Copy link
Contributor

Add ContextPath and source location URL for encode task and run type, support for pull request based triggers

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

… add support for pull request based trigger.
@AutorestCI
Copy link

AutorestCI commented Sep 28, 2018

Automation for azure-sdk-for-js

Nothing to generate for azure-sdk-for-js

@AutorestCI
Copy link

AutorestCI commented Sep 28, 2018

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#3467

@AutorestCI
Copy link

AutorestCI commented Sep 28, 2018

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#3738

@AutorestCI
Copy link

AutorestCI commented Sep 28, 2018

Automation for azure-sdk-for-ruby

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-ruby#1574

@AutorestCI
Copy link

AutorestCI commented Sep 28, 2018

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#2871

@AutorestCI
Copy link

AutorestCI commented Sep 28, 2018

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#2176

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@mnltejaswini
Copy link
Contributor Author

Can anyone please review

Copy link
Member

@anuchandy anuchandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Summary - PR has following changes:

  1. Adding “contextPath” property to “TaskStepProperties” and “TaskStepUpdateParameters” model and removes “contextPath” from types derives from these models.
  2. Adding a new “sourceLocation” property.
  3. Adding few values to expandable enums.

@anuchandy anuchandy merged commit 35a0cef into Azure:master Oct 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants