Add ContextPath and source location URL for encode task and run type, support for pull request based triggers#4026
Merged
anuchandy merged 2 commits intoAzure:masterfrom Oct 1, 2018
mnltejaswini:naduggar/context
Merged
Add ContextPath and source location URL for encode task and run type, support for pull request based triggers#4026anuchandy merged 2 commits intoAzure:masterfrom mnltejaswini:naduggar/context
anuchandy merged 2 commits intoAzure:masterfrom
mnltejaswini:naduggar/context
Conversation
… add support for pull request based trigger.
Automation for azure-sdk-for-jsNothing to generate for azure-sdk-for-js |
Automation for azure-sdk-for-pythonThe initial PR has been merged into your service PR: |
This was referenced Sep 28, 2018
Automation for azure-sdk-for-nodeThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-rubyThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-goThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-javaThe initial PR has been merged into your service PR: |
jaysterp
approved these changes
Sep 28, 2018
Contributor
|
Can one of the admins verify this patch? |
Contributor
Author
|
Can anyone please review |
anuchandy
approved these changes
Oct 1, 2018
Member
anuchandy
left a comment
There was a problem hiding this comment.
LGTM
Summary - PR has following changes:
- Adding “contextPath” property to “TaskStepProperties” and “TaskStepUpdateParameters” model and removes “contextPath” from types derives from these models.
- Adding a new “sourceLocation” property.
- Adding few values to expandable enums.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add ContextPath and source location URL for encode task and run type, support for pull request based triggers
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-versionin the path should match theapi-versionin the spec).Quality of Swagger