Skip to content

Refine PR #39984 review: Distinguish REST API vs SDK-only changes#40079

Closed
Copilot wants to merge 4 commits intomainfrom
copilot/review-data-plane-pr-39984
Closed

Refine PR #39984 review: Distinguish REST API vs SDK-only changes#40079
Copilot wants to merge 4 commits intomainfrom
copilot/review-data-plane-pr-39984

Conversation

Copy link
Contributor

Copilot AI commented Feb 2, 2026

Summary

Initial review incorrectly classified operationId changes as REST API breaking changes. operationId is OpenAPI metadata affecting SDK generation only—HTTP callers are unaffected.

Changes Made

Corrected Analysis:

  • operationId changes: SDK breaking, REST API non-breaking
  • HTTP paths/methods/schemas: Unchanged
  • Actual REST API changes: Two optional properties added (non-breaking)

Documents Created:

  1. REFINED_REVIEW.md

    • REST API caller perspective: No breaking changes
    • SDK user perspective: Method names change (acceptable for preview)
    • HTTP examples demonstrating no changes needed
  2. REVIEW_SUMMARY.md (updated)

    • Quick reference distinguishing REST API vs SDK impact
    • Impact table by user type
  3. PR_REVIEW_39984.md (original)

    • Comprehensive technical analysis

Key Distinction

# REST API: Works identically before/after
curl -X GET "https://api.purview.../criticalDataElements"

# SDK: Method name changes
# Before: client.listCriticalDataElement()
# After:  client.criticalDataElements.list()

Verdict

PR #39984: No breaking REST API changes. SDK structure improves (interface grouping), method names change. Acceptable for preview API.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

@github-actions
Copy link

github-actions bot commented Feb 2, 2026

Next Steps to Merge

⌛ Please wait. Next steps to merge this PR are being evaluated by automation. ⌛

Comment generated by summarize-checks workflow run.

Copilot AI and others added 2 commits February 2, 2026 02:10
Co-authored-by: weidongxu-microsoft <53292327+weidongxu-microsoft@users.noreply.github.com>
Co-authored-by: weidongxu-microsoft <53292327+weidongxu-microsoft@users.noreply.github.com>
Copilot AI changed the title [WIP] Review data-plane PR for REST API changes Refactor Purview Unified Catalog TypeSpec: Organize operations into interfaces Feb 2, 2026
Co-authored-by: weidongxu-microsoft <53292327+weidongxu-microsoft@users.noreply.github.com>
Copilot AI changed the title Refactor Purview Unified Catalog TypeSpec: Organize operations into interfaces Refine PR #39984 review: Distinguish REST API vs SDK-only changes Feb 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants