Add swagger spec for "Microsoft.Authorization/denyAssignments" by kirankulkarni747 · Pull Request #3987 · Azure/azure-rest-api-specs

kirankulkarni747 · 2018-09-22T00:24:41Z

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

AutorestCI · 2018-09-22T00:25:18Z

Automation for azure-sdk-for-python

Nothing to generate for azure-sdk-for-python

azuresdkci · 2018-09-22T00:43:33Z

Can one of the admins verify this patch?

AutorestCI · 2018-09-22T01:22:09Z

Automation for azure-sdk-for-js

Nothing to generate for azure-sdk-for-js

AutorestCI · 2018-09-22T02:13:13Z

Automation for azure-sdk-for-ruby

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-ruby#1619

AutorestCI · 2018-09-22T03:21:41Z

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#3707

AutorestCI · 2018-09-22T03:28:36Z

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

AutorestCI · 2018-09-22T04:39:38Z

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#2833

hovsepm · 2018-09-24T17:40:12Z

@kirankulkarni747 please address model validation errors:

Validating "examples" and "x-ms-examples" in  specification/authorization/resource-manager/Microsoft.Authorization/preview/2018-07-01-preview/authorization-DenyAssignmentGetCalls.json:
 error: 
operationId: DenyAssignments_ListForResource
scenario: GetConfigurations
source: response
responseCode: '200'
severity: 0
errorCode: OBJECT_ADDITIONAL_PROPERTIES
errorDetails:
  code: OBJECT_ADDITIONAL_PROPERTIES
  params:
    - - Type
      - Id
  message: 'Additional properties not allowed: Type,Id'
  path: value/0/properties/principals/principals/0
  title: /definitions/Principal
  description: Deny assignment principal.
  position:
    line: 438
    column: 18
  url: >-
    specification/authorization/resource-manager/Microsoft.Authorization/preview/2018-07-01-preview/authorization-DenyAssignmentGetCalls.json
  jsonPosition: !<tag:yaml.org,2002:js/undefined> ''
  jsonUrl: >-
    specification/authorization/resource-manager/Microsoft.Authorization/preview/2018-07-01-preview/examples/GetDenyAssignmentsForResource.json
 error: 
operationId: DenyAssignments_ListForResource
scenario: GetConfigurations
source: response
responseCode: '200'
severity: 0
errorCode: OBJECT_ADDITIONAL_PROPERTIES
errorDetails:
  code: OBJECT_ADDITIONAL_PROPERTIES
  params:
    - - Type
      - Id
  message: 'Additional properties not allowed: Type,Id'
  path: value/0/properties/excludePrincipals/excludePrincipals/0
  title: /definitions/Principal
  description: Deny assignment principal.
  position:
    line: 438
    column: 18
  url: >-
    specification/authorization/resource-manager/Microsoft.Authorization/preview/2018-07-01-preview/authorization-DenyAssignmentGetCalls.json
  jsonPosition: !<tag:yaml.org,2002:js/undefined> ''
  jsonUrl: >-
    specification/authorization/resource-manager/Microsoft.Authorization/preview/2018-07-01-preview/examples/GetDenyAssignmentsForResource.json
 error: 
operationId: DenyAssignments_ListForResourceGroup
scenario: GetConfigurations
source: response
responseCode: '200'
severity: 0
errorCode: OBJECT_ADDITIONAL_PROPERTIES
errorDetails:
  code: OBJECT_ADDITIONAL_PROPERTIES
  params:
    - - Type
      - Id
  message: 'Additional properties not allowed: Type,Id'
  path: value/0/properties/principals/principals/0
  title: /definitions/Principal
  description: Deny assignment principal.
  position:
    line: 438
    column: 18
  url: >-
    specification/authorization/resource-manager/Microsoft.Authorization/preview/2018-07-01-preview/authorization-DenyAssignmentGetCalls.json
  jsonPosition: !<tag:yaml.org,2002:js/undefined> ''
  jsonUrl: >-
    specification/authorization/resource-manager/Microsoft.Authorization/preview/2018-07-01-preview/examples/GetDenyAssignmentsForResourceGroup.json
 error: 
operationId: DenyAssignments_ListForResourceGroup
scenario: GetConfigurations
source: response
responseCode: '200'
severity: 0
errorCode: OBJECT_ADDITIONAL_PROPERTIES
errorDetails:
  code: OBJECT_ADDITIONAL_PROPERTIES
  params:
    - - Type
      - Id
  message: 'Additional properties not allowed: Type,Id'
  path: value/0/properties/excludePrincipals/excludePrincipals/0
  title: /definitions/Principal
  description: Deny assignment principal.
  position:
    line: 438
    column: 18
  url: >-
    specification/authorization/resource-manager/Microsoft.Authorization/preview/2018-07-01-preview/authorization-DenyAssignmentGetCalls.json
  jsonPosition: !<tag:yaml.org,2002:js/undefined> ''
  jsonUrl: >-
    specification/authorization/resource-manager/Microsoft.Authorization/preview/2018-07-01-preview/examples/GetDenyAssignmentsForResourceGroup.json
 error: 
operationId: DenyAssignments_List
scenario: GetConfigurations
source: response
responseCode: '200'
severity: 0
errorCode: OBJECT_ADDITIONAL_PROPERTIES
errorDetails:
  code: OBJECT_ADDITIONAL_PROPERTIES
  params:
    - - Type
      - Id
  message: 'Additional properties not allowed: Type,Id'
  path: value/0/properties/principals/principals/0
  title: /definitions/Principal
  description: Deny assignment principal.
  position:
    line: 438
    column: 18
  url: >-
    specification/authorization/resource-manager/Microsoft.Authorization/preview/2018-07-01-preview/authorization-DenyAssignmentGetCalls.json
  jsonPosition: !<tag:yaml.org,2002:js/undefined> ''
  jsonUrl: >-
    specification/authorization/resource-manager/Microsoft.Authorization/preview/2018-07-01-preview/examples/GetAllDenyAssignments.json
 error: 
operationId: DenyAssignments_List
scenario: GetConfigurations
source: response
responseCode: '200'
severity: 0
errorCode: OBJECT_ADDITIONAL_PROPERTIES
errorDetails:
  code: OBJECT_ADDITIONAL_PROPERTIES
  params:
    - - Type
      - Id
  message: 'Additional properties not allowed: Type,Id'
  path: value/0/properties/excludePrincipals/excludePrincipals/0
  title: /definitions/Principal
  description: Deny assignment principal.
  position:
    line: 438
    column: 18
  url: >-
    specification/authorization/resource-manager/Microsoft.Authorization/preview/2018-07-01-preview/authorization-DenyAssignmentGetCalls.json
  jsonPosition: !<tag:yaml.org,2002:js/undefined> ''
  jsonUrl: >-
    specification/authorization/resource-manager/Microsoft.Authorization/preview/2018-07-01-preview/examples/GetAllDenyAssignments.json
 error: 
operationId: DenyAssignments_Get
scenario: GetConfigurations
source: request
responseCode: ALL
severity: 0
errorCode: DOUBLE_FORWARD_SLASHES_IN_URL
errorDetails:
  code: DOUBLE_FORWARD_SLASHES_IN_URL
  id: OAV129
  message: >-
    In operation "DenyAssignments_Get", example for parameter "scope":
    "/subscriptions/subId/resourcegroups/rgname" starts with a forward slash and
    the path template:
    "/{scope}/providers/Microsoft.Authorization/denyAssignments/{denyAssignmentId}"
    contains a forward slash before the parameter starts. This will cause double
    forward slashes  in the request url. Thus making it incorrect. Please
    rectify the example.
  innerErrors: !<tag:yaml.org,2002:js/undefined> ''
 error: 
operationId: DenyAssignments_Get
scenario: GetConfigurations
source: response
responseCode: '200'
severity: 0
errorCode: OBJECT_ADDITIONAL_PROPERTIES
errorDetails:
  code: OBJECT_ADDITIONAL_PROPERTIES
  params:
    - - Type
      - Id
  message: 'Additional properties not allowed: Type,Id'
  path: properties/principals/0
  title: /definitions/Principal
  description: Deny assignment principal.
  position:
    line: 438
    column: 18
  url: >-
    specification/authorization/resource-manager/Microsoft.Authorization/preview/2018-07-01-preview/authorization-DenyAssignmentGetCalls.json
  jsonPosition:
    line: 29
    column: 13
  jsonUrl: >-
    specification/authorization/resource-manager/Microsoft.Authorization/preview/2018-07-01-preview/examples/GetDenyAssignmentByNameId.json
 error: 
operationId: DenyAssignments_Get
scenario: GetConfigurations
source: response
responseCode: '200'
severity: 0
errorCode: OBJECT_ADDITIONAL_PROPERTIES
errorDetails:
  code: OBJECT_ADDITIONAL_PROPERTIES
  params:
    - - Type
      - Id
  message: 'Additional properties not allowed: Type,Id'
  path: properties/excludePrincipals/0
  title: /definitions/Principal
  description: Deny assignment principal.
  position:
    line: 438
    column: 18
  url: >-
    specification/authorization/resource-manager/Microsoft.Authorization/preview/2018-07-01-preview/authorization-DenyAssignmentGetCalls.json
  jsonPosition:
    line: 35
    column: 13
  jsonUrl: >-
    specification/authorization/resource-manager/Microsoft.Authorization/preview/2018-07-01-preview/examples/GetDenyAssignmentByNameId.json
 error: 
operationId: DenyAssignments_GetById
scenario: GetConfigurations
source: request
responseCode: ALL
severity: 0
errorCode: DOUBLE_FORWARD_SLASHES_IN_URL
errorDetails:
  code: DOUBLE_FORWARD_SLASHES_IN_URL
  id: OAV129
  message: >-
    In operation "DenyAssignments_GetById", example for parameter
    "denyAssignmentId":
    "/subscriptions/subId/resourcegroups/rgname/providers/Microsoft.Authorization/denyAssignments/daId"
    starts with a forward slash and the path template: "/{denyAssignmentId}"
    contains a forward slash before the parameter starts. This will cause double
    forward slashes  in the request url. Thus making it incorrect. Please
    rectify the example.
  innerErrors: !<tag:yaml.org,2002:js/undefined> ''
 error: 
operationId: DenyAssignments_GetById
scenario: GetConfigurations
source: response
responseCode: '200'
severity: 0
errorCode: OBJECT_ADDITIONAL_PROPERTIES
errorDetails:
  code: OBJECT_ADDITIONAL_PROPERTIES
  params:
    - - Type
      - Id
  message: 'Additional properties not allowed: Type,Id'
  path: properties/principals/0
  title: /definitions/Principal
  description: Deny assignment principal.
  position:
    line: 438
    column: 18
  url: >-
    specification/authorization/resource-manager/Microsoft.Authorization/preview/2018-07-01-preview/authorization-DenyAssignmentGetCalls.json
  jsonPosition:
    line: 28
    column: 13
  jsonUrl: >-
    specification/authorization/resource-manager/Microsoft.Authorization/preview/2018-07-01-preview/examples/GetDenyAssignmentById.json
 error: 
operationId: DenyAssignments_GetById
scenario: GetConfigurations
source: response
responseCode: '200'
severity: 0
errorCode: OBJECT_ADDITIONAL_PROPERTIES
errorDetails:
  code: OBJECT_ADDITIONAL_PROPERTIES
  params:
    - - Type
      - Id
  message: 'Additional properties not allowed: Type,Id'
  path: properties/excludePrincipals/0
  title: /definitions/Principal
  description: Deny assignment principal.
  position:
    line: 438
    column: 18
  url: >-
    specification/authorization/resource-manager/Microsoft.Authorization/preview/2018-07-01-preview/authorization-DenyAssignmentGetCalls.json
  jsonPosition:
    line: 34
    column: 13
  jsonUrl: >-
    specification/authorization/resource-manager/Microsoft.Authorization/preview/2018-07-01-preview/examples/GetDenyAssignmentById.json
 error: 
operationId: DenyAssignments_ListForScope
scenario: GetConfigurations
source: request
responseCode: ALL
severity: 0
errorCode: DOUBLE_FORWARD_SLASHES_IN_URL
errorDetails:
  code: DOUBLE_FORWARD_SLASHES_IN_URL
  id: OAV129
  message: >-
    In operation "DenyAssignments_ListForScope", example for parameter "scope":
    "/subscriptions/subId" starts with a forward slash and the path template:
    "/{scope}/providers/Microsoft.Authorization/denyAssignments" contains a
    forward slash before the parameter starts. This will cause double forward
    slashes  in the request url. Thus making it incorrect. Please rectify the
    example.
  innerErrors: !<tag:yaml.org,2002:js/undefined> ''
 error: 
operationId: DenyAssignments_ListForScope
scenario: GetConfigurations
source: response
responseCode: '200'
severity: 0
errorCode: OBJECT_ADDITIONAL_PROPERTIES
errorDetails:
  code: OBJECT_ADDITIONAL_PROPERTIES
  params:
    - - Type
      - Id
  message: 'Additional properties not allowed: Type,Id'
  path: value/0/properties/principals/principals/0
  title: /definitions/Principal
  description: Deny assignment principal.
  position:
    line: 438
    column: 18
  url: >-
    specification/authorization/resource-manager/Microsoft.Authorization/preview/2018-07-01-preview/authorization-DenyAssignmentGetCalls.json
  jsonPosition: !<tag:yaml.org,2002:js/undefined> ''
  jsonUrl: >-
    specification/authorization/resource-manager/Microsoft.Authorization/preview/2018-07-01-preview/examples/GetDenyAssignmentByScope.json
 error: 
operationId: DenyAssignments_ListForScope
scenario: GetConfigurations
source: response
responseCode: '200'
severity: 0
errorCode: OBJECT_ADDITIONAL_PROPERTIES
errorDetails:
  code: OBJECT_ADDITIONAL_PROPERTIES
  params:
    - - Type
      - Id
  message: 'Additional properties not allowed: Type,Id'
  path: value/0/properties/excludePrincipals/excludePrincipals/0
  title: /definitions/Principal
  description: Deny assignment principal.
  position:
    line: 438
    column: 18
  url: >-
    specification/authorization/resource-manager/Microsoft.Authorization/preview/2018-07-01-preview/authorization-DenyAssignmentGetCalls.json
  jsonPosition: !<tag:yaml.org,2002:js/undefined> ''
  jsonUrl: >-
    specification/authorization/resource-manager/Microsoft.Authorization/preview/2018-07-01-preview/examples/GetDenyAssignmentByScope.json

hovsepm · 2018-09-24T21:15:59Z

@ravbhatnagar please take a look. This PR adds new API version.

...Microsoft.Authorization/preview/2018-07-01-preview/authorization-DenyAssignmentGetCalls.json

specification/authorization/resource-manager/readme.md

ryansbenson

Reviewed

darshanhs90

Add swagger spec for "Microsoft.Authorization/denyAssignments"

a4bee19

azuresdkci assigned hovsepm Sep 22, 2018

azuresdkci requested a review from hovsepm September 22, 2018 00:47

AutorestCI mentioned this pull request Sep 22, 2018

[AutoPR authorization/resource-manager] Add swagger spec for "Microsoft.Authorization/denyAssignments" Azure/azure-sdk-for-ruby#1692

Merged

AutorestCI mentioned this pull request Sep 22, 2018

[AutoPR authorization/resource-manager] Add swagger spec for "Microsoft.Authorization/denyAssignments" Azure/azure-sdk-for-node#3677

Merged

AutorestCI mentioned this pull request Sep 22, 2018

[AutoPR authorization/resource-manager] Add swagger spec for "Microsoft.Authorization/denyAssignments" Azure/azure-sdk-for-go#2805

Merged

Update swagger examples to fix validation errors from oav tool

70ff2c2

hovsepm added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 24, 2018

hovsepm reviewed Sep 24, 2018

View reviewed changes

...Microsoft.Authorization/preview/2018-07-01-preview/authorization-DenyAssignmentGetCalls.json Show resolved Hide resolved

hovsepm reviewed Sep 24, 2018

View reviewed changes

...Microsoft.Authorization/preview/2018-07-01-preview/authorization-DenyAssignmentGetCalls.json Show resolved Hide resolved

hovsepm approved these changes Sep 25, 2018

View reviewed changes

ryansbenson reviewed Sep 25, 2018

View reviewed changes

specification/authorization/resource-manager/readme.md Show resolved Hide resolved

ryansbenson approved these changes Sep 25, 2018

View reviewed changes

darshanhs90 approved these changes Sep 26, 2018

View reviewed changes

KrisBash added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Sep 26, 2018

hovsepm merged commit c0b634d into Azure:master Sep 26, 2018

kirankulkarni747 mentioned this pull request Sep 27, 2018

Add support for Deny Assignments Azure/azure-sdk-for-net#4802

Merged

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add swagger spec for "Microsoft.Authorization/denyAssignments"#3987

Add swagger spec for "Microsoft.Authorization/denyAssignments"#3987
hovsepm merged 2 commits intoAzure:masterfrom
kirankulkarni747:master

kirankulkarni747 commented Sep 22, 2018 •

edited

Loading

Uh oh!

AutorestCI commented Sep 22, 2018 •

edited

Loading

Uh oh!

azuresdkci commented Sep 22, 2018

Uh oh!

AutorestCI commented Sep 22, 2018 •

edited

Loading

Uh oh!

AutorestCI commented Sep 22, 2018 •

edited

Loading

Uh oh!

AutorestCI commented Sep 22, 2018 •

edited

Loading

Uh oh!

AutorestCI commented Sep 22, 2018 •

edited

Loading

Uh oh!

AutorestCI commented Sep 22, 2018 •

edited

Loading

Uh oh!

hovsepm commented Sep 24, 2018

Uh oh!

hovsepm commented Sep 24, 2018

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ryansbenson left a comment

Uh oh!

darshanhs90 left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Conversation

kirankulkarni747 commented Sep 22, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR information

Quality of Swagger

Uh oh!

AutorestCI commented Sep 22, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-python

Uh oh!

azuresdkci commented Sep 22, 2018

Uh oh!

AutorestCI commented Sep 22, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-js

Uh oh!

AutorestCI commented Sep 22, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-ruby

Uh oh!

AutorestCI commented Sep 22, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-node

Uh oh!

AutorestCI commented Sep 22, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-java

Uh oh!

AutorestCI commented Sep 22, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-go

Uh oh!

hovsepm commented Sep 24, 2018

Uh oh!

hovsepm commented Sep 24, 2018

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ryansbenson left a comment

Choose a reason for hiding this comment

Uh oh!

darshanhs90 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

kirankulkarni747 commented Sep 22, 2018 •

edited

Loading

AutorestCI commented Sep 22, 2018 •

edited

Loading

AutorestCI commented Sep 22, 2018 •

edited

Loading

AutorestCI commented Sep 22, 2018 •

edited

Loading

AutorestCI commented Sep 22, 2018 •

edited

Loading

AutorestCI commented Sep 22, 2018 •

edited

Loading

AutorestCI commented Sep 22, 2018 •

edited

Loading