Skip to content

Fix: Change getVersionCode and swapDefault to use empty body model and delete response codes for SDK generation #39806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tundwed merged 7 commits into from
Feb 6, 2026
Merged

Fix: Change getVersionCode and swapDefault to use empty body model and delete response codes for SDK generation #39806

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
eb00c04
fix: Change getVersionCode and swapDefault to use empty body model fo…
Jan 21, 2026
669d617
Add 200 response to delete operations for SDK generation compatibility
Jan 21, 2026
6d35129
Add 200 response to TypeSpec source example files for delete operations
Jan 21, 2026
cfd28a5
Update specification/cdn/resource-manager/Microsoft.Cdn/EdgeActions/m…
tundwed Jan 26, 2026
df4356f
Update getVersionCode to use void with explicit contentType header
Jan 26, 2026
f5eb6d7
Apply tsp format to main.tsp
Jan 26, 2026
2a46f92
Merge branch 'main' into dev/tundwed/fixsdkgen
sandipsh Feb 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...rosoft.Cdn/EdgeActions/examples/2025-09-01-preview/EdgeActionExecutionFilters_Delete.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
"executionFilter": "executionFilter1"
},
"responses": {
"200": {},
"202": {
"headers": {
"location": "https://management.azure.com/subscriptions/subid/resourcegroups/resourceGroupName/providers/Microsoft.Cdn/operationresults/operationId?api-version=2025-09-01-preview"
Expand Down
1 change: 1 addition & 0 deletions ...ager/Microsoft.Cdn/EdgeActions/examples/2025-09-01-preview/EdgeActionVersions_Delete.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
"version": "version1"
},
"responses": {
"200": {},
"202": {
"headers": {
"location": "https://management.azure.com/subscriptions/subid/resourcegroups/resourceGroupName/providers/Microsoft.Cdn/operationresults/operationId?api-version=2025-09-01-preview"
Expand Down
1 change: 1 addition & 0 deletions ...rce-manager/Microsoft.Cdn/EdgeActions/examples/2025-09-01-preview/EdgeActions_Delete.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
"edgeActionName": "edgeAction1"
},
"responses": {
"200": {},
"202": {
"headers": {
"location": "https://management.azure.com/subscriptions/subid/resourcegroups/resourceGroupName/providers/Microsoft.Cdn/operationresults/operationId?api-version=2024-03-06-preview"
Expand Down
1 change: 1 addition & 0 deletions ...rosoft.Cdn/EdgeActions/examples/2025-12-01-preview/EdgeActionExecutionFilters_Delete.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
"executionFilter": "executionFilter1"
},
"responses": {
"200": {},
"202": {
"headers": {
"location": "https://management.azure.com/subscriptions/subid/resourcegroups/resourceGroupName/providers/Microsoft.Cdn/operationresults/operationId?api-version=2025-09-01-preview"
Expand Down
1 change: 1 addition & 0 deletions ...ager/Microsoft.Cdn/EdgeActions/examples/2025-12-01-preview/EdgeActionVersions_Delete.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
"version": "version1"
},
"responses": {
"200": {},
"202": {
"headers": {
"location": "https://management.azure.com/subscriptions/subid/resourcegroups/resourceGroupName/providers/Microsoft.Cdn/operationresults/operationId?api-version=2025-09-01-preview"
Expand Down
1 change: 1 addition & 0 deletions ...rce-manager/Microsoft.Cdn/EdgeActions/examples/2025-12-01-preview/EdgeActions_Delete.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
"edgeActionName": "edgeAction1"
},
"responses": {
"200": {},
"202": {
"headers": {
"location": "https://management.azure.com/subscriptions/subid/resourcegroups/resourceGroupName/providers/Microsoft.Cdn/operationresults/operationId?api-version=2024-03-06-preview"
Expand Down
48 changes: 42 additions & 6 deletions specification/cdn/resource-manager/Microsoft.Cdn/EdgeActions/main.tsp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,14 @@ interface EdgeActions {
get is ArmResourceRead<EdgeAction>;
create is ArmResourceCreateOrUpdateAsync<EdgeAction>;
update is ArmCustomPatchAsync<EdgeAction, EdgeActionUpdate>;
delete is ArmResourceDeleteWithoutOkAsync<EdgeAction>;
#suppress "@azure-tools/typespec-azure-resource-manager/arm-delete-operation-response-codes" "Service returns 200 for successful delete operations"
delete is ArmResourceDeleteWithoutOkAsync<
Copy link
Contributor

@sandipsh sandipsh Feb 5, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ArmResourceDeleteWithoutOkAsync

json file is returning 200? #Resolved

Copy link
Member Author

@tundwed tundwed Feb 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sandipsh see the updated return type for this function

EdgeAction,
Azure.ResourceManager.Foundations.BaseParameters<EdgeAction>,
ArmLroLocationHeader & Azure.Core.Foundations.RetryAfterHeader,
{},
ArmDeletedResponse | ArmDeleteAcceptedLroResponse | ArmDeletedNoContentResponse
>;
listByResourceGroup is ArmResourceListByParent<EdgeAction>;
listBySubscription is ArmListBySubscription<EdgeAction>;

Expand Down Expand Up @@ -116,21 +123,43 @@ interface EdgeActionVersions {
EdgeActionVersionProperties
>
>;
delete is ArmResourceDeleteWithoutOkAsync<EdgeActionVersion>;
#suppress "@azure-tools/typespec-azure-resource-manager/arm-delete-operation-response-codes" "Service returns 200 for successful delete operations"
delete is ArmResourceDeleteWithoutOkAsync<
EdgeActionVersion,
Azure.ResourceManager.Foundations.BaseParameters<EdgeActionVersion>,
ArmLroLocationHeader & Azure.Core.Foundations.RetryAfterHeader,
{},
ArmDeletedResponse | ArmDeleteAcceptedLroResponse | ArmDeletedNoContentResponse
>;
listByEdgeAction is ArmResourceListByParent<EdgeActionVersion>;
deployVersionCode is ArmResourceActionAsync<
EdgeActionVersion,
VersionCode,
EdgeActionVersionProperties
>;

/** Get the version code for the edge action version. */
#suppress "@azure-tools/typespec-azure-resource-manager/arm-post-operation-response-codes" "Explicitly set content type for POST operations - expected by service"
getVersionCode is ArmResourceActionAsync<
EdgeActionVersion,
void,
VersionCode
VersionCode,
Parameters = {
/** Content type */
@header contentType: "application/json";
}
>;

#suppress "@azure-tools/typespec-azure-resource-manager/arm-post-operation-response-codes" "Operation matches 2024 baseline with 200, 202 responses"
swapDefault is ArmResourceActionNoContentAsync<EdgeActionVersion, void>;
/** Swap the default version for the edge action. */
#suppress "@azure-tools/typespec-azure-resource-manager/arm-post-operation-response-codes" "Explicitly set content type for POST operations - expected by service"
swapDefault is ArmResourceActionNoContentAsync<
EdgeActionVersion,
void,
Parameters = {
/** Content type */
@header contentType: "application/json";
}
>;
}

@armResourceOperations
Expand All @@ -144,6 +173,13 @@ interface EdgeActionExecutionFilters {
EdgeActionExecutionFilterProperties
>
>;
delete is ArmResourceDeleteWithoutOkAsync<EdgeActionExecutionFilter>;
#suppress "@azure-tools/typespec-azure-resource-manager/arm-delete-operation-response-codes" "Service returns 200 for successful delete operations"
delete is ArmResourceDeleteWithoutOkAsync<
EdgeActionExecutionFilter,
Azure.ResourceManager.Foundations.BaseParameters<EdgeActionExecutionFilter>,
ArmLroLocationHeader & Azure.Core.Foundations.RetryAfterHeader,
{},
ArmDeletedResponse | ArmDeleteAcceptedLroResponse | ArmDeletedNoContentResponse
>;
listByEdgeAction is ArmResourceListByParent<EdgeActionExecutionFilter>;
}
1 change: 1 addition & 0 deletions ...dn/EdgeActions/preview/2025-09-01-preview/examples/EdgeActionExecutionFilters_Delete.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
"executionFilter": "executionFilter1"
},
"responses": {
"200": {},
"202": {
"headers": {
"location": "https://management.azure.com/subscriptions/subid/resourcegroups/resourceGroupName/providers/Microsoft.Cdn/operationresults/operationId?api-version=2025-09-01-preview"
Expand Down
1 change: 1 addition & 0 deletions ...rosoft.Cdn/EdgeActions/preview/2025-09-01-preview/examples/EdgeActionVersions_Delete.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
"version": "version1"
},
"responses": {
"200": {},
"202": {
"headers": {
"location": "https://management.azure.com/subscriptions/subid/resourcegroups/resourceGroupName/providers/Microsoft.Cdn/operationresults/operationId?api-version=2025-09-01-preview"
Expand Down
1 change: 1 addition & 0 deletions ...ger/Microsoft.Cdn/EdgeActions/preview/2025-09-01-preview/examples/EdgeActions_Delete.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
"edgeActionName": "edgeAction1"
},
"responses": {
"200": {},
"202": {
"headers": {
"location": "https://management.azure.com/subscriptions/subid/resourcegroups/resourceGroupName/providers/Microsoft.Cdn/operationresults/operationId?api-version=2024-03-06-preview"
Expand Down
13 changes: 11 additions & 2 deletions ...on/cdn/resource-manager/Microsoft.Cdn/EdgeActions/preview/2025-09-01-preview/openapi.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,6 +353,9 @@
}
],
"responses": {
"200": {
"description": "Resource deleted successfully."
},
"202": {
"description": "Resource deletion accepted.",
"headers": {
Expand Down Expand Up @@ -845,6 +848,9 @@
}
],
"responses": {
"200": {
"description": "Resource deleted successfully."
},
"202": {
"description": "Resource deletion accepted.",
"headers": {
Expand Down Expand Up @@ -1190,6 +1196,9 @@
}
],
"responses": {
"200": {
"description": "Resource deleted successfully."
},
"202": {
"description": "Resource deletion accepted.",
"headers": {
Expand Down Expand Up @@ -1315,7 +1324,7 @@
"tags": [
"EdgeActionVersions"
],
"description": "A long-running resource action.",
"description": "Get the version code for the edge action version.",
"parameters": [
{
"$ref": "../../../../../../common-types/resource-management/v6/types.json#/parameters/ApiVersionParameter"
Expand Down Expand Up @@ -1390,7 +1399,7 @@
"tags": [
"EdgeActionVersions"
],
"description": "A long-running resource action.",
"description": "Swap the default version for the edge action.",
"parameters": [
{
"$ref": "../../../../../../common-types/resource-management/v6/types.json#/parameters/ApiVersionParameter"
Expand Down
1 change: 1 addition & 0 deletions ...dn/EdgeActions/preview/2025-12-01-preview/examples/EdgeActionExecutionFilters_Delete.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
"executionFilter": "executionFilter1"
},
"responses": {
"200": {},
"202": {
"headers": {
"location": "https://management.azure.com/subscriptions/subid/resourcegroups/resourceGroupName/providers/Microsoft.Cdn/operationresults/operationId?api-version=2025-09-01-preview"
Expand Down
1 change: 1 addition & 0 deletions ...rosoft.Cdn/EdgeActions/preview/2025-12-01-preview/examples/EdgeActionVersions_Delete.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
"version": "version1"
},
"responses": {
"200": {},
"202": {
"headers": {
"location": "https://management.azure.com/subscriptions/subid/resourcegroups/resourceGroupName/providers/Microsoft.Cdn/operationresults/operationId?api-version=2025-09-01-preview"
Expand Down
1 change: 1 addition & 0 deletions ...ger/Microsoft.Cdn/EdgeActions/preview/2025-12-01-preview/examples/EdgeActions_Delete.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
"edgeActionName": "edgeAction1"
},
"responses": {
"200": {},
"202": {
"headers": {
"location": "https://management.azure.com/subscriptions/subid/resourcegroups/resourceGroupName/providers/Microsoft.Cdn/operationresults/operationId?api-version=2024-03-06-preview"
Expand Down
13 changes: 11 additions & 2 deletions ...on/cdn/resource-manager/Microsoft.Cdn/EdgeActions/preview/2025-12-01-preview/openapi.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,6 +353,9 @@
}
],
"responses": {
"200": {
"description": "Resource deleted successfully."
},
"202": {
"description": "Resource deletion accepted.",
"headers": {
Expand Down Expand Up @@ -698,6 +701,9 @@
}
],
"responses": {
"200": {
"description": "Resource deleted successfully."
},
"202": {
"description": "Resource deletion accepted.",
"headers": {
Expand Down Expand Up @@ -1043,6 +1049,9 @@
}
],
"responses": {
"200": {
"description": "Resource deleted successfully."
},
"202": {
"description": "Resource deletion accepted.",
"headers": {
Expand Down Expand Up @@ -1168,7 +1177,7 @@
"tags": [
"EdgeActionVersions"
],
"description": "A long-running resource action.",
"description": "Get the version code for the edge action version.",
"parameters": [
{
"$ref": "../../../../../../common-types/resource-management/v6/types.json#/parameters/ApiVersionParameter"
Expand Down Expand Up @@ -1243,7 +1252,7 @@
"tags": [
"EdgeActionVersions"
],
"description": "A long-running resource action.",
"description": "Swap the default version for the edge action.",
"parameters": [
{
"$ref": "../../../../../../common-types/resource-management/v6/types.json#/parameters/ApiVersionParameter"
Expand Down
20 changes: 20 additions & 0 deletions specification/cdn/resource-manager/Microsoft.Cdn/EdgeActions/readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,16 @@ suppressions:
where:
- $.paths["/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Cdn/edgeActions/{edgeActionName}/versions/{version}/swapDefault"].post
reason: Preexisting LRO pattern (200,202) retained for backward compatibility with 2024-07-22-preview.
# Delete operations return 200 for synchronous completion in addition to 202/204 for LRO pattern.
- code: DeleteResponseCodes
where:
- $.paths["/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Cdn/edgeActions/{edgeActionName}"].delete
- $.paths["/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Cdn/edgeActions/{edgeActionName}/versions/{version}"].delete
- $.paths["/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Cdn/edgeActions/{edgeActionName}/executionFilters/{executionFilter}"].delete
reason: >-
EdgeActions RP currently implements synchronous delete (returns 200). Adding 200 to the spec
enables SDK generation to accept 200 as a valid response. Transitioning to async delete (202)
while maintaining backward compatibility with existing clients from 2024-07-22-preview.
```

### Tag: package-2025-09-01-preview
Expand All @@ -78,6 +88,16 @@ suppressions:
- $.paths["/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Cdn/edgeActions/{edgeActionName}/deleteAttachment"].post
- $.paths["/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Cdn/edgeActions/{edgeActionName}/versions/{version}/swapDefault"].post
reason: Preexisting LRO pattern (200,202) retained for backward compatibility with 2024-07-22-preview.
# Delete operations return 200 for synchronous completion in addition to 202/204 for LRO pattern.
- code: DeleteResponseCodes
where:
- $.paths["/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Cdn/edgeActions/{edgeActionName}"].delete
- $.paths["/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Cdn/edgeActions/{edgeActionName}/versions/{version}"].delete
- $.paths["/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Cdn/edgeActions/{edgeActionName}/executionFilters/{executionFilter}"].delete
reason: >-
EdgeActions RP currently implements synchronous delete (returns 200). Adding 200 to the spec
enables SDK generation to accept 200 as a valid response. Transitioning to async delete (202)
while maintaining backward compatibility with existing clients from 2024-07-22-preview.
```

---
Expand Down
Loading